I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
_elm_access_highlight_cycle sets access read_mode as EINA_TRUE
and then never set it back as EINA_FASLE,
which causes elm_widget_focus_steal not to be called when restoring focus tree.
...sorry for a lame explanation (somebody help me out!)
signed-off-by: Jaeun Choi jaeun_choi@naver.com
SVN revision: 83883
so new object would be highlighted if there is new object under the previous mouse(cursor) position.
to fix this issue, elm_access is using the mouse_event_enable flag. but it would cause a problem as
following case: 1. create input window in access module, 2. read something, 3. disable access module
this would be resolved by export api to set mouse_event_enable flag the other day.
SVN revision: 82933
- elm_access_object_item_register(); -> elm_object_item_access_register();
- elm_access_content_cb_set(); -> elm_access_info_cb_set(); The content would be considered as an evas object.
- elm_access_text_set(); -> elm_access_info_set();
SVN revision: 82791
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
i would like to export an API which name is elm_access_external_info_set(Evas_Object *, const char*);
this will be using by application side to set additional accessibility information.
widget could have different information which could be different in another context.
for example: there would be an entry which is for user ID, and there would be another entry which is for password.
in this case, developer would like to add additional information for each entry as below.
entry for user id reads "entry (default information), this entry is for user id (additional information)"
entry for password reads "entry, this entry is for password"
for this reason, i have attached patch. please review the patch and give feedbacks.
SVN revision: 80339
1. _elm_access_item_register(); please use _elm_access_widget_item_register();
2. _elm_access_item_unregister(); please use _elm_access_widget_item_unregister();
3. Elm_Access_Info of Elm_Widget_Item, because Elm_Widget_Item uses elm_access object which has Elm_Access_Info.
SVN revision: 80063
1. add access lines for ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_READ
2. add _elm_access_highlight_cycle(); becase there is a case that
highlight object would be different with focused object after
user moves finger to specific object which does not have focus
currently.
SVN revision: 79884
ChunEon Park
Daniel Juyung Seo
Shinwoo Kim
Carsten Haitzler
Tae-Hwan Kim
Daniel Juyung Seo
Cedric Bail
Daniel Zaoui
Tom Hacohen
Shinwoo Kim