Commit Graph

803 Commits

Author SHA1 Message Date
Carsten Haitzler 846bbafbfb evas - jpg loader - speed up header check for pgoressive jpgs 2013-12-20 14:14:52 +09:00
Guillaume Friloux 8937708e43 Fix coding style madness. 2013-12-19 11:12:46 +01:00
Jihoon Kim 75e399158c ibusimmodule: fix dereference after null check issue
The variable 'str' was used after checking NULL.
2013-12-19 10:20:42 +09:00
Daniel Juyung Seo c4b7f83ef6 ecore_evas: removed author's name from source code as the author requested it.
Git log should be enough for the credit :)

This code was merged into efl upstream by devilhorn's aggressive synchronization between efl upstream and tizen.
But that commit didn't have the author's credit.
However We will never forget the contribution of Gwanglim Lee <gl77.lee@samsung.com>.
2013-12-18 23:49:06 +09:00
ChunEon Park 0947bae126 ecore/ecore_x - show the window if the window should be visible.
when the window alpha mode is changed, the x window is re-created.
but if the window is going on the show state(not visible yet but waiting for visible from xserver) this window never be visible.
so here it make the window visible also if the window is going on the visible state.
2013-12-17 20:37:17 +09:00
Carsten Haitzler 5dfe3789f2 evas - fb engine - fix mem leak if ioctl fails on fb mode
this fixes CID 1137852
2013-12-15 11:25:56 +09:00
Carsten Haitzler d3caca21e5 evas - software-x11 - fill in unused struct members to avoid uninitialized
this shoudl fix CID 1039548 (missed other memmbers before) and if
valgrind ever sees this now it won't complain either.
2013-12-15 11:12:47 +09:00
Carsten Haitzler 611714649b evas - silence coverity in code
fixes CID 1039549 and CID 1039548 - though it isn't a bug, but means
it should not come back in coverity.
2013-12-13 21:26:05 +09:00
Jihoon Kim 236c9a1520 ibusimmodule: support preedit style
This patch will support to display the style of preedit such as underline, reverse.
2013-12-13 20:17:19 +09:00
Carsten Haitzler 8f876cfe72 evas - fix gif loader drop of image data sometimes (image dump/flush)
stable release - cherry-pick me!

this fixses some still gifs going missing.
2013-12-12 18:42:13 +09:00
Carsten Haitzler 6a75806e54 evas - evas gl - fix realloc failure case to handle it properly
patched shader string realloc failure not handled right - could leak
patched string and p.
2013-12-11 22:44:42 +09:00
Carsten Haitzler f3d1db0fba evas - evas_gl - fix shader patch to not free static strings
parsing problem with opengl_strtok() which would free the previous
token "p", but in some cases it would be a const string. this should
fix CID 1039653
2013-12-11 22:40:15 +09:00
Carsten Haitzler 6a054930ff ecore - ecore systemd module - unused var warning - remove unused var 2013-12-11 20:21:32 +09:00
Carsten Haitzler 1dc9f1fece emotion - generic module - re-order code to make coverty happy
this fixes CID 1039884 which isn't a real problem as the callback del
never dereferences the data pointer - just uses it as a value, but
this is really to ensure that it doesn't come back if the code were to
change.
2013-12-11 19:54:15 +09:00
Carsten Haitzler 97a491dd90 evas - gl - ifdef out unused var with non-gles build 2013-12-11 18:26:45 +09:00
Carsten Haitzler 24c6424670 evas - gl - use snprintf for safety (never likely anyway, so code was fine) 2013-12-11 18:25:29 +09:00
Carsten Haitzler 22da09105d evas gif loader - address animated always being true
this addresses CID 1135790 and removes useless checks.
2013-12-11 18:10:15 +09:00
Carsten Haitzler 9a3294d1cb gif loader - handle theoretical NULL loader_data case 2013-12-11 09:23:09 +09:00
Carsten Haitzler 3047ec4d91 evas - fix gif loader cpu overuse - used too much cpu to decode anims
stable release - cherry-pick me!

the evas gif loader used way too much cpu to decode animated gifs
because in the rewrite that made it correct, it did not store the
current gif file handle and state, thus each frame it would have to
decode all frames before that one before finally decoding the final
one. that means to decode frame 200, it decoded frame 1, 2, 3, 4 etc.
all the way up to 199 THEN decoded 200 on top, so decode cost became
progressively more then further through the animation you were.

this fixes that by storing state and file handle and allowing you to
iterate through.
2013-12-10 16:38:23 +09:00
Rafael Antognolli 15b5497dfa ecore_imf/wayland: Only call hide_input_panel on im_context_hide().
There's no need to call it on text_input_leave too, otherwise this would
be called twice, the one from text_input_leave possibly being called
after the focus was regain already by a text input, causing the bug
described in T237.

This fixes T237.
2013-12-09 14:25:40 -02:00
Rafael Antognolli cb3fcca0e7 ecore_evas/wayland: Update withdrawn property, and inform state_changed. 2013-12-09 08:26:24 -02:00
Jean-Philippe Andre ce166ec223 Evas: Fix crash in GL engine(s) during preload cancel
In my config, running terminology with the GL engine and under
cserve2, some image could not be loaded. The tex argument
in evas_gl_preload_target_[un]register was NULL, leading to
an immediate crash.
2013-12-09 17:28:02 +09:00
Chris Michael 13caf63420 Fix opaque windows becoming transparent after hide() then show().
This fixes Phab #T611. Previously, windows which were opaque would
become transparent after being hidden and then shown. We fix that by a
call to ecore_wl_window_alpha_set when the window gets shown. This
patch also brings the wayland_egl hide code more inline with the shm
hide code by testing if the surface does not match the existing one.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-09 07:35:16 +00:00
Chris Michael 1ac5a89957 Add code to deal with min, max, step, aspect, and base sizes.
Properly fix efl wayland elm window resize problem.

This adds support for min, max, step, aspect, and base size properties
when resizing a canvas under EFL Wayland.

This Also Properly fixes raster's report for EFL Wayland elm windows not
resizing properly. Previously, when resizing an elm window in wayland,
a portion of the window would draw outside the frame.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-05 11:52:37 +00:00
Chris Michael 8f21dfe06b Set engine aspect function pointer
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-05 11:52:37 +00:00
Chris Michael a36b1641d9 Add common function prototype for setting ecore_evas aspect ratio
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-05 11:52:37 +00:00
Jihoon Kim 3dfc3dcd2c ximmodule: fix issue the cursor of preedit shows the in front of preedit string
Before fixing this issue, the cursor of preedit appears the in front of preedit string.
The cursor of preedit string will appear in the proper position.
2013-12-05 16:06:39 +09:00
Jihoon Kim 0eb5cfaa30 ximimmodule: remove useless code in preedit_string_get
'cursor_pos' variable will be set in the below code, so 'cursor_pos = 0' is useless.
2013-12-05 16:00:39 +09:00
Chris Michael ae7fd6fac0 Fix raster bug report about elm window resize issue (content drawing
outside the window).

Be sure that the EEs requested geometry gets updated in our
common_resize function After min/max have been taken into account.

Elm is using ecore_evas_request_geometry_get in it's resize_job code
(Why...I have no clue lol. Does not seem like a good thing to check).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-04 11:32:45 +00:00
Chris Michael 231790c7cb Update the engine resize edge before we call ecore_wl_window_resize
Ecore_wl_window_resize essentially tells the shell to start the resize
process. We should have the evas engine info's resize_edge updated
Before we start that process so that Evas knows where the resize is
occuring from

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-12-04 11:32:45 +00:00
Cedric Bail 885222f22d evas: fix loader to properly define _XOPEN_SOURCE for Solaris. 2013-12-04 18:33:04 +09:00
Jihoon Kim 8fe2ec9d4b ximmodule: check whether pointer is NULL before accessing in xim_preedit_callback_set
ecore_imf_context_data_get () can return NULL, so it should be checked before using the result value.

This fixes CID 1135273
2013-12-03 13:32:15 +09:00
Rafael Antognolli 615d5ab634 ecore_evas/wayland: Add a function to cleanup the frame callback.
This callback must be manually destroyed and removed on
ecore_evas_hide(), because it won't be delivered anymore after the
surface is destroyed. If the callback still exists, the engine will find
it and avoid doing a new redraw until it is finally called.

Maybe the correct thing to do is to keep this callback in the
Ecore_Wl_Window struct, and have some functions to set/unset it, so it
gets destroyed when the window is hidden. Or when the surface is
destroyed.
2013-12-02 17:54:29 -02:00
Rafael Antognolli 77a4654470 ecore_evas/wayland_egl: Unset the surface on window hide.
We must unset it, so the Evas engine knows that it has to do all the
setup to destroy the EGL surfaces associated with it. And in the case of
an ecore_evas_show, recreate everything again.
2013-12-02 17:52:00 -02:00
Rafael Antognolli ff5533b4e1 ecore_evas/wayland: Implement ecore_evas_withdrawn_set.
Just call ecore_evas_show/hide inside the function.
2013-12-02 17:51:55 -02:00
Rafael Antognolli 5966a730cd evas/wayland_shm: Don't use a global var to store the sent buffer.
When an Ecore_Evas is hidden, it will destroy the buffer swapper. When
it's shown again, it will try to attach a new buffer, that can be same
buffer. If that global var is still pointing to the old buffer, it can
match to it again and avoid sending a new buffer. So, just put this sent
buffer var in the buffer swapper, and it will get set to NULL when the
swapper is destroyed and created again.

This should fix an intermitent problem of ecore_evas_show() not always
working after an ecore_evas_hide() on the wayland_shm engine.
2013-12-02 13:24:56 -02:00
Stanislav Vorobiov 9e3b778acb evas - fix gl egl textrue from pixmap support y invert query extension
Instead of hardcoding yinvert=1 we should query for
EGL_NOK_texture_from_pixmap extension and if it's present
use EGL_Y_INVERTED_NOK value
2013-11-29 19:09:17 +09:00
Jihoon Kim d9e7615a52 xim immodule: fix dereference before NULL check issue in client_window_set
The variable 'info' can be NULL, therefore it should be checked before accessing.

This fixes CID 1039640
2013-11-29 11:35:44 +09:00
Jihoon Kim bab7612bb5 ibusimmodule: check whether pointer is NULL or not before accessing.
The pointer variable str can be NULL, therefore we should check whether it is NULL or not
before accessing.

This fixes CID 1132621, 1132622, 1132623
2013-11-29 11:23:29 +09:00
Cedric Bail d2c5a37f37 evas: this value is never read after that point, simplify logic.
This has been spotted by clang static analyzer.
2013-11-28 17:04:32 +09:00
Cedric Bail 403098fdb2 evas: add missing define for some target. 2013-11-27 13:51:40 +09:00
Cedric Bail f45a75f925 Revert "Revert "evas: allow fuzziness on the texture format returned by GL.""
This reverts commit 87385b05c3 that is necessary for desktop target.
2013-11-27 13:51:40 +09:00
Daniel Juyung Seo 0e0f79c6f2 ecore ibus_imcontext: print the value of cursor_pos only when cursor_pos
is not null.

This fixes coverity CID 1132624.
2013-11-27 01:52:21 +09:00
Daniel Juyung Seo 9314b15add ecore scim_imcontext: do not check null for ic. it was already checked
by EINA_SAFETY_ON_NULL_RETURN.

This fixes coverity CID 1132628.
2013-11-27 01:48:58 +09:00
Rafael Antognolli 662d086837 ecore_evas/wayland: Update comments inside rotation code. 2013-11-26 14:10:15 -02:00
Rafael Antognolli dbb9cf9765 ecore_evas/wayland: Fix non-resize rotation.
Fix phab T392.

Notice that it should reopen T359, as it wasn't really fixed, but a
rotation with resize was being used when a non-resized rotation was
requested. The cause of the "protruding surfaces" is likely the fact
that Elementary is setting the opaque regions manually, instead of
leaving it to Ecore_Evas. This must be fixed either inside Elementary
itself, or adding the "surface extents" (shadow/non-visible surface
parts) info to Ecore_Evas too.
2013-11-26 14:01:35 -02:00
Rafael Antognolli 87385b05c3 Revert "evas: allow fuzziness on the texture format returned by GL."
This reverts commit 2b5b3438e8.

Breaks gl engines when using GLES + EGL.
2013-11-26 11:49:13 -02:00
Cedric Bail 2b5b3438e8 evas: allow fuzziness on the texture format returned by GL. 2013-11-26 17:00:24 +09:00
Carsten Haitzler e03ab668a1 evas - gl engine - async texture upload - protect null tex handle access
this stops a very blantant segv when accessing async->tex when it is
NULL on _evas_gl_preload_main_loop_wakeup().
2013-11-25 22:29:12 +09:00
Carsten Haitzler 2fa8d0cd56 evas - map fast path for rectangular objects had color mul wrong
this fixes the color multiplication logic in the fast path to be
correct.
2013-11-21 21:00:41 +09:00