Commit Graph

269 Commits

Author SHA1 Message Date
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Carsten Haitzler a188fdda01 fix sign/unsigned compare warn 2014-01-11 16:23:23 +09:00
Carsten Haitzler ae306c98fb use long not unsigned long - ftell returns long. 2014-01-11 16:19:25 +09:00
Carsten Haitzler 0c9480fc76 elm map - fix incorrect return check of fread
this fixes CID 1132735 (real bug)
2014-01-10 16:53:43 +09:00
Carsten Haitzler 1ac66c892a elm map - fix incorrect return check of fread
this fixes CID 1132736 (real bug)
2014-01-10 16:52:44 +09:00
Carsten Haitzler 900ae28870 elm map - fix incorrect return check of fread
this fixes CID 1132737 (a real bug)
2014-01-10 16:51:06 +09:00
Jihoon Kim 5b64757cc3 map: fix allocator sizeof operand mismatch reported by clang
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-vKmgoZ.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-5OVcIZ.html#EndPath
2014-01-08 08:51:15 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Carsten Haitzler 9d4a9900cc option build deps that efl guarantees... now just are assumed and not ifdef'd 2013-11-12 22:56:05 +09:00
Tom Hacohen 4c8d03894c Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra

Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
2013-11-07 14:30:22 +00:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
Daniel Juyung Seo 6397761c6a elm_test: Fixed formatting. tab to space.
Changed tab to space before working on the code.
Kinda surprised by the number of tabs we had.
2013-10-14 19:12:32 +09:00
Daniel Juyung Seo aa5934c029 elm_map.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:14:50 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Carsten Haitzler a86577f051 elm map - let's use some neautral colors for map items by default. 2013-09-10 18:49:12 +09:00
ChunEon Park d461a8be05 elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Daniel Juyung Seo 6cf684f02a elm: added more "focused" and "unfocused" documentations.
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
2013-06-10 14:13:55 +09:00
Daniel Juyung Seo 8bfdbd2ba6 elm: all the focusable widget now emits "focused" and "unfocused" smart callbacks.
1. documentations, NEWS, and ChangeLog will be updated later after some more test.
2. need to check entry.
2013-06-07 01:13:37 +09:00
Daniel Juyung Seo fce66c4296 elm_map.c: ELM_SAFE_FREE adoption.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 21:03:51 +09:00
Daniel Juyung Seo 5f053bf79a elm: refactoring. use more ELM_FREE_FUNC. 2013-05-23 15:54:49 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
Daniel Juyung Seo ba4dbce9d9 elm: enhance eina_list_free usages. use EINA_LIST_FREE if needed. 2013-04-10 20:28:35 +09:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
ChunEon Park a7cca7ba3f elementary/map - map supports language,changed 2013-03-29 20:53:11 +09:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
Jaehwan Kim d58d971e6f Add the option about sending signals in content_pos_set.
When the scroller is resized, the signals("elm,action,scroll", "elm,edge,top" so on) shouldn't be sent,
because it's not a scroll-action. So in this case, the content_pos_set should be called without the signals.
2013-02-28 15:18:51 +09:00
Carsten Haitzler 13a895de77 Fix 1byte invalid read & do memset, rewind if needed.
Summary:
1. because eina_simple_xml_parse uses char *, buf should be null
terminated.  So I use memset.
2. Because NULL is needed at the end, I add one more byte.
fread read exact bytes and has no NULL.
3. If buf is failed to alloc (very rarely case), it is not need to rewind and memset.

Test Plan: Use valgrind and elm_map_name_add API

Reviewers: tasn, bluezery

Reviewed By: raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D10
2013-02-25 12:00:07 +09:00
Stefan Schmidt 7129201160 elm_map: Free allocated buffer in all cases.
Very well spotted from Hermet. My original fix only free'ed the buffer
in the case fread failed, but apperently we we always leaked this buffer.

Make sure we free it in all cases.

SVN revision: 84087
2013-02-19 09:04:45 +00:00
ChunEon Park 844b5805ff elementary/widget - don't handle tthe resize objects in widget infrastructure. Acutally these resize objects are sub objects so we don't need to care them separately. This caused overhead in some cases(ie, theme change)
SVN revision: 83990
2013-02-16 13:39:59 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
ChunEon Park 5122a4d821 elementary/map - allocate memory only when it needs
SVN revision: 82850
2013-01-16 03:37:32 +00:00
Daniel Juyung Seo c712b3ce57 elm map: Fixed formatting.
SVN revision: 82465
2013-01-09 15:34:59 +00:00
Jaehwan Kim 6f2142abe9 Fix out-of-bounds read
SVN revision: 82455
2013-01-09 11:47:11 +00:00
ChunEon Park 244b790c58 elementary/map - fixed more insane free in map
SVN revision: 82443
2013-01-09 08:49:30 +00:00
ChunEon Park 0b6a6dfc08 elementary/map - fixed memory leak
SVN revision: 82442
2013-01-09 08:40:56 +00:00
Stefan Schmidt d0793194b5 elm/map: Free buffer on error path
SVN revision: 81342
2012-12-19 10:28:20 +00:00
Cedric BAIL bb6589c3f1 elementary: fix forgotten break.
SVN revision: 80319
2012-12-06 08:59:14 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00
Bluezery c1db5c3bd2 From: Bluezery <ohpowel@gmail.com>
Subject: [E-devel] [E-Devel][Patch][Elementary]Map: Remove delayed job

This patch removes delayed jobs in elm_map.
Previously delayed job is used for queuing the zooming & zoom mode
changing & overlay_showing API requests. Queued jobs are all executed
when pan is calculated.
But actually queued jobs are not needed to be  executed. Just last
jobs are needed to be executed per pan calculation.
So I removed delayed jobs and fill calc job functions to be executed
while calculation is executed.



SVN revision: 79269
2012-11-14 07:10:24 +00:00
Carsten Haitzler c2f161fb3d typo--
SVN revision: 77957
2012-10-13 12:59:39 +00:00