Commit Graph

109 Commits

Author SHA1 Message Date
Sebastian Dransfeld 92b5baaea4 efreet: fix alloca
SVN revision: 79629
2012-11-24 06:43:00 +00:00
Sebastian Dransfeld 199bef6051 efreet: move common function to base
SVN revision: 78293
2012-10-21 04:53:18 +00:00
Sebastian Dransfeld 4eb8b955a9 efreet: optimize stat
use eina_file_stat_ls instead of eina_file.*_ls + ecore_file_is_dir

SVN revision: 78173
2012-10-18 09:12:25 +00:00
Sebastian Dransfeld 9fe5e81ccb efreet: formatting
SVN revision: 78170
2012-10-18 09:11:54 +00:00
Sebastian Dransfeld 2a3cb2d1c9 efreet: remove realpath
Use eina_file_path_sanitize where needed

SVN revision: 78161
2012-10-18 08:10:35 +00:00
Carsten Haitzler 8b19e6eab1 disable some realpath(s) in efreet to rece syscall noise on init...
after some poking around and looking - terminology is taking about
800ms to start ... and we seem to use about 300ms or so of that time
statting files and tregistering them for file monitoring (the dirs
that are found there) and also handling a big batch of incoming file
monitor events for some reason even tho nothing changed.

this cuts down some time+noise, but we need to do a lot of work here. :(



SVN revision: 78108
2012-10-17 09:16:20 +00:00
Sebastian Dransfeld f419175657 efreet: Add parameter checking to exported API
Some efreet APIs do not check input parameters.  So I add checking by
using EINA_SAFETY_ON_XXX().
ISO/IEC statndards says that "If an argument to a function has an
invalid value, behavior is undefined" . But this is  just for the
primitive functions such as libc.  I think that parameter checking is
needed in at least EFL exported APIs to prevent run-time abnormal
behavior.
EINA_SAFTETY_ON_XXX are better than "if (xxx) return" because it gives
error message and can be maintainable.

Patch by Bluezery, modified by me

SVN revision: 71366
2012-05-23 20:10:27 +00:00
Sebastian Dransfeld c53f0f501b efreet: name_length -> name_start
SVN revision: 67311
2012-01-19 01:05:33 +00:00
Sebastian Dransfeld 820722a779 efreet: opendir -> eina_file_direct_ls
SVN revision: 67308
2012-01-19 00:35:51 +00:00
Cedric BAIL aeed35b2ea efreet: correctly include dirent.h in the right place.
NOTE: for after 1.1, we should really use eina_*_ls API instead.


SVN revision: 65292
2011-11-16 10:56:44 +00:00
Sebastian Dransfeld 56f3b3b278 efreet: Clean headers
Might affect other systems, please just add the needed headers and don't
complain.

SVN revision: 62557
2011-08-18 07:35:48 +00:00
Carsten Haitzler 71b7acde90 doxy -> h files.
SVN revision: 58487
2011-04-08 11:01:08 +00:00
Mike Blumenkrantz 96be628d43 use eina_log more effectively: replace all printfs with appropriate log functions and use EINA_LOG_ERR instead of ERR when log dom fails to init
SVN revision: 57858
2011-03-18 19:47:57 +00:00
Sebastian Dransfeld 1cfad6b93c And really remove init/shutdown of xml
SVN revision: 56737
2011-02-05 20:34:22 +00:00
Sebastian Dransfeld da2c871e24 Remove duplicate logging macros
SVN revision: 56732
2011-02-05 19:07:07 +00:00
Sebastian Dransfeld accd246c72 Set EFREET_MODULE_LOG_DOM to -1 after unregister
SVN revision: 56731
2011-02-05 19:06:55 +00:00
Sebastian Dransfeld 18c663b7e2 Remove efreet_xml_{init,shutdown}() from menu
SVN revision: 56730
2011-02-05 19:06:45 +00:00
Sebastian Dransfeld 6ed10251db Remove global log domain
SVN revision: 56729
2011-02-05 19:05:55 +00:00
Sebastian Dransfeld b069c18c4b Check for pointer equality
SVN revision: 56600
2011-01-31 11:45:19 +00:00
rephorm 618ed1f5fb don't crash on an empty <Name></Name> tag in a menu
SVN revision: 56394
2011-01-30 03:55:06 +00:00
Sebastian Dransfeld 978741a789 doc
SVN revision: 56326
2011-01-27 17:49:45 +00:00
Sebastian Dransfeld 9e3be1a1a4 use eina_hash_direct_add
use eina_hash_direct_add where we use a struct member as key

SVN revision: 55193
2010-12-03 14:53:01 +00:00
Vincent Torri 42f57e9fc3 put alloca declaration after config.h
SVN revision: 55001
2010-11-25 23:48:59 +00:00
Sebastian Dransfeld b645d20ab2 fix memleak and use realpath directly
SVN revision: 54927
2010-11-24 10:33:30 +00:00
Sebastian Dransfeld b2ecad6a06 simplify list deletion
use eina_list_free instead of removing one and one element

SVN revision: 53689
2010-10-20 20:39:19 +00:00
Gustavo Sverzut Barbieri bc2c59746d log domains in lower-case only please.
let's make it a standard so we don't have to look at the code
everytime to figure out the name...



SVN revision: 53171
2010-10-07 22:22:33 +00:00
Lucas De Marchi 67771ee617 Fix common misspellings
Following misspellings were fixed:

acheive->achieve
appart->apart
isnt->isn't
succesfully->successfully
taht->that



SVN revision: 51987
2010-09-08 11:27:59 +00:00
Lucas De Marchi 5a8a8c9014 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Cedric BAIL ba22eb6af8 * efreet: less warning by Albin Tonnerre.
SVN revision: 51247
2010-08-17 12:03:10 +00:00
Sebastian Dransfeld 7b5e166c85 Check NULL return
SVN revision: 50817
2010-08-04 18:21:20 +00:00
Lucas De Marchi 0a4617ae38 FORMATTING
* Remove vim modelines:
 find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
 find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;

* Remove leading blank lines:
 find . -name '*.[cxh]' -exec sed -i '/./,$!d'

If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0



SVN revision: 50816
2010-08-04 16:57:32 +00:00
Sebastian Dransfeld 08e9824c6e check return value from NEW
SVN revision: 50784
2010-08-03 19:31:44 +00:00
Sebastian Dransfeld 1576311af3 alloc the right amount of mem
sizeof(char) is 1, and sizeof(char *) is wrong for strings

SVN revision: 50782
2010-08-03 19:31:24 +00:00
Sebastian Dransfeld 69d0626265 use alloca for in function mem
SVN revision: 50781
2010-08-03 19:31:14 +00:00
Sebastian Dransfeld a384141abc efreet: Check return value from opendir
SVN revision: 48081
2010-04-17 18:39:13 +00:00
Sebastian Dransfeld 973965f165 efreet: TODO++
SVN revision: 47788
2010-04-06 18:35:18 +00:00
Sebastian Dransfeld 9464e87d74 efreet: stringshare
SVN revision: 47658
2010-04-01 19:31:38 +00:00
Sebastian Dransfeld 4501c577e3 efreet: stringshare
SVN revision: 47657
2010-04-01 19:30:13 +00:00
Sebastian Dransfeld 6d00dc126b efreet: use alloca for local dynamic buffer
SVN revision: 47597
2010-03-30 12:22:15 +00:00
Sebastian Dransfeld 1b6662b2e9 efreet: remove strdup
SVN revision: 47596
2010-03-30 12:22:05 +00:00
Sebastian Dransfeld a44f87390d efreet: benefit from stringshare
SVN revision: 47595
2010-03-30 12:21:55 +00:00
Sebastian Dransfeld 40a5c9a155 efreet: stringshare
SVN revision: 47593
2010-03-30 12:21:33 +00:00
Sebastian Dransfeld 72a79471d5 remove strdup
SVN revision: 47592
2010-03-30 12:21:23 +00:00
Sebastian Dransfeld ac18d14316 efreet: benefit from stringshare
Since both values are stringshared, we can use direct comparison.

SVN revision: 47591
2010-03-30 12:21:12 +00:00
Sebastian Dransfeld 1063df8b9e efreet: stringshare
SVN revision: 47590
2010-03-30 12:20:55 +00:00
Sebastian Dransfeld 6da3c6846d efreet: stringshare
SVN revision: 47588
2010-03-30 11:07:19 +00:00
Sebastian Dransfeld 592ebdcb5b efreet: stringshare
SVN revision: 47587
2010-03-30 11:07:07 +00:00
Sebastian Dransfeld c06492ded0 efreet: stringshare
SVN revision: 47586
2010-03-30 11:06:56 +00:00
Sebastian Dransfeld 3db40c0d97 efreet: fix strdup + stringshare
SVN revision: 47568
2010-03-29 20:14:43 +00:00
Sebastian Dransfeld 4e8ebec3f6 efreet_menu.c: Fix compiler warning
SVN revision: 47469
2010-03-26 05:29:15 +00:00