Hosang Kim
37f13a9d10
elm_interface_scrollable: change return value for post events.
...
Summary:
1. Scroller in scroller case, callback process should continue.
If child scroller does not scroll, parent scroller should be checked whether scroll or not.
So returning EINA_TRUE is necessary.
2. down.dragged flag is always EINA_FALSE, so scroll is never unlocked.
@fix
Test Plan:
precondition
elementary_config -> scrolling -> Set Scroll Smooth Amount to 0
elementary_test -> pagescroller
Reviewers: woohyun, zmike, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6187
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-25 10:04:50 -07:00
Lauro Moura
a8b7833a48
efl_mono: Fix efl_add_internal_end call.
...
Summary:
It was missing setting the 'is_ref' parameter to 1 to mirror the
internal_start call.
Test Plan: make check
Reviewers: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6193
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-25 10:01:09 -07:00
Lauro Moura
7d4c5f5d7c
eo_cxx: Fix do_eo_add after lifecycle branch.
...
Summary:
Also changed the previously failing tests to use ck_assert_int_eqinstead
of fail_if for better reporting.
Test Plan: make check
Reviewers: cedric, felipealmeida
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6194
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-25 10:00:42 -07:00
Youngbok Shin
455775c2e3
elementary textpath: improves text rendering quality of curved text
...
Summary:
There was wrong logic for calculating # of slices, dt, dist of each segment.
It caused bad rendering quality by putting too much slices on small text.
In addition, textpath didn't care about smoothness of curve's slope changing.
The patch fixes to check differences of previous points and next points for Evas Map.
So, textpath can show more smoothly curved text.
Also, it fixes "autofit" bug when text is much huge than given circle's size.
@tix
Test Plan:
- I'll attach screenshots for comparing rendering quality.
- To see "autofit" bug.
1. Run the following command.
ELM_ACCEL=gl ELM_SCALE=2.0 elementary_test -to "efl.ui.textpath"
2. Toggle "autofit" check box.
3. See the bug case. Textpath can't show all text properly.
Reviewers: raster, cedric, thiepha
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6195
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-25 09:59:04 -07:00
Cedric BAIL
2a5dc74408
elementary: fetch the model explicitely.
...
T6939
2018-05-25 09:16:45 -07:00
WooHyun Jung
4d0bb5ec35
efl_ui_win: fix wrong comparison in icon_object_set
...
@fix
2018-05-25 16:42:52 +09:00
Cedric BAIL
311e35a0dd
elementary: prevent model from being invalidated when their parent model get destroyed.
2018-05-24 16:02:21 -07:00
Cedric BAIL
a098ee4460
elementary: ctxpopup is using legacy Elm.List which use legacy Elm.Object.Item, fix accordingly.
2018-05-24 16:02:21 -07:00
Cedric BAIL
0eacebfec8
elementary: fix elm_list items lifecycle.
...
Elm.List.Item lifecycle where an exception in Efl. They were trying to prevent the death of
there parent, to avoid dealing with safely walking on items list. This has been on the todo
list for years and is now fixed by this patch.
2018-05-24 16:02:21 -07:00
Cedric BAIL
774ae32108
evas: make smart object deletion more robust to bad child behavior.
2018-05-24 16:02:21 -07:00
Cedric BAIL
40af4fe94b
elementary: refactor filesector target cleanup to not leave function handler behind.
2018-05-24 16:02:21 -07:00
Cedric BAIL
85598a8a40
elementary: make sure to use the model that generated the event to fetch information from.
2018-05-24 16:02:21 -07:00
Cedric BAIL
228ecdeb51
elementary: make sure fileselector button model has a parent and self destruct properly.
2018-05-24 16:02:21 -07:00
Cedric BAIL
901eeb94e3
eio: enforce eio model to have a parent that provide main loop access.
2018-05-24 16:02:21 -07:00
Cedric BAIL
b59911d5af
ecore: during shutdown their is no need to delay anything.
2018-05-24 16:02:21 -07:00
Cedric BAIL
38d8b615c8
eo: an object is invalidated if it is invalidated or if any parent is invalidated.
2018-05-24 16:02:21 -07:00
Cedric BAIL
384f30c8ec
ecore_con: disconnect from the server as soon as it request it.
...
Ecore_Event can still be in flight while the client get freed by the server.
We are protected agaist that and keep the client partially alive until the event
are processed, but we need to disconnect from the server as soon as possible
as we might outlive the server.
2018-05-24 16:02:21 -07:00
Cedric BAIL
256b2103c6
evas: disable del hook when pushed inside the hash.
...
This is necessary in case of cycling init/shutdown as the hash will
destroy the Event, but the hook will instantly reinsert it.
2018-05-24 16:02:21 -07:00
Cedric BAIL
5b9694da3e
eo: match raise of error level in tests.
2018-05-24 16:02:21 -07:00
Cedric BAIL
3489708052
eo: we are actually testing internal function too here.
2018-05-24 16:02:20 -07:00
Cedric BAIL
0c0f2b75e4
eo: add infrastructure to test critical Eina Error.
2018-05-24 16:02:20 -07:00
Cedric BAIL
48738d125c
eo: improve tests suite debugging by always displaying the error message before abort.
2018-05-24 16:02:20 -07:00
Cedric BAIL
b1954ce1e7
eo: move wref set to NULL to append after last event.
...
Making wref disapear before the last event require additional work to use
them during the FREE event. As I think we should introduce a wref that
disapear after the invalidate state, it makes sense to move that to a later
stage. Especially because their is no specific event related to them
being set to NULL.
2018-05-24 16:02:20 -07:00
Cedric Bail
4a3b0e7f25
evas: improve test to actually test something meaningful.
2018-05-24 16:02:20 -07:00
Cedric BAIL
a5f9ee5ab3
elementary: fix configuration destruction by actually calling the proper way of destruction.
2018-05-24 16:02:20 -07:00
Cedric Bail
b671a2c34f
evas: actually we expect gradient to live as long as the part that is using them.
2018-05-24 16:02:20 -07:00
Cedric Bail
301340baf6
ecore_con: allow for NULL to do nothing.
2018-05-24 16:02:20 -07:00
Cedric Bail
13ae5b1f0c
elementary: the config subsystem expect a stringshare.
2018-05-24 16:02:20 -07:00
Cedric Bail
7e4b66a58d
evas: multiple call to evas_object_del are allowed even after the first one succeeded.
2018-05-24 16:02:20 -07:00
Cedric Bail
fa795b17d3
eo: allow efl_part during object invalidate.
2018-05-24 16:02:20 -07:00
Cedric BAIL
a90b5fa930
eo: remove parent_sink as this hack should not be necessary anymore.
2018-05-24 16:02:20 -07:00
Cedric BAIL
0cc07f4e6b
eo: try to make efl_add and efl_add_ref refcounting sane in all case.
2018-05-24 16:02:20 -07:00
Cedric BAIL
2894a2e3c3
ecore_file: on shutdown properly set to NULL to avoid confusion when cycling init/shutdown.
2018-05-24 16:02:20 -07:00
Cedric BAIL
c49d293915
ecore: allow for NULL file handler request.
2018-05-24 16:02:20 -07:00
Cedric BAIL
0d52ded215
elementary: destroy timer as they could tick during shutdown.
2018-05-24 16:02:20 -07:00
Cedric BAIL
3d94f477d4
elementary: properly destroy block events object during destruction.
2018-05-24 16:02:20 -07:00
Cedric BAIL
75bb7c049f
evas: do not crash if constructor fail and invalidate is run on a partial object.
2018-05-24 16:02:20 -07:00
Cedric BAIL
ccf320b06a
eo: improve error reporting to display object pointer (without accessing it).
2018-05-24 16:02:20 -07:00
Cedric BAIL
5f5af596e0
elementary: cleanup genlist destructor to order content destruction correctly.
2018-05-24 16:02:20 -07:00
Cedric BAIL
15995ff0eb
evas: make evas_object_free work in case of lost reference to Eo object.
...
This is clearly a workaround to a bad situation, but there is no case
that I can find that solely lead to object being NULL nor is there any
code that should do that, but still it does in some case...
2018-05-24 16:02:20 -07:00
Cedric BAIL
33c278b898
evas: detect incoherency in object content and report problem.
2018-05-24 16:02:20 -07:00
Cedric BAIL
062471b5ee
evas: handle Evas_Object constructor failure case better.
2018-05-24 16:02:20 -07:00
Cedric BAIL
94a9a733a5
edje: simplify part handling as we are now guaranteed that a part as no parent when reaching the del intercept.
2018-05-24 16:02:20 -07:00
Cedric BAIL
0bf7a5ea13
eo: make sure that reporting object refcount during efl_noref, doesn't lead to recursive loop.
2018-05-24 16:02:20 -07:00
Cedric BAIL
5c23ea00b4
eo: add warning in case of a terrible situation happen.
2018-05-24 16:02:20 -07:00
Cedric BAIL
b0aa5d806b
eo: efl_invalidate should also be triggered for object with no parent before the destructor.
2018-05-24 16:02:20 -07:00
Cedric BAIL
f7b08c4537
ecore: properly cleanup variable on shutdown, so that cycling another init doesn't crash.
2018-05-24 16:02:20 -07:00
Cedric Bail
a8b70953e4
evas: improve evas child destruction order.
...
Technically I do not thing it is a correct behavior to force destroy
reference that evas do not hold, but evas_object are deaply tied to
the canvas they are build on and even after invalidate it is hard
to not have function call that would lead to crash. Making the pointer
incorrect thanks to eo indirection seems safer here.
2018-05-24 16:02:20 -07:00
Cedric Bail
429084e2fb
evas: do not override lifecycle by overriding efl_parent_set.
2018-05-24 16:02:20 -07:00
Cedric Bail
4479d035be
evas: reindent code properly.
2018-05-24 16:02:19 -07:00
Cedric Bail
e1d41eef3a
eo: actually enforcing the efl_parent_set code path is necessary to enforce the predictability of the code path.
2018-05-24 16:02:19 -07:00
Cedric Bail
23e2c0bdb8
eo: as efl_del is not an Eo API call anymore, manually protect call with refcount.
2018-05-24 16:02:19 -07:00
Cedric Bail
48b8118123
eo: update refcount before sending efl_noref event to avoid double update during events propagation.
2018-05-24 16:02:19 -07:00
Cedric Bail
a16d127997
ecore: because fd_handler do not have the main loop as parent, the main loop can die before them.
2018-05-24 16:02:19 -07:00
Cedric Bail
5c9815676b
evas: move the del event to match invalidate and free event to the end of the destructor.
2018-05-24 16:02:19 -07:00
Cedric BAIL
b5b9f72f57
elementary: when there is no file listed yet, no need to request them.
2018-05-24 16:02:19 -07:00
Cedric BAIL
842b2ec381
eina: make it possible to return an EINA_VALUE_EMPTY by just requesting a new value of type NULL.
2018-05-24 16:02:19 -07:00
Cedric BAIL
671fc92f08
eina: check the type before looking at anything else to avoid triggering valgrind warning.
2018-05-24 16:02:19 -07:00
Cedric BAIL
e4a6aaa4c1
elementary: enforce walk to protect the object existence by using eo refcounting.
2018-05-24 16:02:19 -07:00
Cedric BAIL
048a93e6e3
elementary: reorder operation to only call efl_parent_set when the object still has a chance to exist.
2018-05-24 16:02:19 -07:00
Cedric BAIL
ddccd9e306
evas: destructor can not be called recursively, we should rely on Eo refcount.
2018-05-24 16:02:19 -07:00
Cedric Bail
d052f001be
eo: move destruction of the link with children to be always after invalidate.
2018-05-24 16:02:19 -07:00
Cedric Bail
3a1fe14742
eo: propagate invalidate before destroying the link to the parent.
2018-05-24 16:02:19 -07:00
Cedric Bail
91cd4f7c0c
evas: actually we do not even need to NULL it, if we wref it.
2018-05-24 16:02:19 -07:00
Cedric Bail
3347db4bea
edje: do not reparent when the object is dead already.
2018-05-24 16:02:19 -07:00
Cedric Bail
a3c91d14a9
eo: improve message for debugging life cycle issues.
2018-05-24 16:02:19 -07:00
Cedric Bail
f49ccff71d
edje: forgot to propagate invalidate upward.
2018-05-24 16:02:19 -07:00
Lauro Moura
02f77eb092
cxx: Fix examples after part changes
...
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-24 16:02:19 -07:00
Lauro Moura
969efc6399
examples: Elm: Add dependency on efl.la due to efl_part
...
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-24 16:02:19 -07:00
Lauro Moura
f510d536a4
efl_mono: Fixes after efl_part/del changes.
...
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-24 16:02:19 -07:00
Cedric Bail
bff5c37c1b
ecore_evas: we shouldn't do anything when we are deleted.
2018-05-24 16:02:19 -07:00
Cedric Bail
741f3e39ed
evas: preserve evas_object_del logic to not really destroy an object until it is fully unref first.
2018-05-24 16:02:19 -07:00
Cedric Bail
c2e8b492b1
evas: enforce legacy parent to be the canvas.
2018-05-24 16:02:19 -07:00
Cedric Bail
f44511d0f9
elementary: refactor by using elm_legacy_add.
2018-05-24 16:02:19 -07:00
Cedric Bail
b482107a19
evas: add a way to figure out the evas class that should be the real parent for all legacy object.
2018-05-24 16:02:19 -07:00
Cedric BAIL
f29e1db94b
elementary: make toolbar 'more_item' properly self destruct.
2018-05-24 16:02:19 -07:00
Cedric BAIL
2ce788063a
elementary: no need to recalculate the layout during invalidate.
2018-05-24 16:02:19 -07:00
Cedric BAIL
9e0f9539dd
elementary: the pan object of the map object was created with efl_add, adjust accordingly.
2018-05-24 16:02:19 -07:00
Cedric BAIL
0fe3b7962d
elementary: due to lifecycle difference between legacy object and unified object, we need to track their lifecycle more explicitely.
...
It is my understanding that some items view are created with efl_add directly
and manipulate VIEW directly with Eo new API. This clash with the inconsistent
behavior that evas_object_del expect. To work around this, we track object life
by explictely relying on efl_wref_add while holding the pointer to the object.
2018-05-24 16:02:19 -07:00
Cedric BAIL
0239099d01
eo: efl_del should not be something anyone can override this can break so many things.
...
Allowing override of efl_del allow for messing with object life cycle which can create
problem for binding where an object was expected to be invalidated, but isn't really.
2018-05-24 16:02:19 -07:00
Cedric BAIL
30d02a7410
evas: try to protect old legacy lifecycle without overloading Efl.Del.
2018-05-24 16:02:19 -07:00
Cedric BAIL
590304d597
eio: properly handle Eio.Model lifecycle inside Elm.Fileselector.
...
Differential Revision: https://phab.enlightenment.org/D6107
2018-05-24 16:02:18 -07:00
Cedric BAIL
c753fc793b
elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense.
...
Differential Revision: https://phab.enlightenment.org/D6106
2018-05-24 16:02:18 -07:00
Cedric BAIL
1991900fd6
elementary: no need to check for part during destruction.
...
Differential Revision: https://phab.enlightenment.org/D6105
2018-05-24 16:02:18 -07:00
Cedric BAIL
6476896ec5
elementary: no need for resize an object during destruction.
...
Differential Revision: https://phab.enlightenment.org/D6104
2018-05-24 16:02:18 -07:00
Cedric BAIL
2508c1a3ae
elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor.
...
Differential Revision: https://phab.enlightenment.org/D6103
2018-05-24 16:02:18 -07:00
Cedric BAIL
dbbcfa4a59
elementary: small correction in the API of Efl.Access.Object to have proper lifecycle.
...
This API require more review, I have just fixed API that return type that are
inconsistent over time and fail to allow for proper lifecycle of event, which
lead to crash when those event trigger at unexpected point.
Differential Revision: https://phab.enlightenment.org/D6102
2018-05-24 16:02:18 -07:00
Cedric BAIL
fe14abd929
evas: refactor efl_input_event and remove some of the lifecycle hack.
...
Differential Revision: https://phab.enlightenment.org/D6101
2018-05-24 16:02:18 -07:00
Cedric BAIL
c447b61756
eo: actually during invalidating we already have an invalidated object.
...
Differential Revision: https://phab.enlightenment.org/D6100
2018-05-24 16:02:18 -07:00
Cedric BAIL
4c9a33a388
eo: move EFL internal function ___efl_ref2 also to eo_internal.h
...
Differential Revision: https://phab.enlightenment.org/D6099
2018-05-24 16:02:18 -07:00
Cedric BAIL
8a513a522e
efl: major rewrite of efl_part.
...
The interface efl_part_get should not be directly called from C, but the efl_part
wrapper should. It rely on efl_noref to properly destroy the object. Binding can
control the lifecycle of the reference the way they want by either calling the
wrapper or efl_part_get directly. It also means that the ugly ___efl_auto_unref_set
doesn't need to be exposed outside of EFL anymore.
Differential Revision: https://phab.enlightenment.org/D6098
2018-05-24 16:02:18 -07:00
Cedric BAIL
c28eb28728
eo: check for allow_parent_unref during efl_unref and silence warning.
...
Differential Revision: https://phab.enlightenment.org/D6097
2018-05-24 16:02:18 -07:00
Cedric BAIL
dcfddcd283
eo: make sure efl_noref is always called at the proper time.
...
Differential Revision: https://phab.enlightenment.org/D6096
2018-05-24 16:02:18 -07:00
Cedric BAIL
79e4947f3e
eo: add an automatic fallback at the moment when efl_unref instead of efl_del is called.
...
Differential Revision: https://phab.enlightenment.org/D6095
2018-05-24 16:02:18 -07:00
Cedric Bail
c1cef1e74b
elementary: object created with efl_add should be destroyed with efl_del.
...
Differential Revision: https://phab.enlightenment.org/D6094
2018-05-24 16:02:18 -07:00
Cedric Bail
0135b23e45
elementary: object allocated with efl_add should be destroyed with efl_del.
...
Differential Revision: https://phab.enlightenment.org/D6093
2018-05-24 16:02:18 -07:00
Cedric Bail
aaa827c2d2
eldbus: fix unref of eldbus to not throw warning all over the place.
...
Especially to note, that when giving a message to send, the caller
do not own it anymore and should not unref it.
Differential Revision: https://phab.enlightenment.org/D6092
2018-05-24 16:02:18 -07:00
Cedric Bail
6e078edaa9
eldbus: manage death of children during invalidate.
...
Differential Revision: https://phab.enlightenment.org/D6091
2018-05-24 16:02:18 -07:00
Cedric Bail
71cd44c176
eldbus: object created with efl_add should be destroyed with efl_del.
...
Differential Revision: https://phab.enlightenment.org/D6090
2018-05-24 16:02:18 -07:00
Cedric Bail
6bb450d7ee
ecore: first invalidate the loop and its children, then destroy all the object capability.
...
Differential Revision: https://phab.enlightenment.org/D6089
2018-05-24 16:02:18 -07:00
Cedric BAIL
93a49da161
eo: optimize efl object reuse by limiting the amount of call to pointer translation.
...
Differential Revision: https://phab.enlightenment.org/D6088
2018-05-24 16:02:18 -07:00
Cedric BAIL
ae5d0005d3
edje: properly handle lifecycle of edje global object.x
...
Differential Revision: https://phab.enlightenment.org/D6087
2018-05-24 16:02:18 -07:00
Cedric BAIL
ef6cac1476
eo: prevent parenting to an already invalidated parent.
...
Differential Revision: https://phab.enlightenment.org/D6086
2018-05-24 16:02:18 -07:00
Cedric BAIL
546a4c79e0
eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating.
...
Add also a comment to justify why we do force parent to NULL during invalidate.
Differential Revision: https://phab.enlightenment.org/D6085
2018-05-24 16:02:18 -07:00
Cedric BAIL
69c9d5bb50
ecore_con: correct lifecycle of object used by Efl.Net.Dialer.Ssl.
...
Differential Revision: https://phab.enlightenment.org/D6084
2018-05-24 16:02:18 -07:00
Cedric BAIL
594c254183
ecore_con: trigger teardown during invalidate.
...
Delaying teardown might result in code expecting parent to still be valid,
especially call to efl_provider_find won't work anymore.
Differential Revision: https://phab.enlightenment.org/D6083
2018-05-24 16:02:18 -07:00
Cedric BAIL
e46369a569
ecore_con: it is best to call the super destructor and not touch the object anymore after.
...
Differential Revision: https://phab.enlightenment.org/D6082
2018-05-24 16:02:18 -07:00
Cedric BAIL
67e48c679d
ecore_con: correct a typo wrongly calling super destructor instead of super invalidate.
...
Differential Revision: https://phab.enlightenment.org/D6081
2018-05-24 16:02:18 -07:00
Cedric BAIL
7ca25cae0f
ecore: correct lifecycle of object used by Ecore_Con legacy.
...
Differential Revision: https://phab.enlightenment.org/D6080
2018-05-24 16:02:18 -07:00
Cedric BAIL
56fb2cf377
eo: improve error message by pointing to the class that is creating trouble.
...
Differential Revision: https://phab.enlightenment.org/D6079
2018-05-24 16:02:18 -07:00
Cedric BAIL
bb66aa37ca
eo: preventing infinite loop by safely iterating over children during destructor.
...
Differential Revision: https://phab.enlightenment.org/D6078
2018-05-24 16:02:18 -07:00
Cedric BAIL
93893def9f
ecore: properly handle shutdown of Efl.Loop children by using invalidate.
...
Differential Revision: https://phab.enlightenment.org/D6077
2018-05-24 16:02:18 -07:00
Cedric BAIL
23281bc54a
ecore: disable signal during shutdown.
...
Differential Revision: https://phab.enlightenment.org/D6076
2018-05-24 16:02:18 -07:00
Cedric BAIL
2160fe0d4d
eo: invalidate at the end of efl_invalidate only and prevent infinite recursion with an invalidating phase.
...
Differential Revision: https://phab.enlightenment.org/D6075
2018-05-24 16:02:18 -07:00
Cedric BAIL
266dabc096
ecore: force close during invalidate of Efl.Io.Buffered_Stream.
...
Differential Revision: https://phab.enlightenment.org/D6074
2018-05-24 16:02:18 -07:00
Cedric BAIL
0ac6e47697
elementary: use invalidate instead of overriding del for widget items.
...
Differential Revision: https://phab.enlightenment.org/D6073
2018-05-24 16:02:18 -07:00
Cedric BAIL
95f8bf2ebd
elementary: rely on inheritance instead of faking efl_del behavior.
...
Differential Revision: https://phab.enlightenment.org/D6072
2018-05-24 16:02:18 -07:00
Cedric BAIL
b265c5c887
elementary: make del_pre not return a bool and force rely on Eo ref counting.
...
Differential Revision: https://phab.enlightenment.org/D6071
2018-05-24 16:02:18 -07:00
Cedric BAIL
a669fb820a
elementary: prevent death of list item using Eo ref counting.
...
Differential Revision: https://phab.enlightenment.org/D6070
2018-05-24 16:02:18 -07:00
Cedric BAIL
ad009667b5
elementary: remove now useless walking in item.
...
Differential Revision: https://phab.enlightenment.org/D6069
2018-05-24 16:02:18 -07:00
Cedric BAIL
4b30a7df8e
elementary: use Eo ref counting to prevent death of genlist items.
...
Differential Revision: https://phab.enlightenment.org/D6068
2018-05-24 16:02:18 -07:00
Cedric BAIL
2a51465593
elementary: use Eo ref counting to prevent death of gengrid items.
...
Differential Revision: https://phab.enlightenment.org/D6067
2018-05-24 16:02:18 -07:00
Mike Blumenkrantz
6932f0fdd6
elm_list: prevent list item operations during item deletion
...
ref T6880
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6066
2018-05-24 16:02:17 -07:00
Mike Blumenkrantz
499beb9162
elm_list: fix crash in item deletion
...
this is still broken
ref T6881
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6065
2018-05-24 16:02:17 -07:00
Cedric BAIL
ccb5642eb9
Revert "efl_add_ref - fis to use efl_add properly with a parent."
...
This reverts commit 2fb5cc3ad0
.
Most of this change where wrong as they didn't affect the destruction
of the object. efl_add_ref allow for manual handling of the lifecycle
of the object and make sure it is still alive during destructor. efl_add
will not allow you to access an object after invalidate also efl.parent.get
will always return NULL once the object is invalidated.
Differential Revision: https://phab.enlightenment.org/D6062
2018-05-24 16:02:17 -07:00
Cedric Bail
36f8a70041
eo: to avoid mistake in timing, efl_invalidate should always be triggered before any destructor code.
...
Differential Revision: https://phab.enlightenment.org/D6061
2018-05-24 16:02:17 -07:00
Marcel Hollerbach
0090384ef5
elm_ctxpopup: prevent a giant load of errors
...
Summary:
i) There have been 2 sorts of errors, first the items have been deleted
after the list was deleted, thus the list items have already been
destructed. which lead to the error as the popup items destroyed the list
items on destruction as well.
ii) sd->box was attached to the ctxpopup when getting into group_del the
box has already been destroyed by the cleanup logic.
Subscribers: cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6166
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-24 16:02:17 -07:00
WooHyun Jung
ea1760380e
elm_main: call _elm_config_shutdown() after loop_iterate()
...
In _elm_config_shutdown(), _elm_config is freed.
So, if some ecore events call efl_ui_xxx API which refers _elm_config,
there can be crashes.
@fix
2018-05-24 15:30:29 +09:00
Cedric BAIL
9dce56687b
eina: path get actually allocate memory and can't be pure.
2018-05-23 21:33:04 -07:00
Marcel Hollerbach
d5fd76c190
efl_ui_focus_composition: track the deletion state of child objects
...
Reviewers: cedric, zmike
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6186
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-23 21:16:01 -07:00
Lauro Moura
54f1e56b34
efl_mono: Generate support for accessors in .eos
...
Summary: Depends on D6190
Reviewers: felipealmeida, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6191
2018-05-23 18:59:26 -03:00
Lauro Moura
cfafd01bbe
efl_mono: Initial support for Accessors.
...
Summary:
Plain conversion to IEnumerable, which is the base of LINQ
Depends on D6189
Reviewers: felipealmeida, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6190
2018-05-23 18:59:26 -03:00
Lauro Moura
2bbaada66e
efl_mono: Reject the promise when it's disposed.
...
Summary:
As futures are tied to a given promises and are usually handled in
a 'attach and forget' scheme, we can't cancel them as it would cancel
the whole chain.
Reviewers: felipealmeida, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6189
2018-05-23 18:59:26 -03:00
Mike Blumenkrantz
b7530726c8
ecore-evas-buffer: defer resize callback until pre-render
...
Summary:
this mimics other engines, all of which have the same mechanics due
to display server interactions. it also avoids unnecessary recalcs before
pre-render if the canvas size was changing repeatedly
fix T6924
ref D6019
Reviewers: cedric, JackDanielZ
Reviewed By: JackDanielZ
Subscribers: #committers, JackDanielZ
Tags: #efl
Maniphest Tasks: T6924
Differential Revision: https://phab.enlightenment.org/D6145
2018-05-23 17:35:18 -04:00
Lauro Moura
c4572d3f79
efl_mono: Fix events after Event_Description rename.
2018-05-23 17:33:47 +02:00
Xavi Artigas
e5ef9057b5
efl: rename Efl.Ui.Zoom.Mode -> Efl.Ui.Zoom_Mode
2018-05-23 17:33:47 +02:00
Xavi Artigas
61b409015e
efl: rename Efl.Ui.Widget.Orientation_Mode -> Efl.Ui.Widget_Orientation_Mode
2018-05-23 17:33:47 +02:00
Xavi Artigas
e31b3213ec
efl: rename Efl.Ui.Text.Change_Info -> Efl.Ui.Text_Change_Info
2018-05-23 17:33:47 +02:00
Xavi Artigas
4ab7e3fda0
efl: rename Efl.Ui.Tab_Page.* -> Efl.Ui.Tab_Page_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
a7d29f7185
efl: rename Efl.Ui.Stack.Event_* -> Efl.Ui.Stack_Event_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
ee27519432
efl: rename Efl.Ui.Slider.Indicator_Visible_Mode -> Efl.Ui.Slider_Indicator_Visible_Mode
2018-05-23 17:33:47 +02:00
Xavi Artigas
a0d4d3b140
efl: rename Efl.Ui.Pager.Loop -> Efl.Ui.Pager_Loop
2018-05-23 17:33:47 +02:00
Xavi Artigas
1e8b7cc405
efl: rename Efl.Ui.Focus.Composition.Adapter -> Efl.Ui.Focus.Composition_Adapter
2018-05-23 17:33:47 +02:00
Xavi Artigas
cd349762c6
efl: rename Efl.Ui.Drag.Dir -> Efl.Ui.Drag_Dir
2018-05-23 17:33:47 +02:00
Xavi Artigas
761aaa269d
efl: rename Efl.Ui.*_Legacy.Part -> Efl.Ui.*_Legacy_Part
2018-05-23 17:33:47 +02:00
Xavi Artigas
d808147e6f
efl: rename Efl.Text.Bidirectional_Type -> Efl.Text_Bidirectional_Type
2018-05-23 17:33:47 +02:00
Xavi Artigas
0f47f53f57
efl: rename Efl.Task.* -> Efl.Task_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
0e848ccf2d
efl: rename Efl.Selection.* -> Efl.Selection_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
f78c5f3e6c
efl: rename Efl.Observable.Tuple -> Efl.Observable_Tuple
2018-05-23 17:33:47 +02:00
Xavi Artigas
f477d4ad36
efl: rename Efl.Net.*.* -> Efl.Net.*_*
2018-05-23 17:33:47 +02:00