Carsten Haitzler
1c34083001
lets... use our return value shall we? <- THATS the missing icons bug
...
i was telling you about!
SVN revision: 54776
2010-11-22 09:47:36 +00:00
027c174f9d
Find icons in cache
...
SVN revision: 54616
2010-11-16 21:50:53 +00:00
159b8ddb60
realpath will return empty string when not found
...
SVN revision: 54615
2010-11-16 21:50:38 +00:00
2894e4aedc
if -> ifdef
...
SVN revision: 54614
2010-11-16 21:49:45 +00:00
e2a715ccc9
create cache for fallback icons
...
SVN revision: 54583
2010-11-16 10:32:21 +00:00
e4c39fa555
export depcreated user dir
...
SVN revision: 54581
2010-11-16 10:32:01 +00:00
2849f58ca9
Remove duplicate code, mark strict spec
...
SVN revision: 54579
2010-11-16 08:28:52 +00:00
b83238ae14
Start of icon cache
...
Please test efreet_icon_cache_create and efreet_icon_cache_dump, and
check if it is fast enough on a slow system.
SVN revision: 54575
2010-11-15 21:07:22 +00:00
e8ce2014b0
TODO++
...
SVN revision: 54574
2010-11-15 21:07:05 +00:00
aec56c9e24
share edd between lib and bin
...
SVN revision: 54573
2010-11-15 21:06:52 +00:00
bc9f811710
remove duplicate code, and mark strict spec
...
SVN revision: 54572
2010-11-15 21:04:42 +00:00
7545e54203
Let efreet icon return const
...
We return a pointer to an internal cache, so no need to do strdup. I we
implement a cache, the pointer will be a return from a mmap'ed file, so
no need to do strdup.
A bit late to do an API break, but must be done.
SVN revision: 54372
2010-11-09 20:15:55 +00:00
5cec7beb53
* efreet: little speedup for icon lookup.
...
But really you should not call it as it will call stat for
every path it guess an icon could be in. For example, elementary_test
Toolbar 5 trigger 41132 call to stat on random place on your harddrive.
SVN revision: 54339
2010-11-08 18:09:25 +00:00
0ab16442cf
Always do env check
...
SVN revision: 54231
2010-11-06 16:47:43 +00:00
3ee4664f39
Do realpath on last element too
...
SVN revision: 54227
2010-11-06 14:44:11 +00:00
1a12537dfd
delay deletion of non valid themes
...
We need to delay deletion of non valid themes until all possible search
dirs are scanned. In Ubuntu 10.10 XDG_DATA_DIRS lists /usr/local/share
before /usr/share, so when searching for hicolor /usr/local/share is
dropped as a valid dir although it exists as it does not contain an
index.theme file.
SVN revision: 53882
2010-10-25 20:20:41 +00:00
736dbfed46
store OnlyShowIn and NotShowIn in struct
...
SVN revision: 53691
2010-10-20 20:39:54 +00:00
423892f7cd
use EINA_LIST_FREE for list deletion
...
SVN revision: 53690
2010-10-20 20:39:38 +00:00
b2ecad6a06
simplify list deletion
...
use eina_list_free instead of removing one and one element
SVN revision: 53689
2010-10-20 20:39:19 +00:00
bc2c59746d
log domains in lower-case only please.
...
let's make it a standard so we don't have to look at the code
everytime to figure out the name...
SVN revision: 53171
2010-10-07 22:22:33 +00:00
ed263df47e
ecore time is double
...
SVN revision: 52855
2010-09-28 17:53:15 +00:00
eb7c111fc9
Fix typo.
...
SVN revision: 52783
2010-09-26 16:30:14 +00:00
67771ee617
Fix common misspellings
...
Following misspellings were fixed:
acheive->achieve
appart->apart
isnt->isn't
succesfully->successfully
taht->that
SVN revision: 51987
2010-09-08 11:27:59 +00:00
f3a591b253
Always munmap mmap'ed data
...
SVN revision: 51713
2010-08-29 08:47:37 +00:00
96daa6c974
clean whitespace
...
SVN revision: 51712
2010-08-29 08:47:27 +00:00
cf907d127a
clean whitespace
...
SVN revision: 51711
2010-08-29 08:47:16 +00:00
Carsten Haitzler
dae2c23caf
possible leak--
...
SVN revision: 51703
2010-08-28 15:11:20 +00:00
5a8a8c9014
Convert (hopefully) all comparisons to NULL
...
Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
2010-08-21 13:52:25 +00:00
ba22eb6af8
* efreet: less warning by Albin Tonnerre.
...
SVN revision: 51247
2010-08-17 12:03:10 +00:00
Carsten Haitzler
ff9e16874e
efreet 1.0.0 alpha... MUHAHAHHAHAHAHAH!
...
SVN revision: 51180
2010-08-16 09:34:38 +00:00
2dc15f4d89
formatting
...
SVN revision: 51137
2010-08-15 19:54:19 +00:00
b001a8968e
Fix theme passed to efreet_icon_cache_add
...
Just pass NULL, no need for NULL theme
SVN revision: 51136
2010-08-15 19:54:08 +00:00
607e5d4b9b
From: Joerg Sonnenberger <joerg@britannica.bec.de>
...
Subject: [E-devel] [PATCH] efreet and icon loading
Hi all,
attached patch fixes two issues:
(1) If using a non-default prefix, share/pixmaps should be checked
before the hard-coded /usr/share/pixmaps fallback. This basically
restores symmetry with the other cases like share/icons.
(2) Do a fallback lookup if the theme is not valid or faked. This can
happen if only hicolor is installed and e17 decides to use Tango.
Before, e.g. gimp's icon wasn't picked up because the short cut was too
early.
SVN revision: 51124
2010-08-15 03:01:55 +00:00
Carsten Haitzler
1325b20a81
sloppy ecore_job handle! fix!
...
SVN revision: 51107
2010-08-14 04:02:31 +00:00
8a1a12333f
* eet: fix API break.
...
SVN revision: 51084
2010-08-13 15:53:59 +00:00
a6645cb746
* eina: fix eina array threadsafe version.
...
Also add iterator and accessor ability to walk threadsafely.
Rename EINA_EACH to EINA_EACH_CB to match other callback cast.
SVN revision: 51000
2010-08-11 14:32:30 +00:00
5efed73f07
* efreet: fix some potential source of segv.
...
SVN revision: 50942
2010-08-09 19:31:18 +00:00
03f82b7d73
Fix clearing of theme cache
...
SVN revision: 50825
2010-08-04 21:01:09 +00:00
9edfb9d456
Check NULL return
...
SVN revision: 50822
2010-08-04 19:15:53 +00:00
80c2d94afd
Check NULL return
...
SVN revision: 50821
2010-08-04 19:15:38 +00:00
a737a1d044
Check for NULL return
...
SVN revision: 50818
2010-08-04 18:21:30 +00:00
7b5e166c85
Check NULL return
...
SVN revision: 50817
2010-08-04 18:21:20 +00:00
0a4617ae38
FORMATTING
...
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
2010-08-04 16:57:32 +00:00
7bf67b046b
key and value aren't const
...
SVN revision: 50809
2010-08-04 12:33:58 +00:00
0a3f53c3b1
Check for null return
...
SVN revision: 50808
2010-08-04 12:33:48 +00:00
2ccf1a156d
Remove fake_null try 2
...
SVN revision: 50807
2010-08-04 12:23:00 +00:00
Carsten Haitzler
1837b63b38
ummmm revert. crash crash crash.
...
SVN revision: 50789
2010-08-03 21:32:45 +00:00
eba0c34bf9
Remove unneeded fake_null theme
...
SVN revision: 50788
2010-08-03 20:46:56 +00:00
c623230e98
Remove unneeded eina_hash_del
...
We already checked that this value isn't in the hash.
SVN revision: 50787
2010-08-03 20:46:46 +00:00
b197b55abc
Check return NULL
...
SVN revision: 50786
2010-08-03 20:46:36 +00:00
beacf6f976
use EINA_LIST_FREE
...
SVN revision: 50785
2010-08-03 20:46:25 +00:00
08e9824c6e
check return value from NEW
...
SVN revision: 50784
2010-08-03 19:31:44 +00:00
99673bb0a8
fix malloc calls
...
check return value and remove unneeded sizeof(char)
SVN revision: 50783
2010-08-03 19:31:34 +00:00
1576311af3
alloc the right amount of mem
...
sizeof(char) is 1, and sizeof(char *) is wrong for strings
SVN revision: 50782
2010-08-03 19:31:24 +00:00
69d0626265
use alloca for in function mem
...
SVN revision: 50781
2010-08-03 19:31:14 +00:00
7f93656d7b
check return value from malloc
...
SVN revision: 50780
2010-08-03 19:31:04 +00:00
8554a0c23b
free data on realloc error
...
SVN revision: 50779
2010-08-03 19:30:53 +00:00
465a55b467
Leak-- using the macro
...
SVN revision: 50763
2010-08-03 11:44:55 +00:00
4b221c3936
Check return value for realloc
...
SVN revision: 50753
2010-08-02 20:43:09 +00:00
31c6799a7e
goto not needed anymore with alloca
...
SVN revision: 50496
2010-07-25 20:38:28 +00:00
78f80647ea
use eina hash set
...
SVN revision: 50494
2010-07-25 20:28:21 +00:00
230461d56b
free data on error
...
SVN revision: 50493
2010-07-25 20:25:51 +00:00
b76d9490dc
Fix errors reported by clang
...
SVN revision: 50492
2010-07-25 20:25:40 +00:00
2a84379ba9
Remove unneeded code with notnull.cocci script
...
The notnull.cocci script from Coccinelle finds places where you check if a
variable is NULL, but it's known not to be NULL. The check can be safely
removed. For example, this code would be caught by notnull:
if (!var) return;
if (var && var->fld) { ... }
It's needless to check again if var is not NULL because if it's in fact NULL,
it would have returned on the previous "if". This commit removes all the
trivial places where this pattern happens. Another patch will be generated for
the more complex cases.
SVN revision: 50241
2010-07-14 02:05:47 +00:00
4f972b800b
Move Efreet (and associated headers) to own dir.
...
SVN revision: 50143
2010-07-09 06:28:29 +00:00
bcb8744bc0
formatting
...
SVN revision: 49840
2010-06-25 01:44:30 +00:00
51c6fc3785
formatting
...
SVN revision: 49839
2010-06-25 01:38:50 +00:00
55524b4e87
* efreet: remove warning due to change in Ecore API.
...
SVN revision: 49831
2010-06-24 16:17:45 +00:00
a392e677a7
flock -> fcntl
...
SVN revision: 49650
2010-06-11 21:48:33 +00:00
Vincent Torri
5a8135174a
missing headers
...
SVN revision: 49545
2010-06-06 19:45:16 +00:00
Carsten Haitzler
0d773a63a0
version for efreet
...
SVN revision: 49282
2010-05-29 08:30:06 +00:00
cf894cab2e
fix double free
...
eina_hash_del calls free callback, so we don't need to free the data
ourselves.
SVN revision: 49247
2010-05-28 09:25:16 +00:00
d4eb19a520
efreet: formatting
...
SVN revision: 48946
2010-05-17 19:45:20 +00:00
61df60e3bb
get min/max size only for scalable icons
...
SVN revision: 48924
2010-05-16 21:11:21 +00:00
3ac99ef29b
fix ret_size used unitialized
...
Threshold is fallback for type
calc min/max dir size for threshold only once
SVN revision: 48923
2010-05-16 21:02:52 +00:00
f7b9de9595
efreet: formatting
...
SVN revision: 48921
2010-05-16 19:36:42 +00:00
fc031b899d
efreet: better variable naming
...
SVN revision: 48920
2010-05-16 18:42:43 +00:00
f827867a22
efreet: prefer downsizing
...
SVN revision: 48919
2010-05-16 18:42:33 +00:00
31fa5a1e1d
efreet: use exponential scale for icon size search
...
fd.o spec wants us to use linear distance for icon size search. But
f.ex. when searching for a 128px icon, and the available is 48px and
256px, 256px would be preferable as 256/128 is 2 and 128/48 is 2.67
SVN revision: 48918
2010-05-16 18:41:56 +00:00
Carsten Haitzler
8bbc3b9024
gaaaaah! fix buf - paths were "wrong" - thus matching failed. man i see some
...
expensive ops going on with lots of strcmping.
SVN revision: 48917
2010-05-16 17:11:38 +00:00
8cde10890b
efreet: Don't remove/add stuff already in list
...
eina_list_promote_list to prepend data already in list.
SVN revision: 48898
2010-05-15 18:38:50 +00:00
af2471c7bc
remove svg from default types.
...
make efreet_icon_extensions prepended a type when it already is in list
SVN revision: 48895
2010-05-15 17:55:41 +00:00
82b89cea6b
add FIXME
...
SVN revision: 48893
2010-05-15 16:57:28 +00:00
85dbd6d844
search for svg icons
...
SVN revision: 48891
2010-05-15 16:24:58 +00:00
db8de25e56
allow trashing of files which are not on home partition
...
SVN revision: 48885
2010-05-15 07:51:49 +00:00
dc91f4ebbf
efreet: make sure we flush new dirs
...
SVN revision: 48812
2010-05-13 18:31:41 +00:00
1a49327928
make all strings returned by efre_mime_type_get stringshared
...
SVN revision: 48641
2010-05-05 20:55:14 +00:00
5be72adc7d
efreet: TODO++
...
SVN revision: 48429
2010-04-29 18:16:15 +00:00
b5caf6ce1b
efreet: fix #534
...
SVN revision: 48110
2010-04-18 20:04:09 +00:00
1dde324c33
[E-devel] [PATCH] Efreet: move efreet_desktop_cache_create out of
...
the path
This binary is just an internal helper, and isn't expected to be run by
anything but efreet. Therefore, let's emphasize this and keep it out of
the path by installing it in PACKAGE_LIB_DIR/efreet/
Signed-off-by: Albin Tonnerre <lutin@debian.org>
By: Albin Tonnerre <albin.tonnerre@gmail.com>
SVN revision: 48085
2010-04-17 20:19:35 +00:00
a384141abc
efreet: Check return value from opendir
...
SVN revision: 48081
2010-04-17 18:39:13 +00:00
Carsten Haitzler
ca87bc3349
how about if opendir fails... we dont try and walk the dir? :)
...
SVN revision: 48047
2010-04-16 02:20:56 +00:00
3d71b07fc7
TODO--
...
SVN revision: 48040
2010-04-15 19:43:02 +00:00
9460f8ed3e
efreet: use convenience func
...
One func to add monitor, func checks for duplicate monitor and uses
realpath
SVN revision: 48038
2010-04-15 19:38:01 +00:00
80e3b951fa
efreet: listen for changes recursivly
...
SVN revision: 48036
2010-04-15 19:21:23 +00:00
1488a1889d
efreet: better naming
...
SVN revision: 48035
2010-04-15 19:21:13 +00:00
37e39a6834
efreet: better naming
...
SVN revision: 48034
2010-04-15 19:21:03 +00:00
2df0141340
efreet: better naming
...
SVN revision: 48033
2010-04-15 19:20:51 +00:00
1560298337
efreet: better naming
...
SVN revision: 48032
2010-04-15 19:20:41 +00:00
1446a1a819
efreet: reorganize
...
SVN revision: 48031
2010-04-15 19:20:31 +00:00
Carsten Haitzler
Sebastian Dransfeld
Cedric BAIL
Gustavo Sverzut Barbieri
Christopher Michael
Lucas De Marchi
Joerg Sonnenberger
Massimiliano Calamelli
Vincent Torri
Hannes Janetzek
Albin Tonnerre