Shilpa Singh
6027ce9bad
Elm_Spinner: UI Concept change fix.
...
Older UI concept: when text in spinner's entry is inputted and text is
not committed yet and when inc/dec is clicked. do not commit text and
reset the value to older original value.
New UI concept:
When Text in spinner's entry is inputted and text is not committed yet
and when inc/dec buttons are clicked.
Commit the entry's text and inc/dec accordingly.
If entry' s text is already modified owing to min/max update, then do not inc/dec.
Signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
2013-11-02 20:33:00 +09:00
Daniel Juyung Seo
d22076681b
elm: Fixed formatting about smart_event check for code consistency.
...
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Christophe Sadoine
fbe18f2eab
spinner: added signals "spinner,drag,start" and "spinner,drag,stop"
...
Reviewers: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D271
2013-10-23 23:03:50 +09:00
Daniel Juyung Seo
c8a7eded6b
elm_spinner.c: call _value_set after resetting spin timer.
...
There is a chance that spin timer is deleted in _value_set() by any chance.
So reset the spin timer and call _value_set after that.
Special thanks to Shilpa.
2013-10-07 23:38:30 +09:00
Daniel Juyung Seo
f23e09d451
elm_spinner.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro.
2013-10-05 17:15:53 +09:00
Cedric Bail
29af5e1e43
elementary: update to new eo_parent_get/set API.
2013-09-25 13:34:27 +09:00
Daniel Juyung Seo
4c24d2bf72
elm_spinner: refactoring internal codes.
...
1. use more ELM_SAFE_FREE macro.
2. use more descriptive names for internal timer variables.
2013-09-24 23:57:19 +09:00
Daniel Juyung Seo
244eb99691
elm_spinner.c: consider style name starting with "vertical" is a vertical spinner.
...
I think it's better to introduce elm_spinner_vertical_set() API to explicitly show the vertical mode but I will keep this new code for the backward compatibility.
2013-09-16 02:51:42 +09:00
Daniel Juyung Seo
1a3660fd8e
elm_spinner.c: fixed spinner arrow key bug.
...
Consider the spinner direction for the arrow key events.
2013-09-14 02:55:00 +09:00
Shinwoo Kim
329a5ef3fc
[spinner] change part name to access.text from access_text for naming consistency
2013-09-07 11:56:11 +09:00
ChunEon Park
d461a8be05
elementary/widgets - set parents before widget constructs their body.
...
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
WooHyun Jung
24896e2ffd
elementary/elm_spinner.c : Whenever spinner is unfocused, timers related with value change should be deleted.
2013-08-06 18:13:10 +09:00
Carsten Haitzler
59e8bc5a35
Fix elm to use key not keyname (so xmodmap works)
2013-07-31 15:16:41 +09:00
Shinwoo Kim
c47ef1b7fe
[access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information
2013-07-31 12:57:49 +09:00
Daniel Juyung Seo
6cf684f02a
elm: added more "focused" and "unfocused" documentations.
...
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
2013-06-10 14:13:55 +09:00
Daniel Juyung Seo
2f5ef21462
elm_spinner.c: ELM_SAFE_FREE adoption.
...
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 21:07:24 +09:00
Daniel Juyung Seo
5f053bf79a
elm: refactoring. use more ELM_FREE_FUNC.
2013-05-23 15:54:49 +09:00
Cedric Bail
c929b33052
elementary: properly sanitize headers order.
2013-05-03 16:07:06 +09:00
Daniel Zaoui
187d6bf8de
Elementary: replace eo_data_get for objects data referencing.
2013-05-01 11:04:09 +03:00
ChunEon Park
fd772a71eb
elementary/fileselector_button, fileselector_entry, spinner - support language,changed callback.
2013-04-23 21:00:50 +09:00
Daniel Juyung Seo
74b3eed5fd
elm: print the error message inside elm_widget_sub_object_add().
...
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Tom Hacohen
d75cb616da
Change usage of eo_do_super to the new prototype.
2013-03-18 16:15:12 +00:00
Daniel Juyung Seo
78c042cdbe
elm *.c: fixed formatting with EINA_LIST_FREE.
...
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Daniel Juyung Seo
8aef8ee700
elm elm_spinner.c: Removed unnecessary local variable.
...
Removed local variable "offset".
2013-03-03 00:40:07 +09:00
Daniel Juyung Seo
f868609b5d
elm elm_spinner.c/h: Use proper variable name. Add more comments.
...
1. drag_start_pos -> drag_start_val. This is a value not a position.
2. added comment for drag_start_val.
2013-03-03 00:38:35 +09:00
Daniel Juyung Seo
e8d6527eda
elm elm_spinner.c: Use more eo APIs.
...
edje_object_part_drag_value_get() -> eo_do(edje_obj_part_drag_value_get);
2013-03-02 23:37:51 +09:00
Gustavo Lima Chaves
312d0217a0
An internal layout error, on a widget set, is a CRITICAL error.
2013-03-01 23:04:31 -03:00
Rafael Antognolli
906fc3252f
spinner: Fix initial value of the spinner.
...
The size should remain the same after the first mouse move and then be
adjusted accordingly.
Fixes #1403 .
Patch by: "Brian J. Lovin" <brian.j.lovin@intel.com>
2013-03-01 15:24:05 -03:00
Daniel Zaoui
cdd1eea853
Replace supported_types
...
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 83803
2013-02-10 07:52:31 +00:00
Daniel Juyung Seo
ffa9c1e793
elm: Refactoring.
...
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
2013-01-04 19:10:19 +00:00
Shinwoo Kim
88dac18cf7
[access] export elm_access_activate_cb_set(); and add related documentation.
...
SVN revision: 82052
2013-01-03 09:31:33 +00:00
Shinwoo Kim
f10fb3e115
[access] export some APIs,and remove unnecessary lines.
...
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
2012-12-23 14:50:56 +00:00
Shinwoo Kim
897584dfb8
[spinner] enhance access feature
...
1. unregister access object from edje part object.
2. add access acitviate callback to increase, decrease.
3. remove unnecessary variables from elm_widget_spinner.h
SVN revision: 79694
2012-11-26 10:59:00 +00:00
Daniel Zaoui
0c915e9023
Cleaning: removed include Eo.h in widgets because it was indirectly included by Elementary.h
...
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 79682
2012-11-26 09:29:01 +00:00
Yakov Goldberg
5c98343198
We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
...
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 79668
2012-11-26 06:32:53 +00:00
Daniel Juyung Seo
adc7416fcb
elm access: Rename access hook name according to elm refactoring.
...
SVN revision: 78993
2012-11-08 08:33:26 +00:00
Jihoon Kim
d19a9669c3
remove trailing spaces and fix coding style
...
SVN revision: 77838
2012-10-11 00:35:00 +00:00
Michael BOUCHAUD
994441181c
elementary: don't try to find one more time the node we want to remove. We already have it !
...
SVN revision: 77630
2012-10-09 08:49:06 +00:00
Bruno Dilly
e0d1bab54a
elementary: add special value del / get funcs to spinner
...
SVN revision: 77590
2012-10-08 22:39:15 +00:00
Bruno Dilly
93295e2657
elementary: replace previously special value set
...
When adding a special value, check if there is already a label for
the value. If it's the case, just replace the label.
SVN revision: 77589
2012-10-08 22:39:05 +00:00
Bruno Dilly
34dbd67c31
elementary: fix spinner wrap
...
It's weird, but looks like wrap mode of the spinner is broken at least
since the move of elm to trunk.
The current code:
if (sd->wrap)
{
while (new_val < sd->val_min)
new_val = sd->val_max + new_val + 1 - sd->val_min;
while (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max - 1;
}
doesn't seems correct. Since even the documented example would fails:
* E.g.:
* @li min value = 10
* @li max value = 50
* @li step value = 20
* @li displayed value = 20
*
* When the user decrement value (using left or bottom arrow), it will
* displays @c 40, because max - (min - (displayed - step)) is
* @c 50 - (@c 10 - (@c 20 - @c 20)) = @c 40.
With the current code the value will be 41.
It also could lead to values above min, like happens on the first spinner test,
when you could go to -50.5 because new value will become:
250 + (-50.5) + 1 - (-50) in the first while() and later since these value
is bigger then 250, would go back to -50.5 ...
So, a reasonable algorithm would be
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max + new_val - sd->val_min;
else if (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max;
}
But it doesn't works fine for cases like the months spinners test, when you
have min = 1, max = 12, step = 1 and each option should be displayed with
wrap. This algorithm would wraps from 1 to 11, so would skip December...
So, I think just going to the max value when min is reached is the better
choice.
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max;
else if (new_val > sd->val_max)
new_val = sd->val_min;
}
SVN revision: 77278
2012-10-01 20:44:19 +00:00
Daniel Juyung Seo
30dba54610
elm: Fixed indentations for EINA_LIST/INLIST_FOREACH(_SAFE).
...
SVN revision: 77244
2012-10-01 07:36:27 +00:00
Kim Shinwoo
ff071585ac
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
...
Subject: [E-devel] [patch][elementary] segment_control, spinner -
accessibility feature
the attached patch provides accessibility features for segment_control
and spinner.
SVN revision: 75497
2012-08-21 10:08:56 +00:00
Gustavo Lima Chaves
b4997b0ff1
[elm] Fix entry apply on unfocus for spinner.
...
SVN revision: 74988
2012-08-07 18:49:39 +00:00
Gustavo Lima Chaves
233c68142e
[elm] Handle focus out on spinner the right way.
...
SVN revision: 74854
2012-08-03 16:43:26 +00:00
Cedric BAIL
eefbaaba3d
elementary: on focus loss actually hide the entry and show label.
...
SVN revision: 74819
2012-08-03 07:27:02 +00:00
Gustavo Lima Chaves
42dbe61643
[elm] Spinner now inheritable.
...
SVN revision: 74759
2012-08-01 21:03:58 +00:00
Cedric BAIL
74ecff49ec
elementary: round up the spinning speed when the step is too small with a warning message.
...
Patch by Jean-Philippe André <jpeg@videolan.org>
SVN revision: 74528
2012-07-28 13:29:50 +00:00
Gustavo Lima Chaves
584c53c1be
[elm] New elm_widget_add() usage spread.
...
SVN revision: 74148
2012-07-18 21:03:39 +00:00
Gustavo Lima Chaves
48222a539e
[elm] Repeated call now gone.
...
SVN revision: 74020
2012-07-17 18:45:39 +00:00
Gustavo Lima Chaves
d9788a6249
[Elm] Spinner now a layout.
...
SVN revision: 71087
2012-05-14 21:52:06 +00:00
Carsten Haitzler
3a7b769a63
use the new escape text set to clear up issues if theme has TEXT vs
...
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.
SVN revision: 70362
2012-04-20 12:51:10 +00:00
Jihoon Kim
7046f87e3a
elementary: ignore key event of keypad when NumLock is turned on in win, scroller, slider, video, photocam, map, slideshow, and spinner.
...
SVN revision: 69952
2012-04-06 10:34:03 +00:00
Daniel Juyung Seo
7908a77ad8
elm: Fixed formatting.
...
SVN revision: 69700
2012-03-28 09:02:22 +00:00
Carsten Haitzler
0a60e3a9cc
warn--
...
SVN revision: 68892
2012-03-07 08:13:06 +00:00
Carsten Haitzler
b6fd8c353e
add rouding+base to spinner - otherwise u can never slow it down and u
...
cant round to specific values. fixed month test to do this too.
SVN revision: 67982
2012-02-15 12:32:02 +00:00
Carsten Haitzler
f6a3fc40e1
stop using deprecated calls.
...
SVN revision: 66681
2011-12-30 10:02:19 +00:00
Bruno Dilly
569b78f243
Elementary: Spinner documentation
...
SVN revision: 61766
2011-07-26 17:27:05 +00:00
ChunEon Park
9420b44918
elementary/segment_control, panes, photocam, photo, win, toolbar, thumb, slideshow, spinner - updated signal callbacks.
...
made them use signal callbacks description table.
removed never-called signals
updated doxygen.
SVN revision: 58816
2011-04-22 00:42:32 +00:00
ChunEon Park
902a467b7e
Elementary / genlist, slider, radio, win toolbar, thumb, toggle, scroller, slideshow, spinner
...
updated signall callback list in each doxygen
SVN revision: 58342
2011-04-05 02:04:28 +00:00
Daniel Juyung Seo
8a108db5ab
Elementary: Use pre-defined type Edje_Signal_Cb instead of describing all of its parameters.
...
SVN revision: 58283
2011-04-03 05:32:17 +00:00
ChunEon Park
711b428aae
elementary / slider, radio, separator, photocam, photo, store, scroller, slideshow, spinner, progressbar - removed white spacesw
...
SVN revision: 58250
2011-04-01 11:24:15 +00:00
Carsten Haitzler
f74c18a02e
make all widgets use a standard setup macro. cuts code down and
...
handles null parent errors, null wd alloc, null obj create errors etc.
SVN revision: 58242
2011-04-01 06:08:02 +00:00
Tom Hacohen
c04d8990f0
Elementary: Added on-the-fly UI-mirroing support to all of the widgets
...
SVN revision: 56846
2011-02-09 16:14:02 +00:00
Tom Hacohen
99da5b6541
Elementary: Added ui-mirroring support for all the widgets.
...
SVN revision: 56803
2011-02-08 12:08:28 +00:00
3v1n0
ff67ce31fb
Always check for valid evas object.
...
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
2010-12-12 19:12:43 +00:00
helen
030b697366
EINA_SAFETY_ON_NULL_RETURN
...
Checking parameters with EINA_SAFETY_ON_NULL_RETURN and
EINA_SAFETY_ON_NULL_RETURN_VAL in Elementary
SVN revision: 55188
2010-12-03 14:08:33 +00:00
Iván Briano
ea3dda3527
And let's not expose internal objects when setting signal callbacks on widgets.
...
SVN revision: 54004
2010-10-29 18:21:58 +00:00
Carsten Haitzler
4f3090af01
and handle disables for everything else that has disable hooks.
...
SVN revision: 53138
2010-10-07 07:44:50 +00:00
Tiago Rezende Campos Falcao
59e7d34f2c
slider, slideshow and spinner with keyboard arrows
...
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
elm_slider now respond to the keyborad arrows depends on its position.
If it is in a horizontal mode, than its value will change by pressing
left and right, other wise it will respond by pressing up and down
elm_slideshow: go to next and previous with keyboard arrows
elm_spinner: respond to left and right keys in an animated way
SVN revision: 52816
2010-09-27 21:13:41 +00:00
Tiago Rezende Campos Falcao
68c1638c16
Focus suport for some widgets
...
Widgets:
* check
* radio
* slider
* toggle
* spinner
* slideshow
Author: Thiago Ribeiro Masaki <masaki@profusion.mobi>
SVN revision: 52599
2010-09-22 17:45:46 +00:00
Lucas De Marchi
3e8419285d
Fix common misspellings
...
Following misspellings were fixed:
accomodate->accommodate
alwyas->always
backgorund->background
beween->between
dependant->dependent
desireable->desirable
doesnt->doesn't
emmitted->emitted
imediately->immediately
ocurred->occurred
sucess->success
ther->the
tranformed->transformed
usefull->useful
SVN revision: 52009
2010-09-09 00:35:43 +00:00
Bruno Dilly
7808d77502
Add setters and getters to interval for elm spinner and clock
...
SVN revision: 50392
2010-07-20 21:38:17 +00:00
Bruno Dilly
d350f3a293
Change elm functions elm_object_signal_listen to elm_object_signal_callback_add
...
and elm_object_signal_unlisten to elm_object_signal_callback_del
SVN revision: 49926
2010-06-28 15:32:20 +00:00
Bruno Dilly
6f093b37f5
Set hooks for elm object signal listen and unlisten for elm spinner
...
SVN revision: 49870
2010-06-25 22:40:42 +00:00
Cedric BAIL
bdf6efa129
* elementary: fix Ecore API changes.
...
SVN revision: 49860
2010-06-25 09:58:14 +00:00
Bruno Dilly
84d84ac0dd
Fix max value wrapping calculation of elm spinner.
...
By: Rafael Fonseca <rfonseca@profusion.mobi>
SVN revision: 49683
2010-06-15 15:55:22 +00:00
Bruno Dilly
db550353a8
Add elm_object_signal_emit
...
This function sends a signal to the edje object of the obj.
It's a general function, and every widget should set a hook for this.
I'm setting a hook only for the spinner now, but soon I will work on other widgets.
SVN revision: 49681
2010-06-15 14:11:13 +00:00
Bruno Dilly
8932085312
Del spin timer on elm_spinner del_hook
...
SVN revision: 49549
2010-06-06 22:09:48 +00:00
Fabiano Fidêncio
7746e8b514
From: Fabiano Fidêncio <fidencio@profusion.mobi>
...
Changing return of Eina_Bool functions that were not EINA_TRUE or
EINA_FALSE in Edje.
In Elementary too ...
SVN revision: 49470
2010-06-05 13:12:45 +00:00
Carsten Haitzler
d888b71dba
theme -> can specify a new theme for an object andit gets inherited. need to
...
add tests.
SVN revision: 48771
2010-05-12 01:03:46 +00:00
Iván Briano
91b4652e87
Signal de edje on focus changes. Can be used to show/hide the spinner buttons based on it.
...
SVN revision: 48585
2010-05-03 18:29:02 +00:00
Gustavo Sverzut Barbieri
8a23d2a6b7
Add special values to spinner.
...
Special value is a string showed instead a numerical one.
By: Rafael Fonseca <rfonseca@profusion.mobi>
SVN revision: 48090
2010-04-18 00:31:07 +00:00
Tiago Rezende Campos Falcao
c00911ee84
Added get functions in elm spinner and added elm spinner in edje externals.By Fidencio
...
Author: Fabiano Fidêncio <fidencio at profusion.mobi>
SVN revision: 47646
2010-04-01 14:22:32 +00:00
Gustavo Sverzut Barbieri
06d14ed245
const and -Wextra, come on guys! :-/
...
SVN revision: 47409
2010-03-24 03:06:00 +00:00
Gustavo Sverzut Barbieri
e01d72fe26
Use eina_stringshare_replace to avoid crashes.
...
By: Rafael Fonseca <rfonseca@profusion.mobi>
SVN revision: 47187
2010-03-13 21:01:26 +00:00
Vincent Torri
b07e49d435
remove unused parameter in the library.
...
I won't do this everyday, and i won't touch the tests.
SVN revision: 47093
2010-03-09 17:51:30 +00:00
Carsten Haitzler
6e5836950a
warning-- more
...
SVN revision: 47078
2010-03-09 14:42:41 +00:00
Carsten Haitzler
91e01aa86e
patch from discomfitor <- check type of widget on api call and return if not
...
the right type
SVN revision: 47073
2010-03-09 06:15:39 +00:00
Iván Briano
8bebfdc02b
Trigger "changed" callback when value is changed with the entry, fix typo and focus entry when it's shown.
...
SVN revision: 45823
2010-02-02 22:10:56 +00:00
Gustavo Sverzut Barbieri
4b886debcf
spinner uses format specified by user in its entry-form.
...
Tries to use the same format as specified by user with
elm_spinner_label_format_set() when allowing entry to type text.
This avoids the ugly "123.00000000" when editing integers, as done in
the color chooser of editje.
SVN revision: 45643
2010-01-27 20:16:43 +00:00
Gustavo Sverzut Barbieri
108da05a3a
spinner: just set the value if conversion to float worked, otherwise ignore it.
...
Instead of using atof() and always getting a value (even if 0 when
invalid), check if conversion to float worked and if not just revert
to last value, ignoring the input.
I'm being quite tolerant here, allowing spaces at end.
SVN revision: 45632
2010-01-27 19:34:45 +00:00
Christopher Michael
6e31924ebe
Formatting.
...
Reduce code size in certain places by not reproducing the same
edje_object_text_set.
SVN revision: 43171
2009-10-20 21:02:37 +00:00
Carsten Haitzler
a4996f90ae
1. remove excess swallows - now edje handles that itself
...
2. beforfe show.. calc first so initial windowis the right size!
SVN revision: 42953
2009-10-08 05:26:58 +00:00
Viktor Kojouharov
3d7c117c61
elm_spinner work:
...
* Arrow keys increment/decrement the value
* Escape and clicking on an arrow resets the value to its original "before-entry" value
SVN revision: 42420
2009-09-11 17:41:29 +00:00
Viktor Kojouharov
48947f3d4d
pressing a spinner button while the entry is visible hides the entry but does not apply its value to the spinner
...
SVN revision: 42257
2009-09-04 18:16:59 +00:00
Viktor Kojouharov
f1b9e5945f
improvements to the button spinning mechanism
...
SVN revision: 42256
2009-09-04 18:10:18 +00:00
Christopher Michael
d367ac8b92
Add traps for null widget data so we don't segfault needlessly.
...
SVN revision: 42253
2009-09-04 17:32:50 +00:00
Viktor Kojouharov
52e04c9c50
default step value
...
SVN revision: 42244
2009-09-04 13:55:57 +00:00
Carsten Haitzler
59fc4b1be8
1. new spinner widget from Viktor Kojouharov <vkojouharov@gmail.com>
...
2. scroller stop fix in paginated mode
3. scroller docs
SVN revision: 42202
2009-09-03 12:36:39 +00:00