Commit Graph

17324 Commits

Author SHA1 Message Date
Daniel Kolesa c4640d6f40 eolian: add API to get full file path of a unit
This is necessary for easy dependency generation, as it is needed
to retrieve a full list of paths that each generated file depends
on.
2018-10-24 12:01:05 +02:00
Hermet Park e6924b9c72 elementary transit: add a convenient API.
Summary:
elm_transit_current_repeat_times_get() returns
current repeating count of transition.

@feature

Reviewers: #committers, devilhorns

Reviewed By: #committers, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7200
2018-10-23 20:43:17 +09:00
Hermet Park 36fc2e6a93 evas image: fix non-rendered preload image.
Summary:
This is one more corner-case issue that I found,
When second image doesn't use preload (but still share the resource)
canvas engine triggers cancellation for first image preload function.

Unluckly, preload thread is cancelled on the intermediate rendering,
First image is not going to rendered, even image turn it changed states.
Because end of that frame, canvas reset/flushed all active objects.

Here changes to retain the changes status to redraw it in the next frame.

Test Plan:
img1 = image_add;
image_file_set(img1, "test.jpg");
image_preload(img1, true);
show(img);

img2 = image_add;
image_file_set(img2, "test.jpg");  //same resource
image_preload(img2, false);
show(img2);

img1 is invisible.

Reviewers: #committers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7157
2018-10-23 14:49:46 +09:00
Yeongjong Lee 7f77938fa8 eina_lock: add empty do-while in macro
Summary:
empty do-while is needed for safe use.
This patch avoid empty body compiler warning.

Problem case:
if (b)
  EINA_MAIN_LOOP_CHECK_RETURN_VAL(NULL);

Reviewers: segfaultxavi, Hermet, ManMower, bu5hm4n

Reviewed By: segfaultxavi, bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7182
2018-10-22 11:34:45 +02:00
Carsten Haitzler 7baac6a556 build - meson - fix linking of gl gneric to link to libm
need maths lib for lots of modules... so link to it.
2018-10-18 22:01:47 +01:00
Marcel Hollerbach 52e0b8440b Revert "meson: add cxx bindings"
This reverts commit 5aaf2cbb5d.

The cxx bindings were accidently merged. Things are missing (like .eot.h
files)
2018-10-18 16:12:13 +02:00
Marcel Hollerbach 5aaf2cbb5d meson: add cxx bindings
this commit adds cxx bindings to meson.

Differential Revision: https://phab.enlightenment.org/D7169
2018-10-18 16:01:07 +02:00
Marcel Hollerbach d9bb7cc12e meson: add missing ELM_EFREET
without this - elementary_config will crash, and elementary will not use
that much of Efreet. We might want to drop this #ifdef at some point.

Differential Revision: https://phab.enlightenment.org/D7176
2018-10-18 15:57:23 +02:00
Marcel Hollerbach c304510ca5 meson: we accidently looked at the wrong elementary config spot
we read and wrote the config into the wrong subdirectory, thus values
did not match - HOWEVER something lead to more problems and trouble, as
some options in elementary_config are not respected anymore.

Differential Revision: https://phab.enlightenment.org/D7175
2018-10-18 14:51:57 +02:00
Marcel Hollerbach 8d4af0bff6 eina_vpath_xdg: fix fallback strings
when more than one fallback string was used the same variable was
accidently used again and again. This fixes that.

Note: This was not discovered because elementary does not use xdg per
default :)

Differential Revision: https://phab.enlightenment.org/D7174
2018-10-18 14:51:57 +02:00
Carsten Haitzler 5e01bbe7bd build - meson - fix ecore-x to detect xcursor to fix rgba cursors 2018-10-18 13:42:10 +01:00
Hosang Kim e9eff6b30e evas_events: Fix wrong condtion.
Summary:
mouse_grabbed should not be less than zero.
But use OR instead of AND in the condition, so sometimes mouse_grabbed is -1.

Reviewers: woohyun, zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7168
2018-10-17 14:26:23 +09:00
Hermet Park edab8f44a4 evas vg: fix memory leak at gradient.
Summary:
free memory properly when object is deleted.

@fix

Reviewers: #committers, devilhorns

Reviewed By: #committers, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7165
2018-10-17 14:08:32 +09:00
Wonki Kim 97e71b9dc4 ecore_wl2: Fix a memory leaking case
Summary:
there is a memory leaking in some case.
this patch fixes it.

Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7167
2018-10-17 10:19:44 +09:00
Hermet Park e6fc1ded6e interface gfx_path: fix incorrect doc content. 2018-10-16 21:31:41 +09:00
Hermet Park adcaa8b82b devas vg: return default root node if possible.
Summary:

It could return NULL root node
while user expect a valid root node in default
as It did before.

This is a regresion bug from long ago.

@fix

Reviewers: #committers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7162
2018-10-16 15:07:51 +09:00
Hermet Park 00f889d91a evas vg: fix memory leak.
Summary:
eina array must be flushed when object is deleted.

@fix

Reviewers: #committers, devilhorns

Reviewed By: #committers, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7160
2018-10-16 12:24:01 +09:00
Marcel Hollerbach 2cb2e6f87c meson: another build break fix
the installation of the header was forgotten which broke app compilation
against meson builds

Differential Revision: https://phab.enlightenment.org/D7161
2018-10-15 22:02:17 +02:00
Marcel Hollerbach d21ddea3da meson: fix build break 2018-10-12 11:26:26 +02:00
Marcel Hollerbach a0562aa066 meson: add buildsystem to ecore_wl2
this was missing. Reported by jf_simon.
2018-10-12 11:15:29 +02:00
Youngbok Shin 32504a8cfa elementary textpath: support legacy APIs
Summary:
Efl.Ui.Textpath was added when we were developing new interfaces.
So, basically, it does not support 'legacy' APIs. ex) elm_textpath_add
But, in Tizen, the legacy APIs had been delivered in old version of EFL.
To reduce maintainning cost between the platforms, this patch will be helpful.
@feature

Test Plan: N/A

Reviewers: Hermet, woohyun, zmike, cedric, herdsman

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7033
2018-10-12 15:42:31 +09:00
Hermet Park 57fd66c4b5 evas image: fix preloading compatibility broken.
Well... Logically, we don't need to request preload again,
If image is loaded already. But somewhow it broke the enlightenment pager
and I need to revert the previous behavior here.

Whatever image is loaded or not, here image requests preload again,
unless it is already on preloading.

This was introduced by babacf41b7269a257065a41a2a4ec7763bada25f.

This fixes enlightenment pager bg non visible issue.
2018-10-12 14:32:20 +09:00
Carsten Haitzler 0c1eab0cf9 evas cache - avoid a segv...
but this needs mroe digging as to how this state was gotten to to
begin with.
2018-10-11 16:25:06 +01:00
Carsten Haitzler d67e9875c8 ecore_x - add nouveau into the whitelist and clean up so it's a list
it was a lot of if cases before now it's an array with min version
parameters and globs for matching drivers etc. - much cleaner and
neater to afdd things to the whtielist now.
2018-10-11 16:25:05 +01:00
Marcel Hollerbach a82b24aaa8 elementary: shutdown cocoa currently
Depends on D7012
2018-10-11 17:11:36 +02:00
Marcel Hollerbach ba0630afda meson: support older udev systems
Differential Revision: https://phab.enlightenment.org/D7145
2018-10-11 17:11:36 +02:00
junsu choi 93ee5f9d53 efl_ui_win: Move force resize code on first draw
Summary:
In D6165, there was a modification that forced resize_job
to be called using sd-> deferred_resize_job.
Even if we set true in sd-> deferred_resize_job,
it will be changed to false by calling other function to be called.
(sd->deferred_resize_job = EINA_TRUE; ->
  _elm_win_resize_objects_eval ->
  _elm_win_resize_job ->
   sd->deferred_resize_job = EINA_FALSE;)
Eventually _elm_win_frame_obj_update is not called.
There is a case where _elm_win_frame_obj_update can not called in tizen.
For this reason, make sure to call resize_job when first drawing based on D6165.

Test Plan: N/A

Reviewers: eagleeye, zmike, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7156
2018-10-11 20:28:13 +09:00
WooHyun Jung b2c26c1875 efl_ui_progressbar: avoid meaningless theme_apply 2018-10-11 19:42:57 +09:00
Hermet Park 9f99ab1eae evas cache: clear up caching locking and reference count.
Summary:
On reviewing, found out some logical problems in evas cache.

ref-drop pair doesn't make sense, proper locking for cache image neither.

Reviewers: raster, #reviewers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7129
2018-10-11 13:54:40 +09:00
Hermet Park 27fd6a2eab evas: remove redundant internal functions.
Summary:
Since efl object is introduced, magic check is no more used.
Plus, remove redundant object functions interfaces
 - type_id,
 - visual_id,
 - store
 - unstore

Reviewers: #committers, bu5hm4n

Reviewed By: #committers, bu5hm4n

Subscribers: bu5hm4n, raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7153
2018-10-11 13:46:37 +09:00
Marcel Hollerbach 07b69d3d85 ecore_wl2: fix build break
when i tested this commit i had wayland turned off. Sorry for the noise.
2018-10-10 14:09:24 +02:00
Hosang Kim 53b8174fbf eldbus: remove unreachable code.
Coverity doesn't like this unreachable code.
Differential Revision: https://phab.enlightenment.org/D7120
2018-10-10 12:55:21 +02:00
Marcel Hollerbach 0258946f71 meson: add dl to eina
eina uses dlsym. I forgot this.

Differential Revision: https://phab.enlightenment.org/D7149
2018-10-10 12:55:21 +02:00
Wonki Kim 18f9fbc018 elementary: fix a typo on override func of signal_callback_del
there is a logic that forwards a calling to supoer class on efl_ui_layout.
and the logic have a mismatching calling as you could see.
and this patch fixes the typo error.
Differential Revision: https://phab.enlightenment.org/D7151
2018-10-10 12:55:21 +02:00
Hosang Kim 185a1f739b ecore_wl2: fix coverity issue. (Resource Leak)
Module is not freed when eina_module_load is failed.
Differential Revision: https://phab.enlightenment.org/D7152
2018-10-10 12:55:21 +02:00
Hermet Park 1bc57942c0 evas vector: fix typo. 2018-10-10 14:22:34 +09:00
junsu choi ecc6fe749c ecore_con_legacy: fix coverity issues (use after free)
Summary: for hard failures (highly unlikely), the handle would be deleted and the next use would crash.

Test Plan: N/A

Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7139
2018-10-08 11:19:53 +09:00
Marcel Hollerbach 347dc66ba9 meson: unify system properties
this unifies the system types into 4 boolean flags
This fixes the fact that meson changed the system string accross
versions.

Differential Revision: https://phab.enlightenment.org/D7144
2018-10-05 13:40:29 +02:00
junsu choi 01e6f80e57 elm_genlist: prevent null pointer access
Summary: it->item->block can be null. so add null check.

Test Plan: elementary_test -to "genlist show/bring"

Reviewers: SanghyeonLee, woohyun

Subscribers: woohyun, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7146
2018-10-05 17:13:54 +09:00
Alastair Poole 8974f98b1c eeze: Add buildsystem to list of dependencies.
Summary:
This fixing building E with EFL both using meson
build system. Previously missing symbols, which
this patch resolves.

Reviewers: bu5hm4n, raster

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7142
2018-10-04 12:41:46 +01:00
Jaehyun Cho d03d29f7a2 elm_theme: fix return value when default style fallback is done
To keep backward compatibility, EFL_UI_THEME_APPLY_DEFAULT is returned
instead of EFL_UI_THEME_APPLY_SUCCESS if style is not found in theme and
default style fallback is done instead.

This patch fixes 7353fc1cb8

@fix
2018-10-04 19:21:44 +09:00
Youngbok Shin 038346dce0 eina debug: fix a double unlock issue
Summary:
It was caught by Covertity.
This patch will remove a potential double unlock issue.
@fix

Test Plan: N/A

Reviewers: zmike, raster, cedric, Hermet, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7137
2018-10-04 18:58:04 +09:00
Youngbok Shin 75296e32df elementary entry: apply scale to all edje objects
Summary:
When an entry is scrollable, its resize object is scr_edje.
So, to apply scale properly, elm_entry needs to apply scale
to its entry_edje, too.
@fix

Test Plan: Apply scale to scrollable entry

Reviewers: herdsman, woohyun, cedric, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7140
2018-10-04 18:53:36 +09:00
Jérémy Zurcher c68ac6c1b7 meson : fix eina/meson.build
issue : when running 'ninja clean' 'buildtype' option is set to 'custom',
patch : set specific options for 'debug' and 'release',
        set default options for any other value of 'buildtype'
Differential Revision: https://phab.enlightenment.org/D7131
2018-10-03 13:07:10 +02:00
Marcel Hollerbach 46d464e5bf here comes meson
a new shiny buildtool that currently completes in the total of ~ 4 min..
1 min. conf time
2:30 min. build time
Where autotools takes:
1:50 min. conf time
3:40 min. build time.

meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read.

Further informations can be gathered from the README.meson

Right now, bindings & windows support are missing.

It is highly recommented to use meson 0.48 due to optimizations in meson
that reduced the time the meson call would need.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Differential Revision: https://phab.enlightenment.org/D7012
Depends on D7011
2018-10-02 17:22:50 +02:00
Marcel Hollerbach 70ecf1056b ecore_cocoa: stop leaking init counts 2018-10-02 16:22:07 +02:00
Alastair Poole 1566861ace macOS: make eina_environment_tmp_get() work as elsewhere.
On macOS the tmp file path always terminated with an additional
separator, causing issues when making file name comparisons.
For example, the Eio test suits would hang due to this.
This patch trims any trailing path. When joining paths
with eina_environment_tmp_get, macOS should behave
similarly as on other architectures.

Differential Revision: https://phab.enlightenment.org/D7128
2018-10-02 16:14:47 +02:00
Marcel Hollerbach 66aa76ad89 efl_ui_dnd: fixup leaking inits and code duplication
In fff4d1ba97 one selection_manager_get
method was patched to behave like this, however, it completly broke the
fact of *only-one-manager* since the same code was duplicated in a other
files (efl_selection.c). This now unifies this code, and adds back the
assertion for only one manager per window.

Additionally a shutdown function is added, the app never destroyes, but
the selection manager decided to init some subsystems itself
(ecore_x for example). This lead to to a leak of init counts in ecore_x,
which lead to elementary test suite issues. This is now *finaly* fixed.

Differential Revision: https://phab.enlightenment.org/D7105
2018-10-02 16:13:13 +02:00
Marcel Hollerbach a349bd46eb eina: move definition of EFL64
previously it was defined in eina_config.h however. This file is
autogenerated, and having autogenerated parts of a file and static parts
is quite painfull, thus the definition is moved into eina_types.

Differential Revision: https://phab.enlightenment.org/D7104
2018-10-02 16:13:13 +02:00
Bowon Ryu 10e00e3ecc efl_page_transition_scroll: fix warning the dereference before null check
Summary: if target is null, then terminate the function because it is not intended.

Test Plan: N/A

Reviewers: eunue

Reviewed By: eunue

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7127
2018-10-02 19:47:22 +09:00