Commit Graph

268 Commits

Author SHA1 Message Date
Daniel Juyung Seo d58b4401e8 flip, gengrid: Removed dead assignments which were reported by clang
build.

https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-cMar9x.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-ZMmiQe.html#EndPath
2014-01-07 00:11:00 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Ryuan Choi 9816a8cae1 gengrid: Remove unnecessary if statement
Summary: func.content_get is already checked in enclosed block.

Reviewers: seoz, cedric, raster

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D366
2013-12-04 13:16:02 +09:00
Daniel Juyung Seo 38c19d2739 gengrid: refactoring of commit 7187a3124fc6c169fcfec2c249a1fd483481fbba.
- follow the convention for structure name
- removed unnecessary callback
- removed wrong api usage
- removed unnecessary variables
- removed unnecessary parameter passing
- fixed ugly ui
- added 'static' to local function
- changed frame description more descriptive
- fixed formatting
2013-12-02 20:32:14 +09:00
Sanghyeon Lee 8531b7aeed [Gengrid] Enable Scroll To Type when item bring in or show region.
Scrollto positions are divided 4 type
NONE : do not scrollto.
TOP : scrollto position is always top viewport.
MIDDLE : scrollto position is always middle of viewport.
IN : scrollto position to fully visible in viewport.
2013-12-02 15:52:35 +09:00
Tom Hacohen 4c8d03894c Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra

Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
2013-11-07 14:30:22 +00:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo 9509986a05 gengrid/genlist: added Eo compatibles for elm_genlist/gengrid_multi_select_mode_set/get() APIs. 2013-11-04 01:15:58 +09:00
Daniel Juyung Seo 6a0f47d120 Genlist/Gengrid: Added multi select mode for genlist/gengrid.
elm_genlist_multi_select_mode_set/get()
elm_gengrid_multi_select_mode_set/get()
2013-11-03 23:58:57 +09:00
Ryuan Choi 5836a25bc8 genlist, gengrid: Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL
Summary:
Some applications like file viewer allow multiple selection only with
Control key was pressed.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D251

Conflicts:
	ChangeLog
	NEWS
2013-11-02 20:53:43 +09:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Ryuan Choi 2452ffe289 gengrid: adopted ELM_PRIV_XXX_SIGNALS to reduce human mistake.
"index,update" signal is missing in signal description.

So, This patch refactored signal declarations to avoid mistakes.
It was introduced since b430c07ca1f1.
2013-10-19 00:14:57 +09:00
Daniel Juyung Seo d9edd168d7 elm_gengrid.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:14:21 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park a7b11a4c56 elementary/genlist,gengrid - should be cancel the track object before item view is removed. 2013-09-13 16:20:40 +09:00
ChunEon Park f426e08982 elementary/elm_object_item - delete the track objects when genlist/gengrid items are unrealized. 2013-09-13 14:19:41 +09:00
Michaël Bouchaud (yoz) 9271fc7e0f elementary: don't send unrealized item signal on item update 2013-09-09 12:00:58 +02:00
Michaël Bouchaud (yoz) 742abe65e1 elementary: avoid some glitter on gengrid item creation 2013-09-09 11:53:47 +02:00
Daniel Juyung Seo f790e7b1a0 elm_gengrid.c: more ELM_SAFE_FREE macro for gengrid. 2013-09-08 18:50:00 +09:00
Daniel Juyung Seo 745488fff3 genlist/gengrid: use spacer when item edc supports elm.swallow.pad part. 2013-09-06 13:08:21 +09:00
Daniel Juyung Seo beddd2c007 elm_gengrid.c: code cleanup. 2013-08-28 08:47:47 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Daniel Juyung Seo f3537869a5 gengrid: implement selectraise feature.
Gengrid item will be raised on selection. This was implemented in genlist, list, and index.
2013-08-26 19:55:28 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Daniel Juyung Seo 14c7bf8039 elm_gengrid/genlist.c: removed logically dead code. NULL is already checked.
This fixes 'Logically dead code' warning which was spotted by coverity.
CID 1040038, 1040040, 1040036, 1040037.
2013-07-06 12:49:54 +09:00
Daniel Juyung Seo f1b685897d elm: do not declare SIG_FUCSED/SIG_UNFOCUSED if the const char is not used more than once.
ctxpopup, fileselector_button, naviframe, player, popup, bubble, button, calendar, check, clock, colorselector, datetime, diskselector, flipselector, gengrid.
2013-06-10 14:13:55 +09:00
Daniel Juyung Seo 8cf2c8a422 calendar, check, clock, colorselector, datetime, diskselector, flipselector, gengrid: added "focused" and "unfocused" documentations. 2013-06-09 18:55:42 +09:00
Daniel Juyung Seo 4738e0d6ae elm_gengrid.c: ELM_SAFE_FREE adoption.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 20:53:13 +09:00
Daniel Juyung Seo ef8701a173 elm: more ELM_FREE_FUNC cleanups. 2013-05-24 00:58:38 +09:00
Daniel Juyung Seo ac25946a19 elm: introduce ELM_FREE_FUNC for code quality enhancement.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.

This is not all. I will work on enhancing elementary more and more.
2013-05-22 02:24:02 +09:00
Flavio Ceolin d53cc519ff Welcome a new smart callback for scrollables -- page,changed. 2013-05-15 18:57:15 -03:00
Daniel Juyung Seo 9c28b4409e elm_gengrid.c: initialized local variable.
This needs to be re-visited.
I am also looking at you, JackDanielz.
2013-05-10 22:38:33 +09:00
Daniel Zaoui ac01929f37 Elementary: Drag & Drop feature for items containers
New APIs have been added to facilitate DnD for genlist, gengrid and list
widgets.
Tests have been added in the new section DnD to play with that.
2013-05-09 13:57:31 +03:00
Shinwoo Kim 3630715e62 [access][gengrid] fix: gengrid does not work under the accessibility 2013-05-03 19:53:56 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Daniel Juyung Seo 758bbce11d gengrid/genlist: removed relcount leftovers from commit 3f4c3e03c600c87782543cf08de886016f2c192e. 2013-04-02 12:44:27 +09:00
Flavio Ceolin 9ea9e13c26 Genlist, gengrid: two new smart callbacks
Adding ones for mouse pressed and mouse released on items. The event
info for both callbacks are the items being pressed/released.
2013-03-20 13:39:51 -03:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Daniel Juyung Seo 8d1effeb20 elm elm_gengrid.c: Optimize item count calculation when an item is appended. Patch by Junki Cho <jk0811.cho@samsung.com>
Do not need to calculate the list count when a gengrid item is appended.
Just use item_count which was already calculated.
2013-03-04 20:32:04 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
Jaehwan Kim d58d971e6f Add the option about sending signals in content_pos_set.
When the scroller is resized, the signals("elm,action,scroll", "elm,edge,top" so on) shouldn't be sent,
because it's not a scroll-action. So in this case, the content_pos_set should be called without the signals.
2013-02-28 15:18:51 +09:00
ChunEon Park 35c5f65051 elementary/gengrid - support language,changed smart callback
SVN revision: 83846
2013-02-12 07:29:16 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
Daniel Juyung Seo 84d251acc8 elm list, genlist, gengrid: Added highlighted and unhighlighted signal callbacks.
SVN revision: 82750
2013-01-14 10:12:50 +00:00