Commit Graph

11627 Commits

Author SHA1 Message Date
Marcel Hollerbach b592c6df35 elm_icon_external: cleanup ERR msg in error case
Summary:
Setting the group without checking it exists causes a errormessage, this
is pretty annoying for people which want to set a standart icon. And
give a better errormessage if the standart setting failed.

Reviewers: raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2686

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Hosang Kim 6d03b2af7e atspi_bridge: fix memory leak issue
Summary:
Call eldbus_message_unref to free Eldbus_Message structure.
And delete unused Eldbus_Message variable.
CID-386474
CID-391869
CID-394549

Reviewers: raster, woohyun, CHAN, Hermet, seoz, lukasz.stanislawski, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2690

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vaibhav Gupta a350f64b6e test_gengrid: remove EINA_UNUSED for a used argument
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2670

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Anand dde6511cbc elm_gen_common: fix typo in Struct variable documentation
Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2634

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Minwoo, Lee 1f93f2c712 edje_externals: add safety check for NULL pointer
Summary: Dereferencing null pointers in external_signal()

Reviewers: bdilly, raster, woohyun, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2688

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
taehyub f1778f1884 app_server: add null check for dbus_state_set/elm_app_server_views_eet_new
Reviewers: Hermet, woohyun, raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2705

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vitor Sousa c875a437bd elm_image: Solve clash on the meaning of "animated"
Summary:
Both Elm_Image and its base interface Efl.Image have a property named
"animated".
The meaning for Efl.Image is whether or not the image has animation.
On the other hand, Elm_Image use it to set whether an image, which supports
animation, is to animate itself or not.
Thus Elm_Image have another property (animated_available) to tell whether the
image have animation or not, making it even more confusing.

Renamed the "animated" property of Elm_Image to "animated_enable" to make
the intended meaning clearer.
Also replaced the "animated_available" property with the "animated" property
from the Efl.Image interface, since both refers to the same thing, in order
to reduce the API.

Added implementations of the legacy methods for backward compatibility.

Address the issue:
- Elm image and the image interface clash because of the meaning of "animated".
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/

Reviewers: felipealmeida, tasn

Subscribers: raster

Differential Revision: https://phab.enlightenment.org/D2354
2015-06-17 10:17:19 +01:00
Jaehwan Kim 7c67f4e1ba config: fix comment 2015-06-17 17:51:40 +09:00
Jaehwan Kim 290f4fe871 config: make a config directory, if it is not.
create the config directory to register flush file to eio_monitor.
2015-06-17 17:38:24 +09:00
Carsten Haitzler 02cf05265b fix more elm config file pointer access
again - follow up from changes to config code to fix seg
2015-06-17 16:54:08 +09:00
Carsten Haitzler 4089264efb elm config files - don't write to file if file handle is null
fixes seg with new file only config for elm
2015-06-17 16:38:54 +09:00
ChunEon Park 50aceb5a89 win: fix bug about engine value.
When application does not have any value of engine,
this app should be launched with elm_config's value.

Signed-Off-By: Wonsik Jung <sidein@samsung.com>
2015-06-17 13:54:42 +09:00
Mike Blumenkrantz 21f0103397 win: do not use deferred ecore evas deletion for FAKE wins
these ees will be deleted externally anyway

@fix
2015-06-16 17:01:49 -04:00
Mike Blumenkrantz cb37de01f6 win: only trigger del trap if win type is not FAKE
@fix
2015-06-16 17:01:43 -04:00
Mike Blumenkrantz 6061ed0a75 theme: migrate all e users of darken_rounded_square to new darken_square image
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look

image created by me, licensing to match rest of theme images

@feature
2015-06-16 16:31:10 -04:00
Mike Blumenkrantz 6f62c8b496 notification: set fixed on app icon to eliminate edje calc error 2015-06-16 16:31:10 -04:00
Thiep Ha dd67ff133f entry: emit changed,user signal when text is pasted or dropped
Summary:
When text is pasted or dropped into entry, the "changed,user" signal
should be emitted, not "changed" signal.
Currently, the "changed" signal is emitted.
This patch fixes this issue.

@fix

Reviewers: herdsman, tasn

Subscribers: tasn

Differential Revision: https://phab.enlightenment.org/D2710
2015-06-16 14:41:55 +01:00
Jaehwan Kim 43cfff4cd5 elm_config: remove X dependency.
Summary:
In wayland, elm_config_all_flush doesn't work.
It has X dependency totally.
It uses ecore_file_monitor instead of X property.

Reviewers: Hermet, devilhorns, raster, cedric

Differential Revision: https://phab.enlightenment.org/D2502
2015-06-16 13:52:24 +09:00
Mike Blumenkrantz 586efebad6 comp effects: add tooltip visibility effect 2015-06-15 13:55:34 -04:00
Mike Blumenkrantz 5a061d5e0f comp effects: increase size of vertical visibility effect to include shadows 2015-06-15 13:55:34 -04:00
Ji-Youn Park c933ff6f50 elm_flip: small error handle fix
if we cannot create slice, we had better stop to change slice
2015-06-15 22:38:12 +09:00
Jaehyun Cho d8a5472f5b index: Add NULL check for malloc memory allocation. 2015-06-15 15:59:49 +09:00
Jaehyun Cho 9e1968823d layout: Add NULL check for calloc memory allocation. 2015-06-15 15:39:02 +09:00
Jaehyun Cho a67e7e39ef layout: Fix to pass correct argument for edje_object_part_unswallow. 2015-06-15 15:36:09 +09:00
Jaehyun Cho c04635c9b7 layout: Add NULL check for ELM_NEW memory allocation. 2015-06-15 14:56:42 +09:00
Youngbok Shin ed343cbab0 clock: Add safety check for NULL pointer from localtime() func.
Summary:
localtime() can return NULL when there is an error.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2666
2015-06-15 08:17:32 +03:00
Youngbok Shin 6f33f4f1d1 cnp: Add safety check for NULL pointer from malloc().
Summary:
It could make crash when malloc is failed.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ, thiepha

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2671
2015-06-15 08:08:34 +03:00
Youngbok Shin d04e6c7d6a cnp: Fix memory leak issue.
Summary: Call efreet_uri_free() API to free Efreet_Uri structure.

Test Plan: None.

Reviewers: raster, cedric, woohyun, Hermet, thiepha, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2655
2015-06-15 08:05:02 +03:00
ChunEon Park d103e00145 calendar: + null check. 2015-06-15 13:58:02 +09:00
ChunEon Park 150f3b421c clendar: + null check
gmtime can return NULL vaule.
if so strftime will cause crash.

this patch just prevent that potential situation.
2015-06-15 13:39:14 +09:00
Hosang Kim 81ead01597 elm_interface_scrollable : Fix logic about setting EVAS_EVENT_FLAG_ON_HOLD
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.

Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked

Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2550
2015-06-15 09:56:02 +09:00
Daniel Zaoui fcbb42d19b DnD: fix memory leak 2015-06-14 11:23:52 +03:00
Daniel Zaoui 9781aef4bb DnD/X11: Fix invalid access to memory
It seems X doesn't send the data with the termination.
2015-06-14 11:23:52 +03:00
Daniel Zaoui f66224b5f3 DnD/X11: rename notifiers
As the notify functions don't notify anymore, they have to be renamed to
reflect their real job, i.e data preparers before calling user
functions.
2015-06-14 11:23:47 +03:00
Daniel Zaoui b779ae6780 DnD/X11: refactor the notifiers
Each data notifier was preparing data and then invoking the user callbacks
for DnD or selection protocols.
Most of the notifiers code was handling the user callbacks invocation
and was the same for all of them.

This patch simplifies the notifiers by moving the user callbacks
invocation into a common place for all the types, i.e into the notify
dispatcher.
The notifiers prototype has been changed to suit the code modifications.
2015-06-14 11:21:33 +03:00
Daniel Zaoui 271a37f6eb DnD/X11: remove unused function 2015-06-13 12:29:35 +03:00
WooHyun Jung 1ca127d826 fileselector: add NULL check for memory allocation 2015-06-13 15:45:36 +09:00
Thiep Ha 8fe80fc6a3 entry: add dnd image handling
When image is dropped into entry, we should insert image to it.
This patch adds image inserting in dropping.

@fix
2015-06-12 11:53:57 +03:00
Thiep Ha 551074c5f2 Cnp/X11: correct object parameter in datacb
The object parameter in datacb must be the selection request object,
not the selection owner object.
This patch corrects that.

Test case: open two windows with entry, copy text from one entry in
first window, paste to entry in other window.

@fix
2015-06-12 11:53:55 +03:00
Thiep Ha 99ab88c1c7 Cnp/X11: move entry-only code in elm_cnp to entry
There is code in elm_cnp.c which is used to paste data to entry widget only.
This can cause error if widget is not entry.
This patch removes that code in elm_cnp.c and adds datacb to entry
to insert content to entry.

@fix
2015-06-12 11:53:34 +03:00
Thiep Ha 1ee5b72ceb Dnd/X11: add dnd support for image, uri types
There is no dnd callbacks for image, uri types.
This patch adds dnd callbacks for those types.

@fix
2015-06-12 11:45:00 +03:00
Youngbok Shin 61fe7e5f39 cnp: Add safety check for NULL pointer from strdup().
Summary:
It could make crash when strdup() is failed.
CID - 329115
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2673
2015-06-12 11:02:05 +03:00
Youngbok Shin 9fba74ea72 cnp: Add safety check for NULL pointer from calloc() for anim_icon.
Summary:
It could be failed to allocate memory for Anim_Icon.
CID - 337351
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2672
2015-06-12 11:01:55 +03:00
Youngbok Shin e227bad7fe cnp: Add safety check for NULL pointer from _elm_util_text_to_mkup().
Summary:
_elm_util_text_to_mkup() func could return NULL when malloc is failed internally.
CID - 398441
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2668
2015-06-12 10:56:22 +03:00
Ji-Youn Park bda0ccfb60 elm_win: fix keygrab bug to use wrong keygrab mode
The code set worng ecore_x_keygrab mode according keygrab mode.
and changed some codes for readablity.
2015-06-12 11:16:25 +09:00
Daniel Kolesa 2fbe7d5103 eo: migrate all event docs to new syntax 2015-06-11 17:14:02 +01:00
Mike Blumenkrantz b82ded243f comp effects: add vertical visibility effect 2015-06-11 11:50:52 -04:00
Daniel Kolesa 80f101d420 eo: migrate enum docs to new format 2015-06-11 16:39:33 +01:00
Thiep Ha 8677ef1add widget: Add null check
Summary: Adding NULL checking when allocate memory.

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2663

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
Thiep Ha d9712847be transit: add NULL check for memory allocation.
Summary: Adding Null checking when allocate memory.

Reviewers: Hermet, seoz

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2662

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00