Popup has an abnormal parent-child tree as follows, and this patch fixes it.
- when popup is created, it creates a notify as a child and the tree is [parent - popup - notify].
- when popup is visible, it is set as a content of notify and the tree is [parent - notify - popup].
- when popup is hidden, the tree is reverted.
To fix this, I made an internal layout and set it as the content of notify
so that the tree remains as [parent - popup - notify - layout] all the time.
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
Summary:
Although user should give the position of button such as button1, current elm_popup
changes button's position or style as the number of buttons while adding or removing
buttons.
So, when application developers add buttons as wrong order or removed buttons,
applications may be crashed.
This patch refactored the behavior not to change the position intended by application
developer.
Test Plan: added new test case to test_popup.
Reviewers: seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D259
Jaeun Choi
Tom Hacohen
Daniel Zaoui
Ryuan Choi
Daniel Juyung Seo
Cedric Bail
Shinwoo Kim
Yakov Goldberg
Gustavo Lima Chaves