Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
Summary: Genlist/gengrid object geometry was used before this patch but using the pan object geometry is more correct. This can be reproduced when the size of "elm.swallow.content" part is smaller then the size of scroller object, focus animtaion on items is jerky.
Reviewers: raster, seoz, singh.amitesh
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D818
Summary: Name of that function is not proper in my opinion. Please consider that revision.
Reviewers: raster, seoz, bluezery, stanluk, jaehwan, kimcinoo
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D827
This reverts commit b8549f3e83a8592145a50085182583adead2c74e.
this build system is bad and whoever did the eo integration should not feel pleased with themselves.
this.is.BROOOOOOOOOOOOOOOKEEEEEEEEEEEEEEEEEEENNNNNNNNNNNNNNNNNNNNNNNNNNNNN.
SERIOUSLY.
you cannot go scrolling all over the place in every widget that has a scroller just because the widget gets focus. what user wants that? no user anywhere, under any circumstances, ever, in all of history.
if you dare to put this back in, I will continue to remove it for the rest of eternity until it never, ever scrolls in any unwanted case. the focused item doesn't have to always be in the viewport, and should never be moved into the viewport [[[[[[[ except to maintain an already-existing position inside the viewport ]]]]]]]
too much of my time wasted on this stupid "feature" which should have been MUCH more thoroughly tested and reviewed before it was merged.
T1205 STILL NOT FIXED
Summary:
Earlier pos was getting used for the item coordinates. To support other Ecore_Pos_Map variations, frame variable should be used.
@fix
Test Plan:
elementary_test-> "Gengrid Focus". Enable reorder mode and use keys to move
the focused item.
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D811
Summary:
The basic idea is from Abhinandan Aryadipta and I implemented this in
upstream.
Special thanks to JackDanielZ for eolian madness.
@feature
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D803
Summary:
This is based on bb1e8afd.
@feature
Test Plan: elementary_test->"Gengrid Focus"
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D702
Summary: This was missed in 43eb52e159.
Test Plan:
elementary_test->"Gengrid Focus" and enable "reorder mode" by clicking "redorder mode enable" checkbox.
Move the items by direction keys.
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D801
elm_gengrid.c: In function '_item_move_cb':
elm_gengrid.c:2084:19: warning: declaration of 'y1' shadows a global
declaration [-Wshadow]
elm_gengrid.c: In function '_swap_items':
elm_gengrid.c:2136:19: warning: declaration of 'y1' shadows a global
declaration [-Wshadow]
I don't know why this was added, but it breaks the ability to set focus on any widgets at all under some circumstances. it also is nonsensical since you should never need to set focus while selecting because:
* you are selecting with the mouse button, thereby having previously triggered focus from the mouse click
* you are selecting using api, in which case there's a config option to allow retaining selection which is also conceptually broken by this behavior
@fix
Summary:
Moved the construction of selection handles to _update_selection_handler in order to
reduce the cost of construction of elm_entry little bit.
Reviewers: thiepha, Hermet, seoz, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D756
Summary:
Previously, previous view was just shown by evas_object_show and hidden by evas_object_hide.
Now, "elm,state,visible" and "elm,state,invisible" signals are emitted to enable application to do in edc what they want when each view is shown/hidden.
Reviewers: Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D785
Summary:
- Added two APIs elm_gengrid_reorder_mode_start/stop
- Add two smart callbacks
- "item,reorder,anim,start" - This is called when a gengrid item movement
has just started by keys in reorder mode.
- "item,reorder,anim,stop" - This is called when a gengrid item movement just
stopped in reorder mode.
@feature
Test Plan: elementary_test->Gengrid Focus
Reviewers: raster, seoz, SanghyeonLee
CC: seoz
Differential Revision: https://phab.enlightenment.org/D723
First on_focus call should consider focus highlight enable status and
do the different job according to that.
This can be tested in "genlist 7" and "genlist focus" examples in
elementary_test.
The needed header was not packaged and thus made distcheck fail. I put
it into the unstable headers because I'm not sure if they are considered
stable yet. If this is the case please let us know so we can move it over.
elm_win_screen_size_get() is broken for this use case since the tooltip actually needs the full xinerama screen geometry, which is the geometry of the root window and NOT the current screen
@fix
Summary:
If window is rotated, the drag window position is incorrect.
In drag start, the drag window is placed in incorrect position if main window is rotated.
Fix: Update drag window according to window rotation.
@fix
Reviewers: JackDanielZ, raster
Reviewed By: raster
CC: woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D746
Summary:
boundary check of _elm_scroll_wanted_coordinates_update() is wrong.
boundary was checked with assumption that 0, 0 is top, left
however, 0, 0 could be different according to usages, in case of gengrid, 0, 0 was center left not top left)
Do not assume the min/max value, but use pan min/max value for boundary check
Fixes T1092
Test Plan: elementary_test -> grid -> uncheck multi select mode -> select first item -> click bring in -> resize window
Reviewers: raster, woohyun, seoz, zmike
CC: seoz
Maniphest Tasks: T1092
Differential Revision: https://phab.enlightenment.org/D720
Summary:
after I drag by using scrollbar, if I resize window, the scroller position was moved to coordication before dragging.
invoke _elm_scroll_wanted_coordinates_update() after position setting in _elm_scroll_scroll_bar_read_and_update();
@fix
Test Plan: elementary_test -> drag scroller to center -> resize window -> scroller shouldn't go back to top
Reviewers: raster, woohyun, seoz
CC: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D722
Summary:
Allow to create ATSPI aware objects only by attaching Atspi interface to
Eo object. Apply protected rule to all methods, properties which should
not be available to app developer. Remove public atspi header from Elementary.h.
Make Elm_Widget inherit from Atspi interfaces, Elm_Win inherits additional
Atspi_Window interface.
Unified file names - all atspi related objects/interfaces can be found under
elm_atspi_*
and elm_interface_atspi_*.
Test Plan:
build&install, out-off tree example compilation with gcc and g++,
Orca screen reader tests on Ubuntu 12.04.
Reviewers: raster, seoz, tasn, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D718
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.
solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.
signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.
Reviewers: jaehwan, woohyun, seoz, Hermet, raster
CC: govi, rajeshps, thiepha
Differential Revision: https://phab.enlightenment.org/D674
Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D760
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.
Test Plan: None
Reviewers: raster, Hermet, seoz, jpeg
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D755
Summary: Crash occured when config was reloaded and hash data become invalid.
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D750
Signed-off-by: Cedric Bail <cedric.bail@free.fr>
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix
Test Plan: None
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D753
Summary:
when multiple key down is coming while increase/decrease the spinner values,
the speed acceleration will be reset by the new key down.
Instead, it stops the increase/decrease the spinner values behavior.
@fix
Test Plan: None
Reviewers: Hermet, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D749
Summary:
This patch unifies two functions with different name and same functionality:
_val_inc_stop and _val_dec_stop into _spin_stop.
Test Plan: None
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D748
we can prevent to handle the widget events from the widget infra,
if the object is disabled.
conceptually, disabled object should not be interacted to user input(key, mouse)
Summary: This patch makes key binding support multiple and inverse modifier set.
Test Plan: None
Reviewers: raster, Hermet
Differential Revision: https://phab.enlightenment.org/D717
There are some missing implementations whith elm_web implements
but elm_web2 didn't yet.
This patch just added dummy implementations to fix build break.
Summary: No need to check ev->string if use ev->key instead of ev->keyname.
Test Plan: None
Reviewers: raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D714
With Eo2 you can return values directly without the need to use a pointer
(use the C return).
For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());
@feature
Summary:
Currently, when drag starts, drag window is not skipped. It makes ecore_x cannot find dropable window in some cases.
Issue: Dropable window is not found if we drop inside the initialized area of drag window.
(Example: in Dnd Types of elementary test, try to start dragging at right edge of left label and drop to left edge of right label. The drop is failed).
Reason: Ecore_x considers drag window when it tries to find dropable window at specific position. Therefore, it cannot find dropable window.
Resolve: Skip drag window.
@fix
Reviewers: raster, JackDanielZ, seoz
CC: woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D710
Summary:
In win.edc add blocker for its content and programs for it. Add
Eina_Bool blocked and was_enabled to _Elm_Menu_Item for correctly blocking
and unblocking of main_menu. They used for saving state which was before modal
win was apeared. Add callbacks and private functions in menu.c for blocking and
unblocking menu. Add integer modal_count to Elm_Win_Smart_Data for creating
enum of modal wins. Add changes in win.c for blocking content, in_focus callback
and menu while modal win is exist.
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v, raster
Differential Revision: https://phab.enlightenment.org/D607
- Added internal function _elm_list_elm_widget_event_direction.
- Simplified cascaded if statements.
- Note: focus_on_selection feature is still broken.
- Moved a check for direction at the start of the function based on the
horizontal mode configuration.
- Removed unnecessary focus set to edje object. In this case, that item
will get the focus automatically by elm widget item focus
infrastructure.
But this focus_on_selection feature is still broken. I need to fix them
more.
Summary:
1. Name of sources from external module was not free'd. (there was type mismatch between external module and internal impl.)
2. after eina_module_list_free(), eina_array_free() was not invoked.
3. alloc'd but not free'd
@fix
Test Plan: valgrind
Reviewers: raster, cedric, seoz, bluezery, woohyun
CC: seoz
Differential Revision: https://phab.enlightenment.org/D661
Summary:
Fixed the focus animation in horizontal mode. Earlier focus was moving
out of the view port in horizontal mode
@fix
Reviewers: seoz, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D693
Summary:
The url variable used for ecore_file_download_full api was not being freed when the api failed
@fix
Test Plan: elementary_test->map
Reviewers: seoz, daniel, raster
Reviewed By: raster
CC: govi
Differential Revision: https://phab.enlightenment.org/D692
Summary: Avoid un-necessary focus animation call if the source and target have same co-ordinate
Reviewers: seoz, woohyun, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D679
Summary:
In case we register two or more of same drop callbacks for one object, when that object is deleted, segmentation fault happens.
Test case: Register only same callbacks more than two times for one object. Delete that object (manual or auto). Segmentation fault happens.
Reason: When object is deleted, we remove all drop callbacks registered with the object. The _all_drops_targets_cbs_del and elm_drop_target_del are used to do that and they operates on the same cbs_list. If elm_drop_target_del remove the current and the next callbacks in cbs_list, the segmentation fault will happen at _all_drops_targets_cbs_del.
Fix: Check and use updated cbs_list.
@fix
Reviewers: JackDanielZ, raster, seoz
Reviewed By: JackDanielZ
CC: woohyun
Differential Revision: https://phab.enlightenment.org/D691
Summary:
Earlier, Focus can only move out of gengrid from first or last item.
Now, Focus can move out of gengrid if focus is on edge items.
@feature
Test Plan: elementary_test->Gengrid Focus
Reviewers: raster, seoz
CC: seoz, nirajkr
Differential Revision: https://phab.enlightenment.org/D682
legacy set to null was used for every function to not generate a legacy
API. legacy_prefix set to null indicates no legacy has to be generated
for all the class.
this adds a hand1 sample cursor theme/image so the theme can find
cursors, (more should be added later), and now actually makes the elm
cursor handling properly set the cursor and update the hotx/y as
needed by tracking the hot swallow object. this relies on a fix in efl
as well.
Summary: This patch fixed build warnings in calendar, colorselector and diskselector.
Test Plan: make
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D685
Summary:
problem:
1) elementary_test -> entry -> close entry window
2) type mismatch warning is shown on console as below
ERR<19427>:eo lib/eo/eo.c:342 _eo_dov_internal() in elm_win.eo.c:2067: Can't execute function Elm_Win:ELM_OBJ_WIN_SUB_ID_XWINDOW_GET (op 0x167) for class 'Elm_Entry'. Aborting.
solution:
check top object type before invoke elm_win_xwindow_get()/elm_wl_window_get().
if it's not a window, find window id by using ecore_evas APIs.
Fixes T1141
Test Plan: elementary_test -> entry -> close entry window -> check console
Reviewers: raster, seoz, uartie
Reviewed By: raster
CC: seoz
Maniphest Tasks: T1141
Differential Revision: https://phab.enlightenment.org/D684
to fix a window position bug, window had to track actual geometry and
not alwasy be at 0,0. but this means hover, that is getting geometry
of the win object sometimes to figure out hover coverage area, and
thus now x, y are not 0, 0 anymore...
run in drm.
@feature: This adds an ELM_ENGINE=drm option so that elementary apps
can be run 'standalone' inside drm without any window managers,
compositors, etc
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
apply key binding to 4 widgets
this revision is only for reviewing
I'll send 4 seperate patches after review is done.
Test Plan: None
Reviewers: Hermet, seoz, raster
Differential Revision: https://phab.enlightenment.org/D678
Summary:
When window is rotated, the drag position is not updated.
It makes dnd cannot find out correct dropable objects.
This patch updates the drag position when window is rotated, so that dnd can find correct dropable objects.
@fix
P/S: This patch is originated from JackDanielZ (Daniel Zaoui). I update it to conform with lastest code.
Reviewers: JackDanielZ, raster
Reviewed By: JackDanielZ
CC: woohyun
Differential Revision: https://phab.enlightenment.org/D680
Daniel Juyung Seo
Anil Kumar Nahak
Ryuan Choi
ChunEon Park
Patryk Kaczmarek
Daniel Zaoui
zmike
Amitesh Singh
Carsten Haitzler
Yossi Kantor
Lukasz Stanislawski
Jaeun Choi
Jaehyun Cho
Hosang Kim
Lukasz Stanislawski
Stefan Schmidt
Gwanglim Lee
Thiep Ha
wonguk.jeong
Tom Hacohen
Bogdan Devichev
Mike Blumenkrantz
nirajkr
Rajesh PS
Cedric BAIL
Chris Michael