1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738
<hyoyoung@gmail.com>
On Thu, Mar 29, 2012 at 4:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> I made a patch about flip_realize.
> Currently flip feature uses content_objs, so it should keep its
content_objs.
> However it's lost at _item_flips_realize().
> So i fixed to initialize with its content_objs.
>
> Thanks
SVN revision: 69725
Attached to the mail is a patch for elm_panes.
I have a query that shall we hide the unset content in the widget itself or should application explicitly hide them after unsetting!
In case of edje_object_part_unswallow, application needs to do it explicitly and it is documented but in case of elm_object_part_content_unset, there is no documentation available.
Details of the patch:
Existing Issue before this change:
1. Panes deletes the older content while setting a new content even though both are same.
2. left and right content are being unswallowed in the content_left_set and _content_right_unset functions. So when the reparenting happens, say when the content is put inside a layout then only _sub_del gets called and
unswallowing does not happen as these functions do not get called.
e.g. @@ -253,8 +250,6 @@ _content_left_unset(Evas_Object *obj)
if (!wd->contents.left) return NULL;
Evas_Object *content = wd->contents.left;
elm_widget_sub_object_del(obj, content); //wd->contents.left already gets set to NULL in _sub_del
- edje_object_part_unswallow(wd->panes, content); // can be unswallowed in _sub_del as in case of reparenting like setting content in a layout, only _sub_del will get called, not this function
- wd->contents.left = NULL; //this instruction is redundent as it happens in _sub_del anyway
return content;
}
Change Description:
1. Unswallowing the contents now in _sub_del as this is a common function to be executed when subobject removal happens.
2. Comparing the current content with new before deleting.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
Thanks.
Regards,
Rajeev
SVN revision: 69720
The string will be freed in application's callback later. So 'const' is
not appropriate.
In elm_slider_indicator_format_function_set and
elm_slider_units_format_function_set.
SVN revision: 69692
<jchanwook@gmail.com>
On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey
SVN revision: 69691
way, is this correct? I had build warnings before.
menu_example_01.c: In function ‘_del_it’:
menu_example_01.c:17:6: warning: assignment discards qualifiers from
pointer target type
SVN revision: 69681
The squence is hold push -> mouse down -> mouse move -> hold pop -> mouse move continuously.
After upper sequence, the scroller will jump. So I fixed this issue.
SVN revision: 69631
Subject: [E-devel] [patch] elm_genlist - add merging edc strings list
I add like a routine in previous patch.
It add merging routines to realize functions.
also i removed "elm_widget_stringlist_free(cons)"
because all of it is freed at item_unrealize.
SVN revision: 69598
Subject: [E-devel] [?Patch]elm_?multibutto?nentry bug fix
I've attached patch to fix bug in multibuttonentry.
When this widget is unfocused, there's no code for making unfocused
entry in multibuttonentry.
Because of that, when multibuttonentry got focus again, entry couldn't
get focus normally.
so I've added code to fix this issue. when it's unfocused.
Also I removed unused value in resize_button() which is 'padding_inner'
SVN revision: 69583
Subject: [E-devel] [Patch][Genlist] Tree effect bug fix
I found some bugs in tree effect. flickering, emit signal to unrealize
item... so I fix it.
SVN revision: 69582
On Thu, Mar 22, 2012 at 9:38 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Now, Elm_Map_Marker, Elm_Map_Marker_Class, Elm_Map_Group_Class,
> Marker_Bubble are not used anymore. So I removed all things related
> those in elm_map.
> Please review this patch.
> Thanks
>
SVN revision: 69571
Subject: [E-devel] [Patch][elm_map] Add line, polygon, circle, scale
overlay
This patch adds new overlay APIs (line, polygon, circle, scale) for elm_map.
These overlays are adhered to map even though zooming, panning.
You can test these by doing "elementary_test --> click mouse right -->
overlay"
SVN revision: 69562
Subject: [E-devel] [Patch][elementary] elc_ctxpopup using elm_list
internally.
The patch is for using elm_list as a item controller of elc_ctxpopup.
I have learned that there was an opinion to change the internal
structure
of ctxpopup using the list.
It would be able to match up to your expectation. but it is just a draft
version of using list in ctxpopup.
So, It would be pretty good to me if you give any feedback on this.
Thanks.
SVN revision: 69561
Subject: [E-devel] [Patch][elm_list] bug fix: crash occurs when
container which contains the elm_list is deleted on the "elm_list item
clicked" callback
I have resolved the elm_list issue(goto ELM_LIST_CRASH_ISSUE_MAIL below, I
sent mail but I cannot find the previous mail -_-;).
It would be related with double free issue. In the "sub-obejct-del"
callback which name is _sub_del() sets item->icon to NULL.
And in the EVAS_CALLBACK_MOUSE_UP callback funtion which name is
_mouse_up() calls evas_object_unref();
It would try to free the item->icon but the item->icon is already set to
NULL. So.. the crash would occur..
SVN revision: 69555
Subject: [E-devel] [Patch][elm_map] Map overlay color & grouping &
route Fix
This is patch for elm_map
1. Default and Class overlay can be set color by
elm_map_overlay_color_set().
2. Fix test application for map API testing more.
3. Fix grouping for enabling group callbacks. If overlay group is
clicked, callback will be called.
And elm_map_overlay_group_members_set() API will be added later to get
list of overlays in the group.
4. Simplify route overlay: Previously, many polygon objects are needed
for one route overlay.
But now just one is needed.
SVN revision: 69554
Subject: [E-devel] [patch] elm_genlist - bugfix at item_state_update
I fixed minor error in _elm_genlist_item_state_update.
If item is selected, it sends signal to item and edit_obj.
But edit_obj is not checked by if statement.
I added a parenthesis for it.
SVN revision: 69538
Subject: [E-devel] [Patch][Genlist] Add the moved.after/before signal
instead of moved
Some applications want to know moved.after or before and relative item
because of updating their own list. So I separated moved into
moved,after and move,before.
SVN revision: 69537
Subject: [E-devel] [patch] elm_genlist - bugfix at flip_realize
I found a bug in _item_flip_realize.
It replaces previous string list without free.
this patch fixed for it.
SVN revision: 69536
Subject: [E-devel] [Patch][elementary] elm_list.c - item_content_set()
related.
The Eina_Bool item->dummy_icon and item->dummy_end of Elm_List_Item
indicate whether the content has REAL object or not.
- "not" means.. if elm_object_item_part_content_set(); is called with
NULL content, the Elm_List set the swallow part with
rectangle which has alpha value 0 and the item->dummy_icon or
item->dummy_end is set to EINA_TRUE. -
But in the item_content_set(); it works the opposite way. So when
content set with NULL value the flag should be EINA_TRUE.
SVN revision: 69535
<hyoyoung@gmail.com>
On Mon, Mar 19, 2012 at 11:48 AM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I found a bug in decorate mode that selection callback is called
twice.
> Because two _mouse_down callbacks are added to a genlist item.
> I'm fixing this bug and some refactoring.
>
> Thanks.
SVN revision: 69520
Subject: [E-devel] [Patch][elementary_test] test_layout
I have attached a patch for test_layout. Please review this and give
any feedbacks. Thanks.
SVN revision: 69501
Rajeev. Thanks Rajeev.
Existing Issue before this change:
The popup width gets scaled twice when theme_hook gets invoked
because of some reason such as style change, change in elementary
scale factor, change in widget scaling etc.
Change Description:
Removed setting scaling of internal object wd->base from theme_hook
as it is set to the widget scaling automatically.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
SVN revision: 69492
Attached to the mail is a patch for fixing issues
1. "bg edje object not deleted on deleting colorselector"
2. Theme hook fixed to read data items.
Existing Issue:
bg edje object of colorselector not deleted and data items not read again on theme hook.
Change Description:
1. elm_colorselector's edje object not deleted issue fix.
2. Theme hook updated to read data items again.
Signed-Off-By : ShilpaOnkar Singh <shilpa.singh@samsung.com>
SVN revision: 69459
Chanwook Jung <jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 7:25 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> This patch is evas_object_unref position change properly in
_item_select.
>
> Thanks
> Joey
SVN revision: 69373
Jung <jchanwook@gmail.com> But this will never be correct without
performance issue.
On Thu, Mar 15, 2012 at 4:43 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made the patch to fix index bug.
>
> Thanks,
> Joey
SVN revision: 69366
<jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 2:47 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made a simple patch. If ELM_LIST_COMPRESS mode, did not recalc
minw/minh
> in _sizing_eval.
>
> Thanks,
> Joey.
SVN revision: 69365
hyoyoung@gmail.com>. I committed his patch except for _calc_job diff.
On Wed, Mar 14, 2012 at 3:09 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all.
>
> This patch include two changes
>
> 1. at _scroll_item, added to check show_item is null or not.
> 2. at _calc_job, added to check genlist type
> because calc_job is added anytime, but some genlist clearing is can
> be done before doing calc_job.
>
> Thanks.
SVN revision: 69349
It's currently kinda hackish, but this can't be nicely solved without some
really needed (anyway) features in smart object callbacks. In the meanwhile
it's nice and working.
Thanks to WooHyun for the catch.
SVN revision: 69324
<hyoyoung@gmail.com>
On Tue, Mar 13, 2012 at 6:52 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> In _item_select, some if conditional is not working as user intention.
> always_select mode checking is reversed and no-select mode is not
checked.
> I add and fix it.
> Thanks
SVN revision: 69292
Daniel Juyung Seo
ChunEon Park
Mike Blumenkrantz
Michael BOUCHAUD
Vincent Torri
Jonas M. Gastal
Daniel Vieira Franzolin
Carsten Haitzler
WooHyun Jung
ShilpaOnkar Singh
Jaehwan Kim
Hyoyoung Chang
Sanjeev BA
GoUn Lee
chanwook jung
Gustavo Lima Chaves
Bluezery
cnook
Joao Paulo Fernandes Ventura
Leif Middelschulte
Daniel Juyung Seo
Jihoon Kim
Cedric BAIL
Jiyoun Park
Tom Hacohen
Bruno Dilly