Commit Graph

117 Commits

Author SHA1 Message Date
Daniel Zaoui f0ede508f8 Elm Popup Item: Migrate to Eo 2014-11-12 12:03:56 +02:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Daniel Juyung Seo b1421fa0bf popup: return correct value. 2014-08-23 02:33:10 +09:00
SangHyeon Lee 22d1ef2574 gengrid/popup: Fix wrong return type of _item_del_pre_hook.
Summary:
elm_widget calls _item_del_pre_hook of each widget and widget can
decide item deletion by return type. But gengrid and popup widget implemented
those _item_del_pre_hook function as a void type.
So this commit fixs the return types to Eina_Bool and changes gengrid widget to return EINA_FALSE when
the item wants to be deleted later.
And when the item wants to be deleted directly, it returns EINA_TRUE.

@fix

Test Plan: test in demo.

Reviewers: seoz, raster, bluezery

Subscribers: Hermet, jaehwan

Differential Revision: https://phab.enlightenment.org/D872
2014-08-23 01:53:08 +09:00
Daniel Kolesa c159cb2ebc update according to Eolian syntax changes 2014-08-21 09:27:32 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Stefan Schmidt be06709712 popup: Remove unused variable.
int_ret was never used here. Looks like a copy and paste error.
2014-07-18 12:07:29 +02:00
Jaeun Choi f7c43bff97 popup: code refactoring
Popup has an abnormal parent-child tree as follows, and this patch fixes it.

 - when popup is created, it creates a notify as a child and the tree is [parent - popup - notify].
 - when popup is visible, it is set as a content of notify and the tree is [parent - notify - popup].
 - when popup is hidden, the tree is reverted.

To fix this, I made an internal layout and set it as the content of notify
so that the tree remains as [parent - popup - notify - layout] all the time.
2014-07-16 22:45:29 +09:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Daniel Zaoui 1303a6dbec Eolian: fix names for elc widgets.
Even if the file names are elc_..., the class names are supposed to be
elm_...
2014-04-22 16:39:35 +03:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 71149158e2 popup: apply key binding
Summary: This patch applies key binding to elc_popup.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D731
2014-04-15 14:47:19 +09:00
Tom Hacohen 45695cda3f popup: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Daniel Zaoui 6b3cc41354 Eolian: Integration of Popup 2014-03-31 08:18:51 +03:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Amitesh Singh b22dd17eed popup: implemented widget item focus feauture.
@feature

Summary:
1. Added "item,focused" and "item,unfocused" callbacks for widget item since
  VIEW(item) is a elm layout.
2. Added sd->box into focus chain to enable the focus movement on widget items.

Test Plan: elementary_test -> popup -> "popup-center-title + items + 3 buttons"

Reviewers: seoz, woohyun

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D563
2014-02-26 01:26:02 +09:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
ChunEon Park f8d00ae0f2 elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.

Now it fixed it.
2014-01-23 20:20:43 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
WooHyun Jung 811c38145d popup: Replace focus_direction_go with focus_cycle. 2014-01-22 18:36:13 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Amitesh Singh 0be8dbcaae [elc_popup] - Added focus support on popup-base's swallow parts.
Summary:
 Currently the focus was only on popup-content and popup-action area.
New API elm_layout_content_swallow_list_get() which returns the list of
swallow parts.

Test Plan: elementary_test -to popup. click on "subpopup + X button"

Reviewers: seoz, raster, woohyun

Reviewed By: raster

CC: nirajkr, aryarockstar, kashish

Differential Revision: https://phab.enlightenment.org/D375
2013-12-28 17:33:10 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 8a0159df4f elm: long waited seasonal trailing whitespaces removal!
This is a ceremony of elementary 1.8 release!
2013-12-02 19:43:46 +09:00
Daniel Juyung Seo 56ca1c1dd7 elc_popup.c: removed unused warning. 2013-12-02 19:38:35 +09:00
abhi c2c1b87f6f [Popup] Adding elm_popup_align_set and elm_popup_align_get api
Summary: Added support for popup align set

Test Plan: elm_popup_align_set, elm_popup_align_get, elementary_test -to popup

Reviewers: seoz, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D321
2013-12-02 16:11:51 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
ChunEon Park f0371f458e Revert "popup: Added support for popup move. elm_popup_move."
This reverts commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e.

Conflicts:

	ChangeLog
	NEWS
	src/bin/test_popup.c

Sorry, Pend this to 1.8 after.
Let's think about adding this API more carefully.
2013-11-04 22:17:03 +09:00
Abhinandan Aryadipta 16b4279656 popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move

Test Plan: elm_popup_move

Reviewers: seoz, singh.amitesh, tasn, Hermet

CC: raster

Differential Revision: https://phab.enlightenment.org/D247
2013-11-03 23:03:32 +09:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Daniel Juyung Seo a5a83e7a66 elm: Removed unnecessary local variable in sizing_eval. 2013-10-17 14:27:01 +09:00
Ryuan Choi 4314560b49 popup: Change the behavior of adding or removing buttons.
Summary:
Although user should give the position of button such as button1, current elm_popup
changes button's position or style as the number of buttons while adding or removing
buttons.

So, when application developers add buttons as wrong order or removed buttons,
applications may be crashed.

This patch refactored the behavior not to change the position intended by application
developer.

Test Plan: added new test case to test_popup.

Reviewers: seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D259
2013-10-14 01:04:01 +09:00
Daniel Juyung Seo e23e151242 elc_popup.c: fixed up signal names according to the latest change.
This is a continuous job of raster's change, f9adb79740555c8e39e9d32ff2a755693dbea8dc.
2013-10-12 14:11:07 +09:00
Daniel Juyung Seo 3ff1e1859c elc_popup.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:13:14 +09:00
Carsten Haitzler 350081ff68 popup - this BREAKS THEME API. i know. it is needed:
namespacing wrong for popup theme elements. you cant sensibly have the
transparent popup test work without namespacing the style with an
extra popup/stylename. since its breaking also naming of swallows for
actionbtns wasnty namespaced. WRONG!

so yes - i know this breaks theme api. live with it. its needed. like
with elm_player.
2013-10-04 22:41:20 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Daniel Juyung Seo 38e651dee1 elc_popup.c: theck elm_layout_theme_set() return value.
- Handle successive code accordingly.
- This fixes coverity CID 1086781 and 1086782.
2013-09-09 19:16:27 +09:00
ChunEon Park 82759e54c1 elemenatry/popup - removed one redundant comment. 2013-09-04 13:44:14 +09:00
Daniel Juyung Seo 907733d004 elc_popup.c: refactoring. now popup item object is elm_layout not edje_object. 2013-09-03 11:08:41 +09:00
Daniel Juyung Seo 5d797b329e elc_popup.c: refactoring. changed local variable item to it for consistency. 2013-09-03 08:52:09 +09:00
Daniel Juyung Seo 341b8dc0f3 elc_popup.c: make popup handle general content set.
Currently application can use "default", "title,icon", "button{n}" parts for content_set but this patch allows more flexible usage of content_set.
2013-08-30 18:00:35 +09:00
Daniel Juyung Seo d740b3d3d2 elc_popup.c: small clean-ups.
1. removed unnecessary weight/align set for swallowed object.
2. fixed formatting.
2013-08-22 02:22:56 +09:00
ChunEon Park 90c0b7ad55 elementary/popup - missed adding "lang,changed" smart callback description. 2013-08-19 21:40:33 +09:00