* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary: This fix adjusts the shadow spacer elementary when we
maximize/unmaximize a window. When in a maximized state, we do not
have to reserve space for the window shadow. This partially fixes
T2578. I say partially because there is still a little bit of blank
space around a maximized window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Fix genlist crash issue of T2553 which happened by dangling pointer
access after deletion in item_select.
after item_focused callback, user call deletion and item_select din't
cover those cases.
Resolves: T2553
@fix
Test Plan: elementary_test -> genlist focus -> choose Genlist Cear on Focus
then originally crash will be happened. This patch will solve that problem.
Summary:
If x coordinate is equal to 0, key action is no more
effective as EINA_FALSE is returned. This is creating problem
in looping. Looping will be done when x < 0, but as soon as
x == 0, _key_action_move starts returning EINA_FALSE. Same
thing applies to y coordinate and other extremities.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Scroller -> Loop in X axis -> scroll left using left key(looping does not happen)
Reviewers: raster, Hermet, cedric, singh.amitesh, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2778
Title icon of popup is not getting shown.
steps to reproduce:
1. elementary_test -to "popup"
2. click "popup bottom title + text + 3 buttons"
In the test popup example, the initial parent of icon is popup.
The title_icon is reset to null while adjusting elm parent from popup
to main_layout (elm_widget_sub_object_add which calls sub_object_del of popup)
on swallowing icon to main_layout.
Resolves: T2581
@fix
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: Elementary does not support toggling of shadows on windows,
but Enlightenment does so we need to use the proper program signal for
that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fixes T2575 more accurately (combined with previous
theme adjustments). Previous code would use a spacer object to help
calculate window opaque region. This is no longer necessary due to the
previous theme changes, and now calculates window opaque region to
coincide with what Enlightenment is expecting.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fix addresses the issue of Elementary's Wayland border
theme not match close enough to E's. Now they are very much identical
with the exception of the program and signal names.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This adjusts the focus frame of Elementary applications to
more closely match what is done in X11. T2575 says that the focus
rectangle was larger than expected by a few pixels, so this slight
adjustment compensates for that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_bubble.eo and elm_button.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2827
Without this, apps can't set a GLView to be in COPY mode.
COPY mode allows the glview to "poke holes" in the backbuffer of
the window, without the need for other objects below (eg. a
transparent rectangle in COPY mode).
Summary:
Converted docs of elm_bg.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Differential Revision: https://phab.enlightenment.org/D2819
Summary:
Converted docs of elm_app_server.eo and elm_app_server_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2816
Summary:
Converted docs of elm_app_client.eo and elm_app_client_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2814
The issue was introduced in 28e6878f7cce36efae1438b5e032eb9c0878016a.
While this is a fix in the sense that it reverts to the previously
defined behaviour (defined both in docs and code), the previous
behaviour was stupid and inconsistent. So now we are back to stupid and
inconsistent.
I can't fix this further, because unfortunately, the fix requires
intrusive changes that are just too dangerous to make this late in the
release cycle. Luckily for us, the issues only surface in a very
specific case that is quite uncommon. In order to trigger the bug you
need to set a very long piece of text on an entry that has text filters
set.
Fixes T2561
@fix
In most cases the code would not crash (I can't understand why),
but in some cases Eo would complain about call stack overflow.
Yep, that's a lot of recursive calls.
The mouse_down callback was trying to cancel its triggering
event and then send again the same mouse_down event. Why? I guess
because it was easier that also having a callback for move (drag
the colorselector arrows). Ugly...
This widget is in dire need for some love.
Move enums from elm_fileselector_common.h to elm_interface_fileselector.eo
in order to make them more accessible for bindings.
Include generated elm_interface_fileselector.eo.legacy.h
into elm_fileselector_legacy.h
When the conformant is removed, elm_widget_sub_object_del is called
before calling _elm_conformant_evas_object_smart_del.
Because parent-child relation about window-conformant is unrelated,
there's no meaning elm_widget_top_get in
_elm_conformant_evas_object_smart_del.
@fix
Summary:
Drag win should use ELM_WIN_DND.
The drag win in _drag_start function was added when ELM_WIN_DND
was not supported. Now we have ELM_WIN_DND, drag win needs to
change to ELM_WIN_DND.
@fix
Reviewers: JackDanielZ, cedric, Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2784
To avoid multiple item pops, the auto pushed button deletes its clicked
callback once it is called.
However, if the auto pushed button is not supposed to be deleted in pop
callback, the clicked callback should be restored.
@fix
Elementary view that show an EFL.model and keep them synchronized
asynchronously.
The elm_view_form connects properties of a data model to different
widgets.
There is an example defined in src/examples/filemvc.c that also uses
a list view.
You can add widgets connected to properties using:
eo_do(formview, elm_view_form_widget_add("filename", _label_init(win, bxr, "File Name")));
@feature
Elementary views that show an EFL.model and keep them synchronized
asynchronously.
The elm_view_list show a tree data structure using a genlist. Each
property is seen as a different data column.
There is an example defined in fileviewlist.c.
@feature
Summary:
If User want to content set something to item area. there is no way to except elm customizing.
So i added this feature and make the toolbar item object to layout before.
Now user can content set something on item area only call "elm_object_item_part_content_set" API.
Test Plan:
Make some swallow part on toolbar edc.
and content set some layout to that swallow part to using "elm_object_item_part_content_set"
Reviewers: cedric, Hermet
Subscribers: SanghyeonLee, eagleeye, id213sin
Differential Revision: https://phab.enlightenment.org/D2777
Summary:
Its for support elm_object_item_XXXX APIs for toolbar item.
Its the pre work for toolbar item content set some layout to toolbar item layout automatically.
(without implement item_content_set with part name.)
I abandoned for check the other side of this change. but its not has problem so i reclaim this commit
and put on another commit for this. https://phab.enlightenment.org/D2777
Test Plan: To all of the action on elementary toolbar test sample.
Reviewers: cedric, Hermet
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2768
Summary:
Also using the second optional string parameter of efl_file_set as the
text format specifier.
Added string constants to represent the possible values.
Address the issue:
- Elm entry and the file interface clash on file_set.
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/
Reviewers: felipealmeida, tasn
Reviewed By: tasn
Subscribers: thiepha, raster
Differential Revision: https://phab.enlightenment.org/D2353
Summary:
Add the "autohide" property to elm_win. This property, when set to
EINA_TRUE, automatically hides the window upon a "delete,request" signal.
Create ELM_POLICY_QUIT_LAST_WINDOW_HIDDEN, a new quit policy that
automatically exit from the elm_run loop when all windows are hidden.
It is an alternative to autodel to conciliates the memory management
framework of Eo with any other memory management model the program may
be using (e.g. RAII principles of C++).
Create the auxiliary function "_elm_win_policy_quit_triggered" to check
triggering of quit policies.
The check in "smart_hide" is now necessary, since
ELM_POLICY_QUIT_LAST_WINDOW_HIDDEN can be triggered when a window
is hidden.
Create the auxiliary function "_elm_win_flush_cache_and_exit" to avoid
code repetition for exiting the elm_run loop.
Make a small update on documentation in elm_win.h to mention the new
autohide property.
@feature
Reviewers: raster, felipealmeida, cedric, tasn
Reviewed By: felipealmeida
Differential Revision: https://phab.enlightenment.org/D2751
In case of naviframe, resize_obj is not edje.
Steps to reproduce:
1. elementary_test
2. Open "Genlist 7" sample.
3. Switch focus between windows ("elementary_test" <---> "Genlist 7").
Eo Errors:
ERR<8720>:eo lib/eo/eo.c:678 _eo_call_resolve() in lib/edje/edje_object.eo.c:430: func 'edje_obj_message_signal_process' (733) could not be resolved for class 'Elm_Layout'.
@fix
Resolves: T2534
Summary:
While going through the test_focus(focus 2-> give focus to layout "entry") code found
focus should move to layout's entry instead of entry outside the layout.
Just change the entry object in callback ;)
Test Plan: elementry_test-->focus2-->give focus to layout "entry".
Reviewers: cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2611
Summary:
x and y position variable assumes values ranging from min to max.
cw, the content width is larger than max in x axis. Beacause of this
the scroller is not able to loop in rigth/bottom direction. For looping
comparision min and max values should be used instead of content width.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Subscribers: eagleeye, SanghyeonLee, singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2731
Summary:
In elm_datetime, ctxpopup does not resize
@fix
Test Plan:
1) Change the scale value in elementary_config to 2.0 (so that a better size change in the ctxpopup's can be observed)
2) Open elementary_test and then the datetime
3) Click on the first datetime field and observe the ctxpopup's arrow position and then close it
4) Click on the same datetime field again, now observe that the ctxpopup's arrow has concided with the diskselector as it wasn't resized properly.
Reviewers: raster, Hermet, shilpasingh, subodh6129, seoz
Reviewed By: shilpasingh, subodh6129
Subscribers: rajeshps, govi, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2628
Summary:
The mbe items has to get own min size to calc each items locate, box size etc...
but when first time box resize it will ignored.
It makes item wrong size issue when mbe located at some part of layout in runtime.
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2657
Patch adds connected/disconnected elm_atspi_bridge events to avoid
races between window getting focus and AT-SPI2 bus initialization.
When bridge gets connected windows will reemit all "Created",
"Activated" and "Deactivated" events with regard to window focus.
Replacing calls of evas_object_smart_callback_add/del/call
with eo_callback_add/del/call.
This will reduce the use of legacy events and callbacks lists in
smart_object which in turn will improve performance and reduce memory
use.
This reverts commit 76004dfbec84664e253babc5bf576398a5901395.
We need to change other code also to accommodate this change.
_elm_theme_set should return an enum which tells what failed.
enum {
THEME_APPLY_FAILED,
THEME_DEFAULT_SUCCESS.
THEME_APPLY_SUCCESS
};
Based on that, we decide what needs to be done.
The above code will break the layout theme if incorrect theme are passed.
It should be backported to Elm 1.14.
@fix
Summary:
If the transition scale flag is enable in edje,
this value affect the transition scale for edje.
@feature
Test Plan: test elementary_config with enventor tool
Reviewers: raster, Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2288
Summary: This is a patch to fix T2453 where elm apps in weston/E did
not display the icon on the border. This is just preliminary support
because it only tries to find the efreet desktop file based on
_elm_appname. This support Could be extended to allow efreet to search
based on window title, etc, etc.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.
1. _elm_interface_scrollable_content_region_show store wx
into scroll_interface_data without coverting mirrored_x.
fix to store wx to mirror-converted x if is_mirrored.
2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
so current mirrored_x couldn't be less then 0.
fix to check min not 0 for set return value.
3. _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));
@fix
Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.
Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric
Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2558
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: Issue: Gengrid item comes over group item on click.
Test Plan:
Run elementary test.
Open GenGrid Group. Click on any item which slightly overlap with group item.
Item comes over group item.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2589
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_gengrid_item_update perform item_unrealize/item_realize/item_place itself.
But when gengrid items are added and not calculated yet,
caller want to get item's index after execute elm_gengrid_item_update,
return value is wrong because item_place update it's position in not-updated item's x and y.
to prevent this,
if item position is already updated,
do not updates position in item place.
additionally,
I fixed gengrid item prepend wrong posiiton update.
gengrid item position start from 1 not 0, so item_position_update also must be started from 1.
@fix
Test Plan:
To test this scenario,
need to fix src/bin/test_gengrid.c first.
1. add below codes in bottom of _after_bt_clicked(line 703).
```
Elm_Object_Item *it = elm_gengrid_item_next_get(id->item);
printf("before update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
elm_gengrid_item_update(it);
printf("after update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
```
2. execute elementary_test and go to gengrid2 test.
3. add 3 items and select 2nd item then add new item by insert after.
4. you can see index is changed wrong value after item_update executed.
after add fallback code in item_update,
index is returned same value even after item_update execusion.
Reviewers: raster, Hermet, seoz, jaehwan
Subscribers: anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Elementary widgets have different behavior of using the mouse, they need to be unified.
- swipe : without checking on hold, just checking drag state.
- longpress : after longpress, _item_unhighlight(), _item_unselect() are called.
- select : when the mouse pointer leaves item area, _item_unhighlight(), _item_unselect() are called.
First, apply this commit https://phab.enlightenment.org/D2550
Test Plan: elementary_test -> list
Reviewers: seoz, Hermet, CHAN, woohyun, kimcinoo, jaehwan, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
item_unselect check it->select status, so when item highlighted but not selected,
item highlight is remaining even after unselect_cb is called.
And item_select and item_highlight are separated, but item_unselect and item_unhighlight are mixed.
so divide them, too.
This patch will solve upon problem.
Reviewers: seoz, woohyun, Hermet, CHAN, raster, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2653
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
gengrid realize/unrealize items each smart calculation if their posiiton is updated.
This concept will be occurred useless view object creation and deletion.
So instead of delete items in unrealize function, push item cache into cache list,
and pop item cache from cache list in realize function to reuse item view object
more efficiently.
the cache concept is already implemented in genlist widget and this patch is improved
item cache of genlist cache.
@feature
```
NOTICE: This patch is written under the D2561 Patch which add elm_gengrid_item_fields_update.
So it must submitted after D2561.
```
Test Plan:
I've tested below three cases,
1. tested ith this patch in elementary_test and checked all gengrid features are working properly.
2. tested with changing CACHE_MAX to another value which is set 40 in default
and checked all gengrid features are working properly.
3. tested with set it->item->nocache true, and checked cache is never generated
and checked all gengrid features are working properly.
Reviewers: raster, Hermet, seoz, jaehwan, singh.amitesh
Subscribers: eagleeye, singh.amitesh, Jaehyun
Differential Revision: https://phab.enlightenment.org/D2641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently the values in spinner change while dragging only based on
the amount of pixels dragged, this patch will enable Spinner to change value
based on the speed of dragging so that it will be more user friendly. This
will help users to alter drag values by big amounts if dragged in a good speed.
Test Plan: test_spinner.c in elementary_test
Reviewers: raster, prince.dubey, shilpasingh, cedric
Reviewed By: cedric
Subscribers: poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2659
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Looking at the base array of pixels,
the real middle of taken picture
is actually number 8 from array of 17 pixels (which starts from 0).
@fix
Reviewers: reutskiy.v.v, raster, NikaWhite, cedric
Reviewed By: NikaWhite, cedric
Differential Revision: https://phab.enlightenment.org/D2749
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
SEG_FAULT happens when the object which has selection is deleted,
and new selection is done at another object.
Reason: loss_cb is not removed when the object which has selection is deleted.
When new selection is set for new object, the loss_cb is called for deleted
object. As result, SEG_FAULT happens.
Test Plan:
Run elementary test, open Entry, do selection,
close Entry window, open Entry one more time, do selection.
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2763
When elm_config_all_flush is called, another processes should get
the config of current process instead of saved base.cfg.
so current process save the config to flush.cfg and another processes
read it when it is changed.
@fix
- Reset loss cb after invocation as it is no more needed
- When selection is set, previous owner loss cb is invoked only
if the new owner and the previous one are different.
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.
Reviewers: singh.amitesh, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2736
Summary:
When item_process is success, then we want to call _item_process_post.
Old code was confusing before.
Reviewers: raster, Hermet, SanghyeonLee
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2739
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Juyung Seo
Mike Blumenkrantz
Chris Michael
Amitesh Singh
SangHyeon Lee
Umesh Tanwar
Vivek Ellur
Jean-Philippe Andre
Lukasz Stanislawski
Tom Hacohen
Vincent Torri
woochan lee
Jaehwan Kim
Carsten Haitzler
Daniel Hirt
ChunEon Park
Daniel Kolesa
Yakov Goldberg
Daniel Zaoui
Lukasz Stanislawski
Thiep Ha
Daniel Zaoui
Avi Levin
Jaehyun Cho
Larry Jr
Vaibhav Gupta
Vitor Sousa
Anand
divyesh purohit
jiin.moon
Prince Kr Dubey
Hosang Kim
godly.talias
Youngbok Shin
Vitalii Vorobiov
Cedric BAIL