Hi all,
I found few memory related issues in elementary package when performed static analysis on it.
These issues include:
Array indices getting out of bounds, freed memory address being passed to a function as parameter, memory not getting cleaned up because of earlier return statement.
Issues details:
1. In elm_widget.c inside function elm_widget_signal_callback_del(), it is possible that freed memory address esd is passed to the sd->callback_del_func(). I think it should be data, not esd.
Moreover what if the callback frees memory for data, then the other problem is that the return value is data from the function elm_widget_signal_callback_del() which in my opinion can be a problem.
2. Inside directory src/edje_externals for files elm_genlist.c, elm_notify.c, elm_list.c, elm_thumb.c and elm_map.c, array indices can go beyound bounary.
sizeof() operator for an array of character pointers will return [number of elements in the array * size of (char*)], basically 4 times the number of elements which has been taken care in assertion inside src/edje_extenarnals
while performing assertion but has been missed in the next statement in the loop condition.
3. In file src/lib/elm_config.c inside function _elm_config_profiles_list, freeing of file iterator has been missed out.
Please review the attached patch and let me know your opinion.
Thanks.
Regards,
Rajeev
SVN revision: 63550
This engine just creates a buffer and renders everything to that buffer.
It's really useful for creating emulations of input/output and taking
window captures from them.
SVN revision: 61688
a special elm_engine var - great way to auto-generate screenies from
apps and change config/theme and everything automatically (via scripts
etc.)
SVN revision: 59185
Subject: [E-devel] [Patch] for Gettext /I18N
Mr. Govi in SISO made a patch for following description.
Detail Description:
1. If EFL/Elementary Application has i18n String with its own PO file,
then Elementary will end up looking for internal Strings at application
PO files. Passing PACKAGE name in the Elementary String Look up macro
eliminates this issue and looks for internal String from Elm.po files.
2. Macro E_(str) is used, to differentiate the elementary Strings from
commonly used #define _(str) in the applications. ( Just E ed :) )
SVN revision: 58085
* Added elm_mirrored_get/set to set the system mirrored mode
* Added elm_widget_mirrored/get/set to set each widget's mirrored mode.
* Added code to set the system mirrored mode from translations to elementary and added translations for all the rtl languages. (a trick to load according to locale).
* Future commits will include specific widgets mirrored mode handling.
Work by Aharon Hillel and Tom Hacohen.
SVN revision: 56673
Subject: [E-devel] [Patch] environment parameter - ELM_EFFECT_ENABLE
I want to add the environment parameter "ELM_EFFECT_ENABLE".
It will play a role as the enablement for the effect of all widget.
SVN revision: 56572
NB: we got textblock parts as some of our text elements, everyone
knows. They support text_class fallbacking, but what would be an
elegant solution to achive reasonable mapping for styling tags (bold,
highlight, etc)? e17 has some "blah_hilight" text classes, which imho
are ugly...
SVN revision: 54915
Edje caching primitives exposed in Elm, too, now, and stored at
config. Also, there's now a poller running for all Elm apps doing
cache flushing. All these things have configurable values, of course.
Testing config version bumping too, it should work.
SVN revision: 54851
Now working on exposing edje caching too, and having a cache dumping
poller. Patch also replaces some focus_overalay object functions,
too.
SVN revision: 54770
maybe wrapping unbounded ones into a "general" TC.
TC swithing exposes various widgets bugs WRT layouting of children
objects, we gotta fix them.
SVN revision: 54715
I'm now populating the default theme with text classes, just commit
with one for now. There can be tweakings at Elm config app's UI fonts
page, I know, but that will come later (editable preview field, font
hinting/fallback, blablabla).
WARNING: for users testing elm config, an old "rm -rf
~/.elementary/config" might be needed here, after this commit.
SVN revision: 54681
out of bounds, that is when the content is finished. In this way
the user note that the content is at the end.
All the others finger-scroll implementation (iphone,android) works this way ;)
This is configurable by the 'thumbscroll_border_friction' config value,
and by the 'ELM_THUMBSCROLL_BORDER_FRICTION' var.
0.0 means: disable the friction
0.5 is the default
1.0 means: maximum friction
I have tested this with every scroller in elm_test and seems to work
well in all the occurence, if you see somthing strange in some scroller
please let me know.
DaveMDS
SVN revision: 54170
ChunEon Park
Tom Hacohen
Aharon Hillel
Carsten Haitzler
Gustavo Lima Chaves
WooHyun Jung
Daniel Juyung Seo
Michael BOUCHAUD
WooHyun Jung
Jae Hwan Kim
Christopher Michael
Iván Briano
Davide Andreoli
Bruno Dilly