this fixes a longstanding race condition where tooltip windowss could exist with a shape rectangle due to race conditions between applying window properties (eg. alpha) and reapplying the input rect
elm_win_screen_size_get() is broken for this use case since the tooltip actually needs the full xinerama screen geometry, which is the geometry of the root window and NOT the current screen
@fix
Summary: Since explanations of tooltip's APIs are scattered in header or source code, these needs to be cleared up.
Reviewers: seoz, Hermet, woohyun, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D644
Before
elm_tooltip_move_lock_set()
elm_tooltip_move_lock_get()
After
elm_tooltip_move_freeze_push()
elm_tooltip_move_freeze_pop()
elm_tooltip_move_freeze_get()
we're likely to use the freeze rather than lock among the entire apis.
it's already discussed in the mailing list.
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
Summary: These APIs allow to enable/disable a tooltip to move with respect to mouse pointer
Test Plan: elm_tooltip_movement_lock_set(), elm_tooltip_movement_lock_get(), elementary_test -to tooltip
Reviewers: singh.amitesh, seoz, raster
Reviewed By: raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D369
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
px and py might not be set if X support is not compiled in and
ecore_x_pointer_xy_get() is not called. In that case make sure they are
not used uninitialized.
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
now if applying the orientation style is failed, it tries to apply the original style. if it fails again then default theme.
also it fixed a logic error when theme changed is happened.
It will try to apply the original style if the orientation style is invalid on theme changing.
SVN revision: 84082
First things first, I'm not sure I'm setting the right variable on
the setlocale() call, so someone more knowledgeable can look at it and fix it.
How this works, you say? Just like elm_object_text_part_set(), except now it
will pass the string given through dgettext() with the given domain (NULL
means it uses whatever the app set with textdomain()), and when changing
language with elm_language_set(), it will re-set the strings with a new
translation.
SVN revision: 64179