Carsten Haitzler
9d55fab418
entry: wrong viewport value calculation issue fix
...
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.
solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.
signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.
Reviewers: jaehwan, woohyun, seoz, Hermet, raster
CC: govi, rajeshps, thiepha
Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
5ab6a7739f
widgets - don't handle the events(key,mouse) if the object is disabled.
...
we can prevent to handle the widget events from the widget infra,
if the object is disabled.
conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
2411bf5c62
toolbar: apply key binding
...
Summary: This patch applies key binding to elm_toolbar.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D737
2014-04-15 16:07:52 +09:00
cfef2a2a12
toolbar: Initialized some internal variables.
...
This fixes coverity CID 1199658, 1199659.
2014-04-13 02:00:33 +09:00
0ccbff2cea
toolbar: Adjusted to Eo2.
2014-04-10 09:39:31 +01:00
1479664ec0
list/genlist/gengrid/toolbar: Fix - _nearest_visible_item_get() should always return an item.
...
Test Plan:
Bug:
- elementary_test->genlist/list/toolbar/gengrid Focus
- Resize the window to a state when no item is fully visible. only partially visible.
- Move Focus from outer widgets (Up/Down/Left/right buttons) to list/genlist/gengrid/toolbar.
- Focus goes away (size - 0). Reason: _nearest_visible_item_get returns NULL.
@fix
Reviewers: seoz, raster, woohyun
Reviewed By: raster
CC: seoz, nirajkr, anand.km
Differential Revision: https://phab.enlightenment.org/D696
2014-04-04 12:04:04 +09:00
d593ad85e2
toolbar: Added focus movement on widget items by mouse in.
...
Summary:
- Added a test case in "Toolbar Focus".
@feature
Test Plan: elementary_test->Toolbar Focus
Reviewers: raster, cedric, woohyun
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D665
2014-04-01 20:26:33 +09:00
9b798e7a64
Eolian: Integration of Toolbar
2014-03-31 10:23:51 +03:00
0b9a8cfd66
toolbar - fixed to use elm apis for elm objects
2014-03-25 15:57:22 +09:00
Carsten Haitzler
fe621de2c1
fix segv in toolbar item focus (new feature)
2014-03-25 15:02:13 +09:00
35ead0992d
toolbar: Check disabled status of an item in nearest visible item.
...
Summary:
Also
- corrected the code for getting the toolbar item from the list.
- added a test for it.
Test Plan: elementary_test -> "Toolbar Focus"
Reviewers: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D653
2014-03-24 15:55:46 +09:00
ffa7f989d7
toolbar: implemented widget item focus feature.
...
Summary:
1. Added "item,focused" and "item,unfocused" smart callbacks.
2. Added _elm_toolbar_focus_highlight_geometry_get().
3. Implemented elm_object_item_focus_set() and elm_object_item_focus_get().
4. Implemented elm_object_focused_item_get()
5. Ported _elm_toolbar_nearest_visible_item_get from cc827fef6.
6. Added Test Case "Toolbar Focus".
@feature
Test Plan: elementary_test->Toolbar Item Focus
Reviewers: seoz, woohyun, raster
CC: nirajkr, raster
Differential Revision: https://phab.enlightenment.org/D555
2014-03-24 00:22:32 +09:00
4e30fa3b6f
toolbar: Fixed wrong parameter for elm_widget_sub_object_del.
...
Remove the icon from the sub object list for a widget not for an edje object.
2014-03-20 02:13:41 +09:00
7460467419
Eolian: Integration of Scrollable Interface
2014-03-18 08:14:44 +02:00
e2206a1a22
Eolian: Integration of Elm Widget
2014-03-17 09:03:56 +02:00
c69cfdf4de
segment_control, toolbar: Fixed broken scale of widget item.
...
@fix. This needs to be partially backported.
2014-03-16 03:09:56 +09:00
01186b6e66
Ship missing headers, and remove wrong includes
...
elm_gen_common.h was not installed, but is needed by installed headers.
Remove dependencies on internal headers from shipped headers.
2014-03-12 14:30:21 +00:00
db23689614
access: Add smart signal "access,changed"
...
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
f8d00ae0f2
elementary - override widget translation but work also the base widget's behavior.
...
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
2014-01-23 20:20:43 +09:00
dbacb2fef9
elementary - send signal "language,changed" with one way in the widget.
...
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
aebdcff513
elementary - use the focused/unfocused string in widget defined.
...
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
54ec084e76
fix some typos in comment and description
2014-01-22 13:20:15 +09:00
db5fe2581d
elm: Removed unnecessary null check for evas_object_del.
2014-01-22 10:54:52 +09:00
a4f3074f9c
elm: Removed unnecessary null check for ecore_timer_del,
...
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
068c9a095f
toolbar: Do not check ev->string for Return key and react on space key.
...
space key works as same as Return key.
2014-01-21 19:58:10 +09:00
3379c124df
all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
...
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
5e46f2ff6d
toolbar: Check whether icon is null before sending signal
...
There are warnings when icon is null since rELM4c3e23de9e46.
2014-01-14 21:46:27 +09:00
fd5c046dfe
elm: Changed __UNUSED__ to EINA_UNUSED.
2014-01-06 23:33:57 +09:00
16f687b87a
multibuttonentry, genlist, layout, toolbar: Fixed dereference of null
...
pointers which were reported by clang builg.
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-XZo1hW.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-isAlRt.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-8Ascv8.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-gBkVuE.html#EndPath
2014-01-06 23:26:46 +09:00
2942212cb3
toolbar: Fixed dead assignment reported by clang build.
...
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-0ipfss.html#EndPath
2014-01-06 23:14:14 +09:00
e63dd3110a
elm: Unified eina critical manro to CRI.
...
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
6d71a23c3a
elm lib: removed all the unnecessary empty lines.
...
being pedantic.
2013-12-15 06:18:35 +09:00
88a8c46af3
ctxpopup, player, slideshow, spinner, toolbar, video: internal refactoring of smart event routines.
...
Now most of smart events codes look consistent.
2013-11-13 10:29:30 +09:00
5567837cf5
button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
...
Now they look more consistent.
2013-11-13 09:54:37 +09:00
2f1e1554e5
Changed Eo class names to be consistent.
...
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
d22076681b
elm: Fixed formatting about smart_event check for code consistency.
...
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho
db2d711d64
[elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
...
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
e82477ab29
elm_toolbar.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro.
2013-10-05 17:15:58 +09:00
29af5e1e43
elementary: update to new eo_parent_get/set API.
2013-09-25 13:34:27 +09:00
d461a8be05
elementary/widgets - set parents before widget constructs their body.
...
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
c5b0d63838
fixed documentation for consistency. Gets -> Get.
...
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler
59e8bc5a35
Fix elm to use key not keyname (so xmodmap works)
2013-07-31 15:16:41 +09:00
c47ef1b7fe
[access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information
2013-07-31 12:57:49 +09:00
7bbcf8a271
elm_toolbar.c: check reorder_from at the start of _items_change. reorder_from is used here and there.
...
this fixes dereference before null issue which was spotted by coverity. CID 1039999.
2013-07-06 12:26:59 +09:00
32affd3725
added callback call "scroll", "scroll,anim,start", "scroll,anim,stop", "scroll,drag,start", "scroll,drag,stop"
...
in toolar widget.
2013-07-03 13:57:17 +09:00
6cf684f02a
elm: added more "focused" and "unfocused" documentations.
...
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
2013-06-10 14:13:55 +09:00
8bfdbd2ba6
elm: all the focusable widget now emits "focused" and "unfocused" smart callbacks.
...
1. documentations, NEWS, and ChangeLog will be updated later after some more test.
2. need to check entry.
2013-06-07 01:13:37 +09:00
4355c54715
elm_toolbar.c: ELM_SAFE_FREE adoption.
...
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 21:08:50 +09:00
5f053bf79a
elm: refactoring. use more ELM_FREE_FUNC.
2013-05-23 15:54:49 +09:00
5eda949b8f
[toolbar] fixed code for verification(ecore_job_add)
...
make a pair for job event, check the event is alive before adding event.
2013-05-22 16:55:23 +09:00
ac25946a19
elm: introduce ELM_FREE_FUNC for code quality enhancement.
...
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
2013-05-22 02:24:02 +09:00
Carsten Haitzler
df9f486bdb
toolbar needs to be able to adjust better to layout
...
as part of 1.8 review... elm toolbar really should add some signals so
theme can adjust better.
2013-05-10 16:53:34 +09:00
c929b33052
elementary: properly sanitize headers order.
2013-05-03 16:07:06 +09:00
187d6bf8de
Elementary: replace eo_data_get for objects data referencing.
2013-05-01 11:04:09 +03:00
7edc0d056e
elm_toolbar.c: refactoring. reuse api return value.
2013-04-30 00:50:35 +09:00
8e85586ebe
elementary/toolbar - fix toolbar item clip problem on reordering items.
2013-04-29 18:35:32 +09:00
ff10726141
elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change
2013-04-23 20:30:15 +09:00
cb86345c1d
Scroll to highlighted item in toolbar. This is related to ed93aa20588633d36bfcdf6e3b093923be65f4d8.
2013-04-16 21:06:11 +09:00
633be421a5
[Toolbar] Add the feature for key events.
2013-04-15 14:34:15 +09:00
ba4dbce9d9
elm: enhance eina_list_free usages. use EINA_LIST_FREE if needed.
2013-04-10 20:28:35 +09:00
74b3eed5fd
elm: print the error message inside elm_widget_sub_object_add().
...
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
9636ed621c
Remove warning in toolbar
2013-03-21 15:14:23 +09:00
47e280d21b
toolbar: fix icon size not being initalized.
2013-03-20 11:57:22 +09:00
d75cb616da
Change usage of eo_do_super to the new prototype.
2013-03-18 16:15:12 +00:00
c9534bab25
toolbar: Use snprintf for elm,number,item buffer handling
...
Avoid potential buffer overflow
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-03-18 12:13:50 +00:00
e9313c9525
Fix the toolbar cannot be unselected when it's mode is ELM_OBJECT_SELECT_MODE_ALWAYS.
2013-03-08 17:21:38 +09:00
ea9fe742a0
[access][toolbar] use proper access activate callback
2013-03-07 21:33:26 +09:00
8ed79613c5
Add edje_object_message_signal_process before edje_object_size_min_restricted_calc.
...
If the min size is changed by edje signal in edc, the the function should be called before the calculation.
This commit is related to 40dc2a25c72103c3b01620830e1bde964f96b2fa
2013-03-05 16:47:07 +09:00
621775dad2
Revert this commit to fix the problem by the other method.
...
Revert "Small bug. In some case, the box cannot be proper size."
This reverts commit ca95166f9a8cb7db8c1557d75f444d76772b2176.
2013-03-05 16:27:44 +09:00
962b965563
Typo. Sync a variable name with others
2013-03-05 14:49:29 +09:00
312d0217a0
An internal layout error, on a widget set, is a CRITICAL error.
2013-03-01 23:04:31 -03:00
844b5805ff
elementary/widget - don't handle tthe resize objects in widget infrastructure. Acutally these resize objects are sub objects so we don't need to care them separately. This caused overhead in some cases(ie, theme change)
...
SVN revision: 83990
2013-02-16 13:39:59 +00:00
2a4a111289
Add the reorder effect in Toolbar.
...
SVN revision: 83936
2013-02-15 05:37:53 +00:00
cdd1eea853
Replace supported_types
...
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 83803
2013-02-10 07:52:31 +00:00
ffa9c1e793
elm: Refactoring.
...
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
2013-01-04 19:10:19 +00:00
88dac18cf7
[access] export elm_access_activate_cb_set(); and add related documentation.
...
SVN revision: 82052
2013-01-03 09:31:33 +00:00
f10fb3e115
[access] export some APIs,and remove unnecessary lines.
...
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
2012-12-23 14:50:56 +00:00
193e83033e
elm/toolbar: Fix NULL dereference waiting to happen.
...
The macro returns NULL if it->prev is not valid. So we better check if prev is
not NULL before accessing it.
SVN revision: 81144
2012-12-17 14:12:49 +00:00
e8152fd7c3
elm: refactoring. on_deletion -> delete_me.
...
1. delete_me was already there before on_deletion was used.
2. delete_me and on_deletion are same.
3. evas also has delete_me so use the same name.
4. i didn't change naviframe because it has different on_deletion usages from other widgets.
SVN revision: 80528
2012-12-08 18:17:04 +00:00
ca6994b182
Small bug. In some case, the box cannot be proper size.
...
SVN revision: 80412
2012-12-07 06:57:16 +00:00
b5c0606180
Remove the warning in toolbar
...
SVN revision: 80012
2012-12-03 07:12:38 +00:00
af28727f14
Fix 0 division
...
SVN revision: 80011
2012-12-03 07:01:22 +00:00
db9aec704d
When the toolbar is deleted, there's no need to pass the selection to next item.
...
SVN revision: 80008
2012-12-03 06:52:03 +00:00
5c98343198
We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
...
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>
SVN revision: 79668
2012-11-26 06:32:53 +00:00
add19e4e4f
Change the parameter of the elm_toolbar_item_show/bring_in. Add the scroll type.
...
SVN revision: 79333
2012-11-15 10:27:46 +00:00
06e4578483
elm elm_toolbar.c: Use correct callback function.
...
SVN revision: 79286
2012-11-14 10:49:59 +00:00
7d98e7db8d
Support the theme change about "base" in Toolbar.
...
SVN revision: 79270
2012-11-14 08:18:02 +00:00
af3ceeccfd
When toolbar is expand mode and scrolled, it's scrolled as a item.
...
SVN revision: 79265
2012-11-14 05:55:43 +00:00
2c018f252e
[toolbar] enhance access feature - add smart_activate() to access object
...
*note: the toolbar item which has menu would need access feature of menu.
SVN revision: 79262
2012-11-14 04:08:25 +00:00
7cfe5d503e
Add elm_toolbar_item_show/bring_in. It show or bring a specific item, when the toolbar can be scrolled.
...
SVN revision: 79134
2012-11-12 07:29:17 +00:00
a19e32528f
dear all, hello.
...
i would like to add access enhancement to the toolbar.
please review the attached. if there are no objections, I will commit it.
cordially,
shinwoo kim.
SVN revision: 78995
2012-11-08 09:20:37 +00:00
71d832404a
elm access: Create access object only when access mode is enabled.
...
SVN revision: 78992
2012-11-08 08:02:12 +00:00
8ef6ac7f41
[toolbar] temporary smart_event() has blocked event propagation
...
SVN revision: 78354
2012-10-23 06:07:30 +00:00
45622bb3fa
When the theme is changed, the min value should be set the min of edc newly.
...
SVN revision: 78162
2012-10-18 08:47:41 +00:00
0487a76057
Add the fitting the size of items according the viewport size.
...
If the sum of item's min is larger than the viewport size in ELM_TOOLBAR_SHRINK_EXPAND mode,
it can be scroll. And the end of the item is fitted on the end of the viewport.
SVN revision: 78156
2012-10-18 07:57:13 +00:00
f3f96e6b7e
No need code.
...
SVN revision: 78033
2012-10-16 05:29:24 +00:00
0dc4ef5aef
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
...
Subject: [E-devel] [patch][elementary] toolbar - highlighting item on
access
the current toolbar does not show highlight effect on accessibility mode.
the attached would give the highlight to toolbar item.
please review the patch and give feedback. thanks.
SVN revision: 77972
2012-10-15 05:47:02 +00:00
4e92316193
elementary: Simplifies code and removes redundant duplicated code.
...
Patch by Igor Murzov <e-mail@date.by>
SVN revision: 77396
2012-10-04 02:43:57 +00:00
01691d9e7d
fix indentation
...
SVN revision: 77177
2012-09-28 04:23:29 +00:00
052588f9d7
Add the toolbar API which expand the transverse length
...
SVN revision: 77107
2012-09-27 03:05:50 +00:00
Carsten Haitzler
ChunEon Park
Jaeun Choi
Daniel Juyung Seo
Tom Hacohen
Amitesh Singh
Daniel Zaoui
Jaehwan Kim
Jihoon Kim
Yakov Goldberg
Ryuan Choi
Daniel Juyung Seo
Jaehyun Cho
Cedric Bail
Daniel Juyung Seo
Shinwoo Kim
Hosang Kim
Daniel Willmann
Gustavo Lima Chaves
Jaehwan Kim
Shinwoo Kim
Stefan Schmidt
Cedric BAIL