enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity
efl/src/lib/ecore
History
Shinwoo Kim ad97989b28 ecore_event: initialize uninitialized variable 
Summary:
The following commit (1) made an abort (2)

(1) commit d1e4c6bab8
Author: Jean Guyomarc'h <jean@guyomarch.bzh>
Date:   Mon Aug 27 12:04:35 2018 +0900

    ecore: fix built-in event types generation

(2) abort
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)
/lib/x86_64-linux-gnu/libc.so.6(+0x8037a)
/lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)
/home/kimcinoo/install/lib/libecore.so.1(+0x237d7)
/home/kimcinoo/install/lib/libeo.so.1(efl_destructor+0x64)
/home/kimcinoo/install/lib/libeo.so.1(+0x18029)
/home/kimcinoo/install/lib/libeo.so.1(efl_unref+0x44c)
/home/kimcinoo/install/lib/libecore.so.1(+0x201f2)
/home/kimcinoo/install/lib/libecore.so.1(ecore_shutdown+0x145)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0xb85d)
/home/kimcinoo/install/lib/libcheck.so.0(srunner_run_tagged+0xa13)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0xead9)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite(+0x4ade)
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)
/home/kimcinoo/Upstream/efl/src/tests/ecore/.libs/lt-efl_app_suite

And following commit (3) fixed the abort.

(3) commit 3f306491a3
Author: Yeongjong Lee <cleanlyj@naver.com>
Date:   Mon Sep 3 15:55:13 2018 +0000

    ecore_event: fix ecore event handler iterator range

The above commit fixed the abort though, we could access uninitialized memory
and make another abort again. This would prevent such unwanted case.

Reviewers: Hermet, YOhoho, bu5hm4n, netstar

Reviewed By: netstar

Subscribers: netstar, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6970
 		2018-09-04 11:54:17 +01:00
..
CMakeLists.txt ecore: Add Efl.Interpolator class 2017-10-12 21:03:49 +09:00
Ecore.h all: Simplify definition of EAPI 2018-01-18 18:04:03 +09:00
Ecore_Common.h ecore: remove BETA thread API integration with old Efl_Future. 2018-05-01 10:39:01 -07:00
Ecore_Eo.h efl: remove old Efl_Future, Efl_Promise. 2018-05-01 10:39:01 -07:00
Ecore_Getopt.h all: Simplify definition of EAPI 2018-01-18 18:04:03 +09:00
Ecore_Legacy.h ecore: add Efl_Core.h 2017-10-27 18:51:38 -07:00
Efl_Core.h all: Simplify definition of EAPI 2018-01-18 18:04:03 +09:00
ecore.c ecore: call eina_debug_fork_reset() in fork reset function 2018-06-19 13:55:36 -04:00
ecore_alloc.c ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
ecore_anim.c ecore: remove exit_signal_received conditional from windows build 2018-07-20 15:21:28 -04:00
ecore_app.c efl: remove _MSC_VER (Visual Studio macro) usage in source code 2018-01-04 12:59:47 -08:00
ecore_event_message.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
ecore_event_message.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
ecore_event_message_handler.c ecore_event: initialize uninitialized variable 2018-09-04 11:54:17 +01:00
ecore_event_message_handler.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
ecore_events.c Revert "cxx: Fix manual code after efl_app change." 2018-03-03 13:40:33 +09:00
ecore_exe.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
ecore_exe.eo Eo docs: update for grammar and readability 2017-12-20 09:41:46 +00:00
ecore_exe_posix.c Remove all ocurrences of SPANK from our user facing errors. 2017-12-22 11:18:46 +00:00
ecore_exe_private.h ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
ecore_exe_ps3.c
…
ecore_exe_win32.c ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
ecore_getopt.c ecore_getopt: allow empty strings as parameters. 2016-10-31 19:38:22 -02:00
ecore_glib.c ecore/glib: add #ifdef guards for newly added includes 2018-06-22 15:26:44 -04:00
ecore_idle_enterer.c Revert "cxx: Fix manual code after efl_app change." 2018-03-03 13:40:33 +09:00
ecore_idle_exiter.c ecore/efl loop - refactor idle stuff to be less convluted when 2017-12-21 19:45:21 +09:00
ecore_idler.c Revert "cxx: Fix manual code after efl_app change." 2018-03-03 13:40:33 +09:00
ecore_internal.h ecore: efl_model_list_value_get will throw error when asked for out of range value. 2018-05-01 10:39:01 -07:00
ecore_job.c ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
ecore_main.c ecore/main: only update loop_time during loop iteration if the change is monotonic 2018-08-14 17:09:32 -04:00
ecore_main_common.h ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
ecore_main_timechanges.c eocre timechanges - set obj to null before deletion on stop 2018-01-05 02:34:16 +09:00
ecore_pipe.c ecore_pipe: remove null check condition and fix segfualt on Windows 2018-08-17 12:42:35 -04:00
ecore_poller.c ecore: Properly shutdown pollers 2017-12-19 13:44:33 +09:00
ecore_private.h efl: remove old Efl_Future, Efl_Promise. 2018-05-01 10:39:01 -07:00
ecore_signal.c ecore/signal: use a volatile int to prevent further SIGPIPE during shutdown 2018-07-23 17:30:56 -04:00
ecore_thread.c ecore/thread: flush main loop threads during ecore_thread_wait() 2018-06-28 18:08:45 +02:00
ecore_throttle.c
…
ecore_time.c ecore/efl loop - use efl_loop_time_get on loop obj where needed 2017-12-27 01:40:07 +09:00
ecore_timer.c efl/timer: correctly handle timer freeze during construction 2018-08-27 12:09:49 +09:00
efl_app.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_app.eo efl: Add missing event types 2018-05-19 01:42:26 +02:00
efl_appthread.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_appthread.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_exe.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_exe.eo efl: rename Efl.Exe.* -> Efl.Exe_* 2018-05-23 17:33:47 +02:00
efl_general.h ecore - a different take on efl.app class as a super class to efl.loop 2018-03-03 13:40:33 +09:00
efl_interpolator.c ecore: Add Efl.Interpolator class 2017-10-12 21:03:49 +09:00
efl_interpolator.eo ecore: Add Efl.Interpolator class 2017-10-12 21:03:49 +09:00
efl_interpolator_accelerate.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_accelerate.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_bounce.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_bounce.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_cubic_bezier.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_cubic_bezier.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_decelerate.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_decelerate.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_divisor.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_divisor.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_linear.c ecore: Add Efl.Interpolator class 2017-10-12 21:03:49 +09:00
efl_interpolator_linear.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_sinusoidal.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_sinusoidal.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_interpolator_spring.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_interpolator_spring.eo Efl.Interpolator_* (from Efl.Interpolator.*) 2018-04-24 09:04:02 -07:00
efl_io_buffered_stream.c ecore: force close during invalidate of Efl.Io.Buffered_Stream. 2018-05-24 16:02:18 -07:00
efl_io_buffered_stream.eo efl: Add missing event types 2018-05-19 01:42:26 +02:00
efl_io_closer_fd.c ecore: move close_on_destructor to close_on_invalidate as that describe the behavior best. 2018-05-01 10:39:01 -07:00
efl_io_closer_fd.eo ecore: move close_on_destructor to close_on_invalidate as that describe the behavior best. 2018-05-01 10:39:01 -07:00
efl_io_copier.c ecore: during shutdown their is no need to delay anything. 2018-05-24 16:02:21 -07:00
efl_io_copier.eo docs: Fix typos in API reference doc and comments. 2018-08-31 17:45:31 +09:00
efl_io_file.c ecore: move close_on_destructor to close_on_invalidate as that describe the behavior best. 2018-05-01 10:39:01 -07:00
efl_io_file.eo ecore: move close_on_destructor to close_on_invalidate as that describe the behavior best. 2018-05-01 10:39:01 -07:00
efl_io_positioner_fd.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_io_positioner_fd.eo Efl.Io.*_Fd (from Efl.Io.*.Fd) 2018-04-24 09:03:41 -07:00
efl_io_reader_fd.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_io_reader_fd.eo Efl.Io.*_Fd (from Efl.Io.*.Fd) 2018-04-24 09:03:41 -07:00
efl_io_sizer_fd.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_io_sizer_fd.eo Efl.Io.*_Fd (from Efl.Io.*.Fd) 2018-04-24 09:03:41 -07:00
efl_io_stderr.c eolian: remove all duplicated affix 2016-11-28 11:35:27 -08:00
efl_io_stderr.eo Efl.Loop_* (from Efl.Loop.*) 2018-04-24 09:04:03 -07:00
efl_io_stdin.c eolian: remove all duplicated affix 2016-11-28 11:35:27 -08:00
efl_io_stdin.eo Efl.Loop_* (from Efl.Loop.*) 2018-04-24 09:04:03 -07:00
efl_io_stdout.c eolian: remove all duplicated affix 2016-11-28 11:35:27 -08:00
efl_io_stdout.eo Efl.Loop_* (from Efl.Loop.*) 2018-04-24 09:04:03 -07:00
efl_io_writer_fd.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_io_writer_fd.eo Efl.Io.*_Fd (from Efl.Io.*.Fd) 2018-04-24 09:03:41 -07:00
efl_loop.c ecore: first invalidate the loop and its children, then destroy all the object capability. 2018-05-24 16:02:18 -07:00
efl_loop.eo docs: Fix typos and some wrong expressions in API reference doc. 2018-08-30 14:01:21 +09:00
efl_loop_consumer.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_loop_consumer.eo Efl.Loop_* (from Efl.Loop.*) 2018-04-24 09:04:03 -07:00
efl_loop_fd.c ecore: logically do the disconnection from the main loop API during invalidate. 2018-05-01 10:39:01 -07:00
efl_loop_fd.eo efl: Add missing event types 2018-05-19 01:42:26 +02:00
efl_loop_handler.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_loop_handler.eo docs: Fix typos and some wrong expressions in API reference doc. 2018-08-30 14:01:21 +09:00
efl_loop_message.c ecore - begin moving data into the efl loop data in the object 2017-12-15 14:16:53 +09:00
efl_loop_message.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_loop_message_future.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_loop_message_future.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_loop_message_future_handler.c efl loop - make param as unused to remove warning 2018-01-02 15:11:06 +09:00
efl_loop_message_future_handler.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_loop_message_handler.c remove elgacy ecore event usage in futures that limit to mainloop only 2017-12-28 02:24:12 +09:00
efl_loop_message_handler.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_loop_timer.eo efl: Add missing event types 2018-05-19 01:42:26 +02:00
efl_model_accessor_view.c efl: replace efl_del with efl_unref for cases where no parent exists 2018-03-20 17:20:57 -07:00
efl_model_accessor_view_private.h ecore: Add efl_model_copmosite_selection model 2017-09-07 14:23:51 +09:00
efl_model_composite.c ecore: add a class to factorize efl.model.composite. 2018-04-30 14:21:11 -07:00
efl_model_composite.eo ecore: add a class to factorize efl.model.composite. 2018-04-30 14:21:11 -07:00
efl_model_composite_boolean.c ecore: refactor and migrate efl.model.composite.boolean to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_composite_boolean.eo ecore: refactor and migrate efl.model.composite.boolean to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_composite_boolean_children.eo ecore: refactor and migrate efl.model.composite.boolean to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_composite_selection.c ecore: refactor and migrate efl.model.composite.selection to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_composite_selection.eo efl: Add missing event types 2018-05-19 01:42:26 +02:00
efl_model_composite_selection_children.eo ecore: refactor and migrate efl.model.composite.selection to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_container.c efl: update Efl.Model to properly propagate EFL_MODEL_EVENT_CHILDREN_COUNT_CHANGED. 2018-05-01 10:39:01 -07:00
efl_model_container.eo ecore: refactor and migrate efl.model.container to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_container_item.c ecore: refactor and migrate efl.model.container to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_container_item.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_model_container_private.h ecore: refactor and migrate efl.model.container to the new efl.model API. 2018-04-30 14:21:11 -07:00
efl_model_item.c efl: update Efl.Model to properly propagate EFL_MODEL_EVENT_CHILDREN_COUNT_CHANGED. 2018-05-01 10:39:01 -07:00
efl_model_item.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_task.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_task.eo efl: rename Efl.Task.* -> Efl.Task_* 2018-05-23 17:33:47 +02:00
efl_thread.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_thread.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00
efl_threadio.c eolian gen: enable constness generation on property getter impls 2018-04-17 20:31:55 +02:00
efl_threadio.eo eolian: second batch of unused import removals 2018-05-13 18:13:12 +02:00