enlightenment
/
eflxx
7
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

From: Daniel Juyung Seo <juyung.seo@samsung.com> 

Subject: [E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs

I added tree feature support to
elm_genlist_item_insert_before/after() APIs.

This patch assumes that the previous patch, '[E-devel] [Patch] Tree
support
for elm_genlist_item_prepend() API.', is already applied to upstream.
So this patch does not include the changes of the previous patch.

This patch includes API break. I added parent parameter.
To support genlist group index feature, it should have a parent
parameter
like elm_genlist_item_append/prepend() do.
Raster already agreed to this API break.
I or my co-worker will introduce genlist group index feature today.
But for the reviewer's convenience, I separated this patch.

- 001.elm_genlist.patch.txt
   Patch for src/lib/elm_genlist.c
- 002.elm_genlist.patch.txt
   Patch for src/lib/Elementary.h.in, src/bin/test_genlist.c
- 003.elm_genlist.patch.txt
   Due to API break, I changes other EFL libraries and applications on SVN. 



SVN revision: 55869
This commit is contained in:
Daniel Juyung Seo 2011-01-05 06:03:43 +00:00 committed by Carsten Haitzler
parent 4c579dd1b9
commit 7c9844d341
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
elementaryxx/include/elementaryxx/GenList.h
View File

@ -384,8 +384,8 @@ private:
#if 0
/* operations to add items */
EAPI Elm_Genlist_Item *elm_genlist_item_prepend(Evas_Object *obj, const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *parent, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data);
EAPI Elm_Genlist_Item *elm_genlist_item_insert_before(Evas_Object *obj, const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *before, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data);
EAPI Elm_Genlist_Item *elm_genlist_item_insert_after(Evas_Object *obj, const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *after, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data);
EAPI Elm_Genlist_Item *elm_genlist_item_insert_before(Evas_Object *obj, const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *parent, Elm_Genlist_Item *before, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data);
EAPI Elm_Genlist_Item *elm_genlist_item_insert_after(Evas_Object *obj, const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *parent, Elm_Genlist_Item *after, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data);
/* operations to retrieve existing items */

2
elementaryxx/src/GenList.cpp
View File

@ -216,6 +216,7 @@ GenListItem *GenList::insertInternal (GenListColumnConstructor *construction, Ge
gli = elm_genlist_item_insert_before (o, &mModel->mGLIC,
construction /* item data */,
opItem ? opItem->mItem : NULL /* parent */,
NULL,
flags,
GenList::gl_sel/* func */,
selection /* func data */);
@ -225,6 +226,7 @@ GenListItem *GenList::insertInternal (GenListColumnConstructor *construction, Ge
gli = elm_genlist_item_insert_after (o, &mModel->mGLIC,
construction /* item data */,
opItem ? opItem->mItem : NULL /* parent */,
NULL,
flags,
GenList::gl_sel/* func */,
selection /* func data */);