move config/ to data/config/

Summary:
this is part of the datadir distribution, it should not be in a different
directory than the rest of the datadir distribution

the gnu coding standards (https://www.gnu.org/prep/standards/html_node/Directory-Variables.html)
define 'datadir' as:

The directory for installing idiosyncratic read-only architecture-independent
data files for this program. This is usually the same place as ‘datarootdir’,
but we use the two separate variables so that you can move these program-specific
files without altering the location for Info files, man pages, etc.

This should normally be /usr/local/share, but write it as $(datarootdir).
(If you are using Autoconf, write it as ‘@datadir@’.)

The definition of ‘datadir’ is the same for all packages, so you should install your
data in a subdirectory thereof. Most packages install their data under $(datadir)/package-name/.

while this text has no clear requirement or suggestion for a corresponding
repository layout, projects typically employ a certain consistency in their
repository layout both for ease of maintenance and ease of learning for new
contributors.

this project has both a data/ directory, which contains the datadir distribution,
as well as the config/ directory, which also contains the datadir distribution.
this complicates matters both for active maintainers/developers who must
remember that the repository and build tree layouts have this exception,
and for new contributors who will initially be confused by this exception

other well-organized open source projects, such as wayland, have chosen to not
use a data/ directory. these projects have the datadir distribution in the base
directory of the repositor, which is a fine practice as it maintains consistency
for the project since all the files for the datadir distribution are in the same
directory.

by applying this patch, the project will move towards a more easily readable and
learnable layout. current and future developers will no longer need to wonder why
this directory is outside of the data/ directory, and anyone attempting to reference
these files from the source/build trees will be able to do so more easily

ref D6013

Reviewers: cedric, raster, bu5hm4n

Reviewed By: raster

Subscribers: devilhorns

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D6154
devs/bu5hm4n/bugfixing
Mike Blumenkrantz 4 years ago committed by Marcel Hollerbach
parent dd2436ec69
commit 05d3f2d393
  1. 0
      data/config/default/e.src
  2. 0
      data/config/default/e_bindings.src
  3. 0
      data/config/default/enlightenment-default.png
  4. 0
      data/config/default/meson.build
  5. 0
      data/config/default/profile.desktop
  6. 0
      data/config/meson.build
  7. 0
      data/config/mobile/e.src
  8. 0
      data/config/mobile/e_bindings.src
  9. 0
      data/config/mobile/enlightenment-mobile.png
  10. 0
      data/config/mobile/meson.build
  11. 0
      data/config/mobile/module.battery.src
  12. 0
      data/config/mobile/module.conf.src
  13. 0
      data/config/mobile/profile.desktop
  14. 0
      data/config/profile.src
  15. 0
      data/config/standard/e.src
  16. 0
      data/config/standard/e_bindings.src
  17. 0
      data/config/standard/enlightenment-standard.png
  18. 0
      data/config/standard/meson.build
  19. 0
      data/config/standard/module.battery.src
  20. 0
      data/config/standard/module.conf.src
  21. 0
      data/config/standard/module.cpufreq.src
  22. 0
      data/config/standard/module.fileman.src
  23. 0
      data/config/standard/module.ibar.src
  24. 0
      data/config/standard/module.ibox.src
  25. 0
      data/config/standard/module.pager.src
  26. 0
      data/config/standard/module.temperature.src
  27. 0
      data/config/standard/profile.desktop
  28. 0
      data/config/tiling/e.src
  29. 0
      data/config/tiling/e_bindings.src
  30. 0
      data/config/tiling/enlightenment-tiling.png
  31. 0
      data/config/tiling/meson.build
  32. 0
      data/config/tiling/module.battery.src
  33. 0
      data/config/tiling/module.conf.src
  34. 0
      data/config/tiling/module.cpufreq.src
  35. 0
      data/config/tiling/module.fileman.src
  36. 0
      data/config/tiling/module.ibar.src
  37. 0
      data/config/tiling/module.ibox.src
  38. 0
      data/config/tiling/module.pager.src
  39. 0
      data/config/tiling/module.temperature.src
  40. 0
      data/config/tiling/module.tiling.src
  41. 0
      data/config/tiling/profile.desktop
  42. 2
      meson.build

Before

Width:  |  Height:  |  Size: 6.7 KiB

After

Width:  |  Height:  |  Size: 6.7 KiB

Before

Width:  |  Height:  |  Size: 3.0 KiB

After

Width:  |  Height:  |  Size: 3.0 KiB

Before

Width:  |  Height:  |  Size: 1.8 KiB

After

Width:  |  Height:  |  Size: 1.8 KiB

Before

Width:  |  Height:  |  Size: 1.3 KiB

After

Width:  |  Height:  |  Size: 1.3 KiB

@ -346,9 +346,9 @@ subdir('src/bin')
subdir('src/modules')
subdir('config')
subdir('data/backgrounds')
subdir('data/config')
subdir('data/desktop')
subdir('data/etc')
subdir('data/favorites')

Loading…
Cancel
Save