From 11beb0649cccd297dbe66fde4ba0a28afbd94e6b Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 23 Jan 2013 10:01:26 +0000 Subject: [PATCH] same leak as previous in import dialog SVN revision: 83139 --- ChangeLog | 1 + NEWS | 1 + src/bin/e_import_dialog.c | 6 +++++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6210aa4fa..492c2daf2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,6 +3,7 @@ * module error dialog is no longer remembered across restarts * fixed small leak in efm when performing dnd onto mounted drive icon * fixed small leak in e_import_config_dialog_show during failure case + * fixed small leak in e_import_dialog_show during failure case 2013-01-22 Mike Blumenkrantz diff --git a/NEWS b/NEWS index 76c6f772e..a60a57b1e 100644 --- a/NEWS +++ b/NEWS @@ -114,3 +114,4 @@ Fixes: * module error dialog is no longer remembered across restarts * fix small leak in efm when performing dnd onto mounted drive icon * fixed small leak in e_import_config_dialog_show during failure case + * fixed small leak in e_import_dialog_show during failure case diff --git a/src/bin/e_import_dialog.c b/src/bin/e_import_dialog.c index 2c109a3ab..ac2255145 100644 --- a/src/bin/e_import_dialog.c +++ b/src/bin/e_import_dialog.c @@ -145,7 +145,11 @@ e_import_dialog_show(E_Container *con, const char *dev, const char *path, Ecore_ if (!id) return NULL; dia = e_dialog_new(con, "E", "_import_fsel_dialog"); - if (!dia) return NULL; + if (!dia) + { + e_object_del(E_OBJECT(id)); + return NULL; + } e_dialog_resizable_set(dia, 1); dia->data = id;