module error dialog is no longer remembered across restarts: this caused a crash for me on two different machines, so there's another strange and related bug here somewhere...

SVN revision: 83126
This commit is contained in:
Mike Blumenkrantz 2013-01-23 08:25:54 +00:00
parent ef2d139967
commit 18bd14af98
3 changed files with 8 additions and 3 deletions

View File

@ -1,3 +1,7 @@
2013-01-23 Mike Blumenkrantz
* module error dialog is no longer remembered across restarts
2013-01-22 Mike Blumenkrantz
* No longer build illume edj files

1
NEWS
View File

@ -110,3 +110,4 @@ Fixes:
* Reuse notifications for mixer and battery modules.
* fixed gadget dragging on desktop near screen edges
* fixed bug where "don't composite fullscreen windows" option would cause some windows to stop appearing
* module error dialog is no longer remembered across restarts

View File

@ -696,9 +696,8 @@ _e_module_dialog_disable_show(const char *title, const char *body, E_Module *m)
char buf[4096];
printf("MODULE ERR:\n%s\n", body);
dia = e_dialog_new(e_container_current_get(e_manager_current_get()),
"E", "_module_unload_dialog");
if (!dia) return;
dia = e_dialog_new(NULL, "E", "_module_unload_dialog");
EINA_SAFETY_ON_NULL_RETURN(dia);
snprintf(buf, sizeof(buf), "%s<br>%s", body,
_("What action should be taken with this module?<br>"));
@ -709,6 +708,7 @@ _e_module_dialog_disable_show(const char *title, const char *body, E_Module *m)
e_dialog_button_add(dia, _("Unload"), NULL, _e_module_cb_dialog_disable, m);
e_dialog_button_add(dia, _("Keep"), NULL, NULL, NULL);
e_win_centered_set(dia->win, 1);
dia->win->state.no_remember = 1;
e_dialog_show(dia);
}