e env var config fialog - fix potential null access

coverity complained. it's right. fix CID 1428807
This commit is contained in:
Carsten Haitzler 2020-05-14 12:18:00 +01:00
parent 4c52048f09
commit 344a6acc36
1 changed files with 14 additions and 7 deletions

View File

@ -150,17 +150,24 @@ _sel_cb(void *data)
static const char *
_env_text(E_Config_Env_Var *evr)
{
static Eina_Slstr *text;
static Eina_Slstr *text = "";
char *val;
val = strndup(evr->val, 64);
if (evr->val) val = strndup(evr->val, 64);
else val = strdup("");
if (strlen(evr->val) > 64)
text = eina_slstr_printf("%s=%s...", evr->var, val);
if (val)
{
if (strlen(evr->val) > 64)
text = eina_slstr_printf("%s=%s...", evr->var, val);
else
text = eina_slstr_printf("%s=%s", evr->var, val);
free(val);
}
else
text = eina_slstr_printf("%s=%s", evr->var, val);
free(val);
{
text = eina_slstr_printf("%s", evr->var);
}
return text;
}