From 3a82001c8b101c6bdb5a4f46f8fa0eb59a63ab40 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 13 Dec 2012 12:50:58 +0000 Subject: [PATCH] fix leak in client menu generation SVN revision: 80836 --- src/bin/e_int_menus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/e_int_menus.c b/src/bin/e_int_menus.c index b58bb949b..cd4b45a45 100644 --- a/src/bin/e_int_menus.c +++ b/src/bin/e_int_menus.c @@ -1158,7 +1158,6 @@ _e_int_menus_clients_add_by_class(Eina_List *borders, E_Menu *m) E_Menu_Item *mi = NULL; char *class = NULL; - class = strdup(""); EINA_LIST_FOREACH(borders, l, bd) { if ((bd->iconic) && @@ -1168,7 +1167,7 @@ _e_int_menus_clients_add_by_class(Eina_List *borders, E_Menu *m) continue; } - if (((strcmp(class, bd->client.icccm.class) != 0) && + if (((e_util_strcmp(class, bd->client.icccm.class)) && e_config->clientlist_separate_with != E_CLIENTLIST_GROUP_SEP_NONE)) { if (e_config->clientlist_separate_with == E_CLIENTLIST_GROUP_SEP_MENU) @@ -1198,6 +1197,7 @@ _e_int_menus_clients_add_by_class(Eina_List *borders, E_Menu *m) e_menu_item_submenu_set(mi, subm); _e_int_menus_clients_menu_add_iconified(ico, m); + free(class); } static void