From 4c2db4342a1e0505eedf57ebde0894e1c8f330f7 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Mon, 17 Feb 2014 11:59:27 -0500 Subject: [PATCH] bugfix: unref client when removing from exec if exec is deleted fixes a race condition where client would never be freed when closing lots of windows simultaneously --- src/bin/e_client.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bin/e_client.c b/src/bin/e_client.c index 7667c055d..9cee266e2 100644 --- a/src/bin/e_client.c +++ b/src/bin/e_client.c @@ -488,7 +488,11 @@ _e_client_del(E_Client *ec) if (ec->exe_inst->phony && (eina_list_count(ec->exe_inst->clients) == 1)) e_exec_phony_del(ec->exe_inst); else - ec->exe_inst->clients = eina_list_remove(ec->exe_inst->clients, ec); + { + ec->exe_inst->clients = eina_list_remove(ec->exe_inst->clients, ec); + if (ec->exe_inst->deleted) + e_object_unref(E_OBJECT(ec)); + } ec->exe_inst = NULL; }