enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 25 Pull Requests 2 Projects Releases Wiki Activity

fix menu race condition crash related to screen edges 

previously, this conditional would be called on most new submenus, even if the submenu's parent item was the previous item and its menu hadn't been set yet. hours of small mouse movements revealed that this should never be called when the parent item has not yet been set
This commit is contained in:
Mike Blumenkrantz 2013-12-01 11:30:43 -05:00 committed by Cedric BAIL
parent 0141251d50
commit 5d54123dc5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/e_menu.c
View File

@ -1005,7 +1005,7 @@ e_menu_item_active_set(E_Menu_Item *mi, int active)
e_menu_item_active_set(pmi, 0);
if (_e_prev_active_menu_item && (mi != _e_prev_active_menu_item))
{
if (_e_prev_active_menu_item != mi->menu->parent_item)
if (mi->menu->parent_item && (_e_prev_active_menu_item != mi->menu->parent_item))
_e_menu_submenu_deactivate(_e_prev_active_menu_item);
}
mi->active = 1;