From 61cc1351faf7fca1630cd18d09b3bb2fc5576e6b Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Mon, 8 Jul 2019 15:12:38 +0100 Subject: [PATCH] acpi - add an error dialog for systems with acpi but no acpid we never told users before. we should. this would sovle some issues i've seen of people saying that closing the lid doesn't work with e and they didn't install acpid (even though packages often recommend it). this improves usability. --- src/bin/e_acpi.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/bin/e_acpi.c b/src/bin/e_acpi.c index e8e5fcfa2..f98890985 100644 --- a/src/bin/e_acpi.c +++ b/src/bin/e_acpi.c @@ -132,7 +132,16 @@ e_acpi_init(void) E_EVENT_ACPI = ecore_event_type_new(); /* check for running acpid */ - if (!ecore_file_exists("/var/run/acpid.socket")) return 1; + if (!ecore_file_exists("/var/run/acpid.socket")) + { + if (ecore_file_exists("/proc/acpi")) + e_util_dialog_show(_("Error"), + _("You seem to have an ACPI based system, but
" + "acpid does not seem to be running or
" + "contactable. Perhaps enable the acpid
" + "service on your system?")); + return 1; + } /* try to connect to acpid socket */ _e_acpid = ecore_con_server_connect(ECORE_CON_LOCAL_SYSTEM,