enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

efm - make some comment notes for exec verify

This commit is contained in:
Carsten Haitzler 2020-05-30 21:56:08 +01:00
parent 3fdd7d3118
commit 7062c0fa4c
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/fileman/e_fwin.c
View File

@ -1521,6 +1521,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
case E_FWIN_EXEC_DIRECT:
snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(fwin->cur_page->fm_obj), ici->file);
// XXX: exec verify buf
if (fwin->win)
e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
else if (fwin->zone)
@ -1529,6 +1530,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
case E_FWIN_EXEC_SH:
snprintf(buf, sizeof(buf), "/bin/sh %s", e_util_filename_escape(ici->file));
// XXX: exec verify buf
if (fwin->win)
e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
else if (fwin->zone)
@ -1537,6 +1539,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
case E_FWIN_EXEC_TERMINAL_DIRECT:
snprintf(buf, sizeof(buf), "%s %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file));
// XXX: exec verify buf
if (fwin->win)
e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
else if (fwin->zone)
@ -1545,6 +1548,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
case E_FWIN_EXEC_TERMINAL_SH:
snprintf(buf, sizeof(buf), "%s /bin/sh %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file));
// XXX: exec verify buf
if (fwin->win)
e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
else if (fwin->zone)
@ -1553,6 +1557,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
case E_FWIN_EXEC_DESKTOP:
snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(page->fm_obj), ici->file);
// XXX: exec verify buf
desktop = efreet_desktop_new(buf);
if (desktop)
{

4
src/modules/fileman/e_mod_dbus.c
View File

@ -244,7 +244,7 @@ _e_fileman_dbus_daemon_open_file_cb(const Eldbus_Service_Interface *iface EINA_U
errmsg = "couldn't open desktop file";
goto error;
}
// XXX: exec verify real_file
e_exec(zone, desktop, NULL, NULL, NULL);
efreet_desktop_free(desktop);
goto end;
@ -252,11 +252,13 @@ _e_fileman_dbus_daemon_open_file_cb(const Eldbus_Service_Interface *iface EINA_U
else if ((strcmp(mime, "application/x-executable") == 0) ||
ecore_file_can_exec(param_file))
{
// XXX: exec verify param_file
e_exec(zone, NULL, param_file, NULL, NULL);
goto end;
}
else if (_mime_shell_script_check(mime))
{
// XXX: exec verify param_file
Eina_Strbuf *b = eina_strbuf_new();
const char *shell = getenv("SHELL");
if (!shell)