enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

tiling config -fix use after free crash on change of config

This commit is contained in:
Carsten Haitzler 2019-08-09 14:13:17 +01:00
parent 2158d46dba
commit 758894bc9c
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/modules/tiling/e_mod_config.c
View File

@ -228,7 +228,7 @@ _basic_apply_data(E_Config_Dialog *cfd EINA_UNUSED,
E_Config_Dialog_Data *cfdata)
{
struct _Config_vdesk *vd;
Eina_List *l;
Eina_List *l, *vdesks;
tiling_g.config->tile_dialogs = cfdata->config.tile_dialogs;
tiling_g.config->show_titles = cfdata->config.show_titles;
@ -265,10 +265,7 @@ _basic_apply_data(E_Config_Dialog *cfd EINA_UNUSED,
}
}
EINA_LIST_FREE(tiling_g.config->vdesks, vd)
{
free(vd);
}
vdesks = tiling_g.config->vdesks;
tiling_g.config->vdesks = NULL;
for (l = cfdata->config.vdesks; l; l = l->next)
@ -291,6 +288,11 @@ _basic_apply_data(E_Config_Dialog *cfd EINA_UNUSED,
e_tiling_update_conf();
EINA_LIST_FREE(vdesks, vd)
{
free(vd);
}
e_config_save_queue();
return EINA_TRUE;