From 8344b79020c7fe63d85cb64b5a49a57114331e76 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Tue, 22 Mar 2016 12:01:04 -0400 Subject: [PATCH] use eina_streq for e_util_binding_match() comparisons optimizes what is likely a stringshare comparison as well as avoiding null derefs CID 1191998 --- src/bin/e_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/e_utils.c b/src/bin/e_utils.c index add4d1f46..63c337e49 100644 --- a/src/bin/e_utils.c +++ b/src/bin/e_utils.c @@ -1176,7 +1176,7 @@ e_util_binding_match(const Eina_List *bindlist, Ecore_Event_Key *ev, unsigned in { if (bi != skip) { - if ((bi->modifiers == mod) && (!strcmp(bi->key, ev->key))) + if ((bi->modifiers == mod) && eina_streq(bi->key, ev->key)) return bi; } if (num) (*num)++;