Revert "Set close on exec for stdin"

This reverts commit 40e8bb044c.

EFL master solves this properly
EFL stable currently has a bug that solves this accidentally

so there's a window of about 3 commits in git where it's a problem,
and nobody should run those commits in production :)

This fix caused some problems when restarting E, as stdin would
cloexec and then the following startup would try to set cloexec
on an invalid fd and generate an err that generated a cri because
of an invalid log domain.

Someone should probably figure out the log domain thing.
This commit is contained in:
Derek Foreman 2017-09-26 14:19:24 -05:00
parent f4f08ee99a
commit a85a602a39
1 changed files with 0 additions and 10 deletions

View File

@ -233,16 +233,6 @@ main(int argc, char **argv)
#endif
TS("Begin Startup");
/* When running as a wayland compositor, if a child process has
* access to stdin it can issue some pretty sketchy ioctl()s
* and mess with the console. So let's just set close_on_exec.
* It may be better to fix this in EFL's ecore_exe_run in some
* way, but it will be a while until a stable EFL release has
* it sorted...
*/
eina_file_close_on_exec(STDIN_FILENO, EINA_TRUE);
/* </HULK SMASH> */
/* trap deadly bug signals and allow some form of sane recovery */
/* or ability to gdb attach and debug at this point - better than your */
/* wm/desktop vanishing and not knowing what happened */