enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 25 Pull Requests 2 Projects Releases Wiki Activity

make bgpreview create vdesk config dialog on mouse up instead of mouse down 

if the option to always raise a window on click is enabled, clicking an internal
window in a way which creates another window will cause a race condition where
the clicked window is raised over the newly created window

there is no obvious policy-wide solution to this issue, but making this change
at least resolves the issue in question

fix T3210
This commit is contained in:
Mike Blumenkrantz 2016-02-25 14:00:01 -05:00
parent b1a5eeeb0c
commit a8ecf89bd6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/e_widget_bgpreview.c
View File

@ -123,10 +123,10 @@ e_widget_bgpreview_desk_configurable_set(Evas_Object *obj, Eina_Bool enable)
enable = !!enable;
if (dd->configurable == enable) return;
if (enable)
evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_UP,
_e_wid_desk_cb_config, dd);
else
evas_object_event_callback_del_full(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
evas_object_event_callback_del_full(dd->icon, EVAS_CALLBACK_MOUSE_UP,
_e_wid_desk_cb_config, dd);
dd->configurable = enable;
}
@ -267,7 +267,7 @@ _e_wid_reconfigure(E_Widget_Data *wd)
edje_object_part_swallow(dd->icon, "e.swallow.content", dd->live);
dd->configurable = EINA_TRUE;
evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_UP,
_e_wid_desk_cb_config, dd);
evas_object_show(dd->icon);
evas_object_data_set(dd->icon, "desk_data", dd);