From b7d8881e1e59cf175ce481bd2ed49c8d158777a6 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 23 Jan 2013 10:00:09 +0000 Subject: [PATCH] backport previous import config dialog leak fix SVN revision: 83138 --- ChangeLog | 1 + NEWS | 1 + src/bin/e_import_config_dialog.c | 6 +++++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 65d960478..7faca427d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ * module error dialog is no longer remembered across restarts * fix small leak in efm when performing dnd onto mounted drive icon + * fixed small leak in e_import_config_dialog_show during failure case 2013-01-22 Massimo Maiurana diff --git a/NEWS b/NEWS index f2cd86848..531635add 100644 --- a/NEWS +++ b/NEWS @@ -39,3 +39,4 @@ Fixes: * fixed bug where "don't composite fullscreen windows" option would cause some windows to stop appearing * module error dialog is no longer remembered across restarts * fix small leak in efm when performing dnd onto mounted drive icon + * fixed small leak in e_import_config_dialog_show during failure case diff --git a/src/bin/e_import_config_dialog.c b/src/bin/e_import_config_dialog.c index 4e7670ee1..0f7dfee59 100644 --- a/src/bin/e_import_config_dialog.c +++ b/src/bin/e_import_config_dialog.c @@ -449,7 +449,11 @@ e_import_config_dialog_show(E_Container *con, const char *path, Ecore_End_Cb ok, if (!import) return NULL; dia = e_dialog_new(con, "E", "_import_config_dialog"); - if (!dia) return NULL; + if (!dia) + { + e_object_del(E_OBJECT(import)); + return NULL; + } e_dialog_resizable_set(dia, 1); e_dialog_title_set(dia, _("Import Settings..."));