Summary: Found this with a quick valgrind session. For paths that are not directories, if we fail the `ecore_file_is_dir` condition memory will not be freed. The change is to use the default e_path freeing function. Test Plan: Run enlightenment in valgrind. It should no longer show a mem leak like below. ``` ==6912== 8 bytes in 1 blocks are definitely lost in loss record 186 of 5,940 ==6912== at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==6912== by 0x4D8574: e_path_dir_list_get (e_path.c:326) ==6912== by 0x4D1BA4: e_module_init.part.0 (e_module.c:183) ==6912== by 0x4D1DA8: e_module_init (e_module.c:153) ==6912== by 0x4371ED: main (e_main.c:868) ``` Reviewers: zmike Subscribers: cedric, seoz Differential Revision: https://phab.enlightenment.org/D3356devs/stanluk/a11y
parent
d32392760a
commit
bbe3173906
1 changed files with 3 additions and 3 deletions
Loading…
Reference in new issue