enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

always throw error in wl_surface.commit for unparented popup surfaces

This commit is contained in:
Mike Blumenkrantz 2018-01-08 11:52:58 -05:00
parent 5cc08794ee
commit beb6922a17
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/bin/e_comp_wl.c
View File

@ -1341,6 +1341,14 @@ _e_comp_wl_surface_state_commit(E_Client *ec, E_Comp_Wl_Surface_State *state)
first = !e_pixmap_usable_get(e_comp_x_client_pixmap_get(ec));
#endif
if (e_client_util_is_popup(ec) && (!ec->parent))
{
wl_resource_post_error(ec->comp_data->surface,
WL_DISPLAY_ERROR_INVALID_OBJECT,
"Popup requires a parent shell surface before commit");
return;
}
ec->comp_data->in_commit = 1;
if (ec->ignored && ec->comp_data->shell.surface)
{