diff --git a/TODO b/TODO index 9e96f31f1..e78f860e0 100644 --- a/TODO +++ b/TODO @@ -32,8 +32,6 @@ ISSUES: * virtual desktops need an overhaul. hacked in waay too quickly. * virtual desktops need fixing to work with zones properly * gadman gadget menu needs icons :) -* valgrind e17 and address anything it complains about that is valid -* valgrind complains of dropshadow (accessing freed data) - i knwo what it is, but it shouldnt be happening. will fix. diff --git a/src/bin/e_main.c b/src/bin/e_main.c index adac9da30..c27d8df84 100644 --- a/src/bin/e_main.c +++ b/src/bin/e_main.c @@ -59,12 +59,15 @@ main(int argc, char **argv) int after_restart = 0; char buf[1024]; char *s; +#if 0 /* install the signal handlers. */ struct sigaction sigsegv_action; - sigsegv_action.sa_sigaction=&e_sigseg_act; - sigsegv_action.sa_flags=0; + + sigsegv_action.sa_sigaction = &e_sigseg_act; + sigsegv_action.sa_flags = 0; + sigemptyset(&sigsegv_action.sa_mask); sigaction(SIGSEGV, &sigsegv_action, NULL); - +#endif /* for debugging by redirecting stdout of e to a log file to tail */ setvbuf(stdout, NULL, _IONBF, 0); diff --git a/src/modules/battery/e_mod_main.c b/src/modules/battery/e_mod_main.c index d1dbea681..2f3d702ab 100644 --- a/src/modules/battery/e_mod_main.c +++ b/src/modules/battery/e_mod_main.c @@ -121,7 +121,7 @@ _battery_new() #undef D #define T Config_Face #define D conf_face_edd - E_CONFIG_VAL(D, T, enabled, INT); + E_CONFIG_VAL(D, T, enabled, UCHAR); conf_edd = E_CONFIG_DD_NEW("Battery_Config", Config); #undef T diff --git a/src/modules/clock/e_mod_main.c b/src/modules/clock/e_mod_main.c index 07bb14a75..00e8e7934 100644 --- a/src/modules/clock/e_mod_main.c +++ b/src/modules/clock/e_mod_main.c @@ -114,7 +114,7 @@ _clock_new() #undef D #define T Config_Face #define D conf_face_edd - E_CONFIG_VAL(D, T, enabled, INT); + E_CONFIG_VAL(D, T, enabled, UCHAR); conf_edd = E_CONFIG_DD_NEW("Clock_Config", Config); #undef T diff --git a/src/modules/dropshadow/e_mod_main.c b/src/modules/dropshadow/e_mod_main.c index 132093f2a..d773ccfe8 100644 --- a/src/modules/dropshadow/e_mod_main.c +++ b/src/modules/dropshadow/e_mod_main.c @@ -1631,6 +1631,6 @@ _ds_shstore_object_set(Shstore *st, Evas_Object *o) static void _ds_object_unset(Evas_Object *o) { - evas_object_image_size_set(o, 0, 0); evas_object_image_data_set(o, NULL); + evas_object_image_size_set(o, 0, 0); } diff --git a/src/modules/ibar/e_mod_main.c b/src/modules/ibar/e_mod_main.c index 212d09632..ff299d474 100644 --- a/src/modules/ibar/e_mod_main.c +++ b/src/modules/ibar/e_mod_main.c @@ -180,7 +180,7 @@ _ibar_new() #undef D #define T Config_Bar #define D conf_bar_edd - E_CONFIG_VAL(D, T, enabled, INT); + E_CONFIG_VAL(D, T, enabled, UCHAR); conf_edd = E_CONFIG_DD_NEW("IBar_Config", Config); #undef T diff --git a/src/modules/pager/e_mod_main.c b/src/modules/pager/e_mod_main.c index b0f5f3e58..a3ed87427 100644 --- a/src/modules/pager/e_mod_main.c +++ b/src/modules/pager/e_mod_main.c @@ -160,9 +160,9 @@ _pager_new() #undef D #define T Config_Face #define D _conf_face_edd - E_CONFIG_VAL(D, T, enabled, INT); - E_CONFIG_VAL(D, T, scale, INT); - E_CONFIG_VAL(D, T, resize, INT); + E_CONFIG_VAL(D, T, enabled, UCHAR); + E_CONFIG_VAL(D, T, scale, UCHAR); + E_CONFIG_VAL(D, T, resize, UCHAR); _conf_edd = E_CONFIG_DD_NEW("Pager_Config", Config); #undef T diff --git a/src/modules/temperature/e_mod_main.c b/src/modules/temperature/e_mod_main.c index 345e91c9f..c28e5645d 100644 --- a/src/modules/temperature/e_mod_main.c +++ b/src/modules/temperature/e_mod_main.c @@ -117,7 +117,7 @@ _temperature_new() #undef D #define T Config_Face #define D conf_face_edd - E_CONFIG_VAL(D, T, enabled, INT); + E_CONFIG_VAL(D, T, enabled, UCHAR); conf_edd = E_CONFIG_DD_NEW("Temperature_Config", Config); #undef T