maybe I'm wrong, but this looks like a guaranteed null deref

SVN revision: 72126
This commit is contained in:
Mike Blumenkrantz 2012-06-14 12:21:58 +00:00
parent 9c710ad86a
commit d6effc2043
1 changed files with 2 additions and 13 deletions

View File

@ -5194,21 +5194,10 @@ _e_border_cb_window_stack_request(void *data __UNUSED__,
if (e_stolen_win_get(e->win)) return ECORE_CALLBACK_PASS_ON; if (e_stolen_win_get(e->win)) return ECORE_CALLBACK_PASS_ON;
if (!e_util_container_window_find(e->win)) if (!e_util_container_window_find(e->win))
{ {
Eina_List *l;
E_Border *tmp;
if (e->detail == ECORE_X_WINDOW_STACK_ABOVE) if (e->detail == ECORE_X_WINDOW_STACK_ABOVE)
{ ecore_x_window_raise(e->win);
EINA_LIST_FOREACH(bd->client.e.state.video_child, l, tmp)
if (tmp) ecore_x_window_raise(tmp->win);
ecore_x_window_raise(e->win);
}
else if (e->detail == ECORE_X_WINDOW_STACK_BELOW) else if (e->detail == ECORE_X_WINDOW_STACK_BELOW)
{ ecore_x_window_lower(e->win);
EINA_LIST_FOREACH(bd->client.e.state.video_child, l, tmp)
if (tmp) ecore_x_window_lower(tmp->win);
ecore_x_window_lower(e->win);
}
} }
return ECORE_CALLBACK_PASS_ON; return ECORE_CALLBACK_PASS_ON;
} }