enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 25 Pull Requests 2 Projects Releases Wiki Activity

From: Hyojin Kim <hyojina.kim@gmail.com> 

Subject: [E-devel] font, size list are not enabled even though custom
font is checked.

I'm a beginner of EFL. and this is my first bug reporting.
If I don't follow the rule of bug reporting, please correct me.

* Bug
In font settings, I checked "Enable Custom Font Classes" and set a
font and
size.
then, when I enter font settings again, font and size list are disabled.

* Cause
cfdata->cur_enabled is always 0 in _basic_create_widgets().

*Solution
 set cfdata->cur_enabled as 1 in _basic_init_data_fill().
 
 Please review attached before,after files.
 If the changes are not perfect, please give me feedback.
 
 


SVN revision: 79308
This commit is contained in:
Hyojin Kim 2012-11-15 03:49:33 +00:00 committed by Carsten Haitzler
parent 93c36f8ff2
commit e8398b2057
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/modules/conf_theme/e_int_config_fonts.c
View File

@ -444,15 +444,16 @@ _basic_create_widgets(E_Config_Dialog *cfd, Evas *evas, E_Config_Dialog_Data *cf
e_widget_size_min_set(ob, 100, 200);
e_widget_framelist_object_append(of, ob);
e_widget_table_object_append(ot, of, 1, 1, 1, 1, 1, 1, 1, 1);
e_widget_disabled_set(cfdata->gui.font_list, !cfdata->cur_enabled);
e_widget_disabled_set(cfdata->gui.size_list, !cfdata->cur_enabled);
ob =
e_widget_font_preview_add(evas, _("Basic preview text: 123: 我的天空！"));
ob = e_widget_font_preview_add
(evas, _("Basic preview text: 123: 我的天空！"));
cfdata->gui.preview = ob;
e_widget_table_object_append(ot, ob, 0, 2, 2, 1, 1, 0, 1, 0);
_basic_init_data_fill(cfdata);
e_widget_disabled_set(cfdata->gui.font_list, !cfdata->cur_enabled);
e_widget_disabled_set(cfdata->gui.size_list, !cfdata->cur_enabled);
e_dialog_resizable_set(cfd->dia, 1);
return ot;
}
@ -519,7 +520,10 @@ _basic_init_data_fill(E_Config_Dialog_Data *cfdata)
else if (!strcmp(efd->text_class, "default"))
e_widget_check_checked_set(ob, 0);
else
e_widget_check_checked_set(ob, 1);
{
e_widget_check_checked_set(ob, 1);
cfdata->cur_enabled = 1;
}
/* Populate font list (Select current font) */
_font_list_load(cfdata, init_font);