enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 25 Pull Requests 2 Projects Releases Wiki Activity

Some fileman work: 

* Free a list which had a FIXME note, looks like no need to free data
 * Fix a bug when right clicking on directories (do a NULL check)


SVN revision: 20475
This commit is contained in:
stffrdhrn 2006-02-15 14:18:06 +00:00 committed by stffrdhrn
parent 16bec1dd21
commit f70e439aea
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/bin/e_fileman_mime.c
View File

@ -264,9 +264,12 @@ e_fm_mime_get_from_list(Evas_List *files)
E_Fm_Mime_Entry *entry;
Evas_List *l;
if (files == NULL)
return NULL;
file = (E_Fm_Mime_Entry *)files->data;
entry = file->mime;
for(l = files->next; l; l = l->next)
for (l = files->next; l; l = l->next)
{
E_Fm_Mime_Entry *eme;

18
src/bin/e_fileman_smart.c
View File

@ -2257,7 +2257,6 @@ _e_fm_icon_mouse_up_cb(void *data, Evas *e, Evas_Object *obj, void *event_info)
E_Fm_Icon *icon;
Evas_Event_Mouse_Up *ev;
Evas_List *l;
Evas_List *mimes = NULL;
ev = event_info;
icon = data;
@ -2314,8 +2313,21 @@ _e_fm_icon_mouse_up_cb(void *data, Evas *e, Evas_Object *obj, void *event_info)
/* the xdnd_drop will handle this case */
if(icon->sd->drag.doing)
break;
/* FIXME if it isnt null free the list */
icon->sd->operation.files = NULL;
/* Free file list before recreating */
while (icon->sd->operation.files)
{
E_Fm_File *file;
file = icon->sd->operation.files->data;
icon->sd->operation.files = evas_list_remove_list(
icon->sd->operation.files, icon->sd->operation.files);
/*
* FIXME: should this be freed, it looks like we just need to free the list here?
* e_object_del(E_OBJECT(file));
*/
}
/* set the operation files equal to the selected icons */
for(l = icon->sd->selection.icons; l; l = l->next)
{