From f8ddfd3245c0e12e2b61d07af2913869aebb96da Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Sat, 29 Oct 2016 11:36:48 -0400 Subject: [PATCH] fix use after free when renaming a bryce fix T4784 --- src/bin/e_bryce.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/bin/e_bryce.c b/src/bin/e_bryce.c index 53266647d..bf5c9be9a 100644 --- a/src/bin/e_bryce.c +++ b/src/bin/e_bryce.c @@ -452,10 +452,12 @@ _bryce_rename(Bryce *b, int num) snprintf(buf, sizeof(buf), "__bryce%s", name); snprintf(buf2, sizeof(buf2), "__bryce%s_%d", name, num); e_gadget_site_rename(buf, buf2); + if (b->version >= 2) + { + snprintf(buf, sizeof(buf), "%s_%u", name, num); + eina_stringshare_replace(&b->name, buf); + } free(name); - if (b->version < 2) return; - snprintf(buf, sizeof(buf), "%s_%u", name, num); - eina_stringshare_replace(&b->name, buf); } static void