Commit Graph

289 Commits

Author SHA1 Message Date
Christopher Michael 43c493f090 E17 - Fixup some compiler warnings
gadcon: Fix 'limit' may be used uninitialized.
        Fix formatting in some places.
menus:  Fix several variables may be used uninitialized warnings.
comp:   Add UNUSED where needed.
        Fix formatting in some places.



SVN revision: 58467
2011-04-08 05:31:47 +00:00
Hannes Janetzek f94a3d9040 e17: fix segv in client list menu with sort by class
SVN revision: 57766
2011-03-15 16:33:46 +00:00
Gustavo Sverzut Barbieri 6f2213cb25 convert init/shutdown to EINTERN, move some to _update().
Do not abuse the concept of e_*_init(), make them call-once and those
that needed multiple call are renamed to e_*_update(). To make sure
convert them to EINTERN so the symbols are not exported.

Actually I guess too much is exported as EAPI while they should be
EINTERN, but that would require manual investigation, while this patch
was basically created with sed + grep.



SVN revision: 54795
2010-11-22 15:21:32 +00:00
Miculcy Brian 748d4e182f Show a better name for shelfs, shelfs are now named as "Shelf bottom", "Shelf bottom_left", etc. I guess _E_Shelf->const char *name can be removed now... Anyone against that? :)
SVN revision: 51929
2010-09-06 17:38:18 +00:00
Miculcy Brian a9918f881b Fix for missing menu entries...
SVN revision: 51753
2010-08-30 15:14:25 +00:00
Christopher Michael f467fa997c Fix compiler warning about integer from pointer without cast.
SVN revision: 51588
2010-08-23 20:47:01 +00:00
Lucas De Marchi 63f07459a0 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Christopher Michael 08b96de3c8 Fix lots of compiler warnings about unused paramters & functions.
SVN revision: 51308
2010-08-18 18:15:31 +00:00
Lucas De Marchi 6638a10e20 FORMATTING
* Remove vim modelines:
 find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
 find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;

* Remove leading blank lines:
 find . -name '*.[cxh]' -exec sed -i '/./,$!d'

If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0



SVN revision: 50816
2010-08-04 16:57:32 +00:00
Carsten Haitzler e89dbf0415 fix shelf add to add to right zone.
SVN revision: 50795
2010-08-04 01:25:57 +00:00
Cedric BAIL c6a118d738 * e: remove warning due to Ecore API change.
SVN revision: 49833
2010-06-24 16:19:12 +00:00
Carsten Haitzler 8db097c619 fix dnd from menu bug.
SVN revision: 49302
2010-05-29 14:55:47 +00:00
Gustavo Sverzut Barbieri 367b87e1cb don't show "Lost Windows" on main menu. It is already in "Windows" submenu.
This makes the first level of the menu simpler. If you want the "Lost
windows" on the main menu back, make sure you remove the "if (dat)"
branch inside _e_int_menus_clients_pre_cb() otherwise you get duplicated menus.



SVN revision: 49199
2010-05-25 18:22:48 +00:00
Gustavo Sverzut Barbieri eade689804 set dat as client's sub menu so it does not show the title.
SVN revision: 49198
2010-05-25 18:00:36 +00:00
Hannes Janetzek 5d71e61b91 dont skip windows that should only not be shown in taskbar.
SVN revision: 48785
2010-05-12 18:33:05 +00:00
Sebastian Dransfeld fadcb01bcb efreet: better naming
SVN revision: 48034
2010-04-15 19:21:03 +00:00
Sebastian Dransfeld bf86564fea TODO++
SVN revision: 47514
2010-03-27 19:58:44 +00:00
Christopher Michael 3bc257bf8d Fix up formatting.
SVN revision: 46625
2010-02-27 22:51:19 +00:00
Daniel Kolesa fd63280f2e Merge configmenu from extras with Configuration Panel module(after discussion with raster). For this, I added API to disable or enable any augmentation point from any module and later enable it again. Thanks to this merge, you can have configuration panel categories directly in main menu, replacing old items like Gadgets in that submenu. You can easily switch to old style from Advanced->Configuration Panel, if the module is disabled it is the old style of course. Also I removed configmenu from emodules when it is not needed anymore.
SVN revision: 46587
2010-02-27 17:04:55 +00:00
Cedric BAIL f8c05999e4 * e: Cleanup use of Eina data structure.
Patch from Peter van de Werken <pwerken-e@a-eskwadraat.nl>.


SVN revision: 41916
2009-08-21 15:08:49 +00:00
Cedric BAIL c82f19e052 * e: Remove all reference to Evas_Data and move to Eina_Bool.
SVN revision: 41080
2009-06-17 13:46:54 +00:00
Gustavo Sverzut Barbieri be6a6ba639 improvements to e_border positioning.
* e_border_center() will center window in a better way, accounting
   the shelves/panels instead of just centering on the screen. This is
   better and most noticeable if screens are small and a big shelf on
   just one edge.

 * e_border_move_without_border(), e_border_resize_without_border()
   and e_border_move_resize_without_border() will assume the given
   values do not acount border/decorations (client_inset) and will do
   automatically. As stated in documentation, this is specially useful
   when it is a new client and thus have no decorations when it is
   positioned, when decorations are added window would be placed at
   wrong position. One can try this by adding efwin window overflowing
   the bottom-right corner, closing it and when reopen fileman would
   try to make it inside the screen, this would not work well with
   part of the window still being outside.

 * e_win_move(), e_win_resize() and e_win_move_resize() will now use
   new e_border functions.



SVN revision: 40307
2009-04-23 02:24:59 +00:00
Gustavo Sverzut Barbieri 8b22937367 usability: sort menus, always keep same order.
maybe this is too much for a feature freeze phase, but this is
annoying for users, sometimes your menu looks one way, sometimes
another. Now it will always look the same, alphabetically ordered.

If it breaks anything before Monday revert!


SVN revision: 40205
2009-04-19 06:21:35 +00:00
Gustavo Sverzut Barbieri 3b733a2081 fix some problems with eina_hash usage.
SVN revision: 40204
2009-04-19 05:18:01 +00:00
Iván Briano e5478eb0e3 Don't leak.
SVN revision: 40100
2009-04-16 04:48:46 +00:00
Gustavo Sverzut Barbieri e0040cefb9 major cleanup of path creation to $DATADIR and $HOME/.e/e
This cleanup replaces snprintf() usage with specific calls, they have
the benefit of being cleaner (so easier to grep), typing less and also
marginal speed up compared to the other (specially concat_static),
although those are rarely used in critical paths.

I'm testing it for some time and seems to not break anything, but let
me know of any problem. If you can review the patch and try to spot
incorrect names, please do.




SVN revision: 40014
2009-04-13 14:56:38 +00:00
Viktor Kojouharov 9a303630ae shorten some strings
SVN revision: 39886
2009-04-06 21:22:12 +00:00
Carsten Haitzler 7657cb3644 lost windows.. back!
SVN revision: 39652
2009-03-23 13:04:02 +00:00
Gustavo Sverzut Barbieri 811f193535 use safe version to free sub menus.
SVN revision: 39648
2009-03-23 11:46:14 +00:00
Carsten Haitzler bf37a93c2e more leak--!
SVN revision: 39646
2009-03-23 10:19:13 +00:00
Carsten Haitzler 2e36885899 nuke segv in fm and leaks in menus.
SVN revision: 39644
2009-03-23 09:36:11 +00:00
Christopher Michael be28e1636b Formatting & Whitespace fixes. Also, don't segfault when removing menus.
SVN revision: 39497
2009-03-15 19:12:50 +00:00
Davide Andreoli eb2d1db1dc Icon rename finished. Now we have a fully compliant icon theme :)
now I'm going to fix E-MODULE-EXTRA...


SVN revision: 39495
2009-03-15 17:41:46 +00:00
Hannes Janetzek 2422e04b20 delete submenus of main menu afterwards. this fixes the issue with borders
not getting unreffed


SVN revision: 39494
2009-03-15 17:06:18 +00:00
Davide Andreoli 3d41cbb20d More icon works, this commit include changes to the icons on the desktop.
You will probably loose desktop icons until you get a fresh profile. Or you can edit the
.desktop files in .e/e/fileman/favorites (new icons name are: user-desktop, user-home, computer and user-temp)

Sorry for bothering... the next commit should be the last ;)



SVN revision: 39419
2009-03-08 23:09:48 +00:00
Davide Andreoli 49fecd25b7 More icons renamed
SVN revision: 39400
2009-03-06 22:18:15 +00:00
Davide Andreoli 1101c58d9f more icons renamed
SVN revision: 39396
2009-03-06 19:17:12 +00:00
Davide Andreoli fc66fc7c73 More icon renamed, for more info look at default.edc (around line 22650). I'm keeping there a mapping between e old names and fdo ones.
SVN revision: 39374
2009-03-05 02:39:50 +00:00
Davide Andreoli 3d669d1177 * Rename the new function:
e_util_menu_item_fdo_icon_set to e_util_menu_item_theme_icon_set
As it looks for icons in e theme AND in fdo icon themes.
* Use the new function everywere instead of e_util_menu_item_edje_icon_set,
that is now marked as DEPRECATED

You should not see any difference with this commit. With the next few commit I'm
going to rename all the icons in the theme following fdo standard. I will not change
any icons, just rename them to match fdo ones.



SVN revision: 39370
2009-03-04 20:46:05 +00:00
Gustavo Sverzut Barbieri cb629d5a56 More FDO icons work, now able to choose which one has precedence.
SVN revision: 39355
2009-03-04 02:56:27 +00:00
Cedric BAIL db419867dd * estickies,
* etk,
	* PROTO/exalt,
	* E-MODULES-EXTRA/diskio,
	* E-MODULES-EXTRA/drawer,
	* E-MODULES-EXTRA/penguins,
	* E-MODULES-EXTRA/slideshow,
	* E-MODULES-EXTRA/mail,
	* E-MODULES-EXTRA/forecasts,
	* E-MODULES-EXTRA/iiirk,
	* E-MODULES-EXTRA/places,
	* e,
	* ewl,
	* ecore,
	* elitaire,
	* entrance,
	* e_dbus,
	* efreet: Here we go, move from Ecore_List to Eina_List.

	NOTE: This patch is huge, I did test it a lot, and I hope nothing is
	broken. But if you think something change after this commit, please
	contact me ASAP.


SVN revision: 39200
2009-02-25 11:03:47 +00:00
Gustavo Sverzut Barbieri 05402668aa e_menu: recursively delete children menus.
e_menu had this behaviour that submenus were not deleted
automatically, relying on the parent menu to hook to post_deactivate
and then delete them.

This was good because maybe you don't want to delete these children,
you might want to reuse them sometime.

But it ended that nobody was using this feature, and worse: most use
cases were failing to delete these children, causing memory leak.

This commit changes the default behaviour and thus remove all the
existing code that was replicating such work. If one want the old
behavior, just call e_menu_item_submenu_set(mi, NULL) and it will be
unbounded from the parent.

If you experience any problems with that, try adding some printf()
before _e_menu_free() and _e_menu_item_free() and print some relevant
information like m->category and m->header.title or mi->label in order
to figure out the problematic menu.



SVN revision: 38528
2009-01-10 07:02:32 +00:00
Cedric BAIL 773d102291 This commit is huge. I did test it a lot on my computer, and it run fine here.
But is so big i fear i could have broken some piece of code. So report any wrong
behaviour to me (cedric on #edevelop).

So moving e17 and efreet to eina_hash. With a little efreet API break so they
must come together.


SVN revision: 38185
2008-12-17 15:33:43 +00:00
Christopher Michael 8010e152c1 If syscon module is not loaded (since it's broken right now), then we don't
need an additional separator at the bottom of the menu.



SVN revision: 37858
2008-11-29 18:47:29 +00:00
Carsten Haitzler 5a29e1f6b5 syscon module added - provides a system entry in main menu (build in one gone
now). syscon has a poup with buttons (configurale) that offer all the
logout/reboot etc. stuff. also able to extend with more items or inline them
into the theme too.

not complete. need config for being able to extend the syscon popup (and use
it) and no gui config for configuring what should appear and how it should
look. possibly theme should have custon elements for the ones curently using
button + icon look. also no keyboard control.



SVN revision: 37797
2008-11-25 08:05:58 +00:00
Carsten Haitzler b273fe10db use settings insetad of configuration. shorter.
SVN revision: 37742
2008-11-22 08:42:54 +00:00
Sebastian Dransfeld 92ff3dab37 Fix callback for list sorting.
SVN revision: 37202
2008-10-27 07:33:21 +00:00
Cedric BAIL 1087de2397 Remove Evas list and replace them with Eina list.
No change for ->next and ->data access right now, as the patch is already
big enough.



SVN revision: 36962
2008-10-22 11:49:33 +00:00
Chidambar Zinnoury 57c6606f50 We may want to use the about icon for the about menu item.
SVN revision: 36839
2008-10-20 07:52:22 +00:00
Chidambar Zinnoury 4a85950f88 Add preview of desktops' background on main menu's desktop selector.
Yes, I know, this one is purely for eye-candiness, but there was some empty space only waiting for us to fill it... :D


SVN revision: 36792
2008-10-18 18:43:09 +00:00