$ mkdir /home/test/EMPTY
$ mkdir /home/test/FULL
$ cd /home/test
$ ln -s EMPTY link
Now move (with EFM) the 'FULL' folder to the 'link' (without
opening it), and 'FULL' diseappear.
As the symlink points directly to 'EMPTY', we have not the
full path. So the 'FULL' directory is moved to ~/, instead
of the desired dest.
Here is a quickly-made a patch.
SVN revision: 76591
The rename() function deletes dest file if it exists,
so there is no overwrite handling. Instead of
testing a rename() and if it fails creating a task
to copy-delete the file, we directly create this
task, which handles overwrite.
Patch by Maxime Villard (rustyBSD)
SVN revision: 75489
we chmod the created symlink. It's useless, because
we use stat() which gives st_mode of pointed file/folder,
and then we use chmod(), which follows symlink; so we
are chmoding a file to the same permissions it had
before.
Patch by Maxile Villard
SVN revision: 75435
during the copy, the file can be accessed by users.
See http://cwe.mitre.org/data/definitions/689.html
So we apply the access rights after the creation of
the dest file.
Patch by Maxime Villard
SVN revision: 74284
when copying symlinks, it creates a symlink to the
destination but with the name of the pointed file/folder.
It causes problems, ex: we can't copy two symlinks
pointing to the same file, because they will have the
same name.
Also when copying, if it's a link, we fill the destination
in the struct task, then, after we check overwrite with
_e_fm_op_handle_overwrite()
Here is a patch which corrects this.
Patch by Maxime Villard (rustyBSD), modified a bit by me (add 2 free() + formatting)
SVN revision: 74264
Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
1. Gadcon sities:
-- 'E_Gadcon_Site' enum to list all available sities,
-- added 'is_site' callback for distinguish gadcon sities,
-- 'e_gadcon_site_is_*' helpers written to use in gadget modules,
-- gadcon config dialogs modified to show only gadgets that appropriate
to selected gadcon site,
-- all gadget modules updated for using new callback.
When callback is not provided in module, then gadget can be used in
any gadcon site.
2. Filemanager:
-- added error icon to unexisting path dialog,
-- added callback 'func.abort' to 'E_Fm2_Op_Registry_Entry' to specify
abort operation sequence (if not provided, then operation is not
cancelable),
-- added parameter to 'e_fm2_op_registry_entry_add' to specify abort
method on construct 'E_Fm2_Op_Registry_Entry' or make non-cancelable
operation if this function is not provided,
-- added 'e_fm2_operation_abort' call to cancel efm2 operation,
-- added method '_e_fm2_operation_abort_internal' that represent efm2
default handler of operation cancelling,
-- 'done' and 'total' fields of 'E_Fm2_Op_Registry_Entry' changed to
off_t type, also all message handlers modified to work with it
(to show progress for large files correctly),
-- improved file operation progress processing,
-- added cancel button to operation progress gadget in filemanager window,
-- added delete file glyph to operation progress gadget,
-- improved status message for efm2 operation progress.
3. Filemanager slave:
-- fixed critical bug in message handling via stdin/stdout,
-- fixed critical bug in removing task from list,
-- improved 'E_FM_OP_ABORT' handling,
-- fix rollback counting on moving files.
4. Fileman_opinfo module:
-- a new theme writed: status string and gadget for view operation status
in summary and detail modes,
-- summary mode: operation glyph, state message, progressbar, abort button,
-- detail mode: all for summary + from filename, to filename,
-- summary/detailed button works as trigger,
-- added source of module theme and used images.
4. Pathbar module:
-- non-critical fix, just for safety.
Also patch contains several minor updates to serve main task.
SVN revision: 41224
* e_fm_op : report sizes (done and total) now refer to the whole task, not the single file
* e_fwin : better operation monitor label (and add a delay on delete)
SVN revision: 39787
This huge commit will add e_fm2_op_registry, a central place that will
store all on-going operations. You will find that it will report when
operations are added, remove and when they change, for example when
they change progress.
Please notice that the recommended way to present information is to
add listener to specific entries, as opposed to use
E_EVENT_FM_OP_REGISTRY_CHANGED since it will be called immediately and
you do not have to filter which entry is being changed.
Entries will be associated with the e_fm object that originated
it. With that one can get the Ecore_X_Window and request the window to
be raised from somewhere else (ie: gadman/gadget). If object is
deleted (ie: window is closed), the pointer will be made NULL and it
will be a "windowless operation".
TO DO (I need someone to do those):
- e_fwin: windows should present on-going operations as an overlay,
Dave Andreolli already started such work, it's just a matter of
using the new infrastructure.
- create a new gadget that present all on-going operations and maybe
a history. It would be nice to show the e_fwin of if the entry is
clicked, as well as a cancel button and a progress bar. See
"places" module, make them similar.
SVN revision: 39541
Symbolic links are handled similar to "paste". If you "Copy" you'll
get the "Link" menu item that will create a symbolic link instead of
real copying the file.
Drag and Drop works similarly, use "Alt" in order to get a popup and
select "Link" there.
Toma: we do miss icons for it!
Mekius & Ptomaine: please review as I'm not that familiar with e_fm_op.c
SVN revision: 39170
* simplify eina_stringshare usage with _eina_stringshare_replace();
* do not modify the string in stringshare as in e_fm2_parent_go();
* use custom_theme_content instead of custom_theme in e_fm2_custom_theme_content_set().
Hopefully this will break nothing, but further analysis if it's
leaking strings in the stringshare should be done.
SVN revision: 38559
* Fix for URI escpaing.
* Add the ability for EFM to recognize different drop actions from other FMs. The reverse soon to come :)
* Add option to disable HAL device icons on the desktop.
* Performing an operation on multiple files will now be done in a single slave process instead of many.
More to come before and after GSOC :) If you see him in the channel, give him a high five because he's finally helped pull EFM out of the crapper :P
SVN revision: 35432
Mike Blumenkrantz
Maxime Villard
Vincent Torri
Carsten Haitzler
Cedric BAIL
Rafael Antognolli
Christopher Michael
Lucas De Marchi
Gustavo Sverzut Barbieri
semernin
Davide Andreoli
Nicholas Hughart
Sebastian Dransfeld
ptomaine