this is an easy format string attack vector which serves no purpose
that I can fathom. the commit log where it was added it also made
no mention of this, as it was done in a seemingly-unrelated feature
addition
this removes the per desktop profile config and replaces it with a
per-screen one that is tied to a specific display so it is far more
logical than per desktop. this allows e to set up different scaling
per screen for apps that use elementary for example via this derived
profile.
this of course is slightly problematic for e itself since it now uses
elm - as this will cause e to go kind-of-crazy with differing profiles
as it fights with itself and elm if 2 screens have different profiles.
this requires elm to be fixed to allow custom profiles per window.
this also currently won't switch profile of a window when you
reconfigure screens.
@feature
xx
huge fustercluck commit because there wasn't really a way to separate out the changes. better to just rip it all out at once.
* compositor and window management completely rewritten. this was the goal for E19, but it pretty much required everything existing to be scrapped since it wasn't optimized, streamlined, or sensible. now instead of having the compositor strapped to the window manager like an outboard motor, it's housed more like an automobile engine.
** various comp structs have been merged into other places (eg. E_Comp_Zone is now just part of E_Zone where applicable), leading to a large deduplication of attributes
** awful E_Comp_Win is totally dead, having been replaced with e_comp_object smart objects which work just like normal canvas objects
** protocol-specific window management and compositor functionality is now kept exclusively in backend files
** e_pixmap api provides generic client finding and rendering api
** screen/xinerama screens are now provided directly by compositor on startup and re-set on change
** e_comp_render_update finally replaced with eina_tiler
** wayland compositor no longer creates X windows
** compositor e_layout removed entirely
* e_container is gone. this was made unnecessary in E18, but I kept it to avoid having too much code churn in one release. its sole purpose was to catch some events and handle window stacking, both of which are now just done by the compositor infra
* e_manager is just for screensaver and keybind stuff now, possibly remove later?
* e_border is gone along with a lot of its api. e_client has replaced it, and e_client has been rewritten completely; some parts may be similar, but the design now relies upon having a functional compositor
** window configuration/focus functions are all removed. all windows are now managed solely with evas_object_X functions on the "frame" member of a client, just as any other canvas object can be managed.
*** do NOT set interceptors on a client's comp_object. seriously.
* startup order rewritten: compositor now starts much earlier, other things just use attrs and members of the compositor
* ecore_x_pointer_xy_get usage replaced with ecore_evas_pointer_xy_get
* e_popup is totally gone, existing usage replaced by e_comp_object_util_add where applicable, otherwise just placed normally on the canvas
* deskmirror is (more) broken for now
* illume is totally fucked
* Ecore_X_Window replaced with Ecore_Window in most cases
* edge binding XWindows replaced with regular canvas objects
* some E_Win functionality has changed such that delete callbacks are now correctly called in ALL cases. various dialogs have been updated to not crash as a result
comp files and descriptions:
e_comp.c - overall compositor functions, rendering/update loop, shape cutting
e_comp_x.c - X window management and compositor functionality
e_comp_wl.c - Wayland surface management and compositor functionality
e_comp_canvas.c - general compositor canvas functions and utilities
e_comp_object.c - E_Client->frame member for managing clients as Evas_Objects, utility functions for adding objects to the compositor rendering systems
additional authors: ivan.briano@intel.com
feature: new compositor
removal: e_border, e_container, e_popup
Subject: [E-devel] [e][PATCH] Optimizations v2
Date: Fri, 21 Dec 2012 22:17:32 +0100
Hi,
same patch as before: removed useless nullchecks and
switched some free()'s to E_FREE().
SVN revision: 81592
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80216
they form more of a logical group, so nothing lost here, just now its
ALL inside conf_display (like conf_applications actually).
ths does NOT mean we merge every category entirely.
for example (this is kind of a plan):
in input i'd merge key bindings, mouse bindings AND i'd bring over
acpi bindings. edge bindings i'd keep alone for now. interaction and
mouse settings i'd merge.
in windows i'd merge everything except window list and window
remembers. window list i'd merge into the winlist module itself as its
the configuration FOR that module (and then config for it i'd move to
its own config file). window rememebrs i'd keep on its own because its
a complex thing that might want to be totally hidden or re-vamped on
its own.
in menus i'd merge client list menu over to the merged "windows"
module (change its name to Window List Menu too).
in language i'd merge both language and input method setting. both
are related to dealing with multiple languages (input and display).
in look i'd leave wallpaper2, and merge wallpaper, theme, colors, fonts,
startup, icon theme, transitions and scaling. i'd merge merge mouse
cursor look over to the mouse settings + interaction module up in
input (but keep it in the look category). borders i'd merge over to
the "big windows merged module" but keep it in the look category.
in advanced i'd merge performance and engine. leave the rest.
in settings i'd leave it as-is.
in extensions i'd move shelves over to the screen category, but keep
it as a module of its own. pager i'd move to the screen category.
leave mixer and connman where they are. everything i'd keep here
- but i'd be tempted to say all the evry modules should be merged into
a single everything modules. they can keep their entries though.
gadgets i'd move over to the screen category
in files i'd merge file icons and file manager modules. keep 2 conf
entries tho (ie conf_mime joins fileman module). yes - i know e has
file selectors and they use the mime conf too, but to most people they
will just accept the file selector as-is and if they want to configure
icons per file tyope.. well.. load fileman module (can turn off
desktop icons if u want).
-------
why do this? fewer modules to load for e. as such e does spend a
fair bit of its startup time thrashing the disk around loading tonnes
of miniature modules. merging them means less thrashing. there is an
argument to be made that these should even become external processes,
but then we'd need to allow them to remote configure e and thats a
complex beastie in and of itself. we could also load and unload some
modules on the fly. this requires extra features in e17's module
setup, but can be done. worry about this for e18/19 etc. for e17 just
reduce the module count to a saner number (outside of the conf modules
which were the worst here, everything and illume are the next worst.
as above - evry could merge i think. illume vs illume2 cant merge, but
i'd consider merging the toggle modules, blutetooth, indicator and home
modules and then the keyboard and softkey modules (as they occupy the same
screen space basically). so that'd take it to illume, illume2,
illume-home, illume-key
how's that for a plan? who wants to help. this is easy stuff really.
just re-shuffling files and makefile.am content and some module
desktop.in files, and inserting some hooks. in module main setup funcs
and.. fixing e config profiles to not load the removed mods.
SVN revision: 58282
Carsten Haitzler
Mike Blumenkrantz
Marcel Hollerbach
Mike Blumenkrantz
Chidambar Zinnoury
Maxime Villard
Mike Blumenkrantz
Gwanglim Lee
