Mike Blumenkrantz
af38ddf0a6
delete any invalid gadcon clients for custom gadcons since we don't validate as much here
...
SVN revision: 79823
2012-11-29 10:09:28 +00:00
Mike Blumenkrantz
011b6c7b02
NULL check gadcon dnd enter events so we don't crash on efm drag operations
...
ticket #1820
SVN revision: 79676
2012-11-26 08:29:22 +00:00
Carsten Haitzler
92d53b87a5
and remvoe debugging.
...
SVN revision: 79670
2012-11-26 06:40:35 +00:00
Carsten Haitzler
7277ce21b1
fix segv where menus are not actually popped down on deletion of gcc.
...
SVN revision: 79669
2012-11-26 06:38:43 +00:00
Carsten Haitzler
108b985e87
valgrind complain-- :
...
SVN revision: 79665
2012-11-26 03:49:55 +00:00
Mike Blumenkrantz
e5903f4740
add support for and use eina_list_last_data_get
...
SVN revision: 79144
2012-11-12 10:05:09 +00:00
Christopher Michael
68e70b0131
E: Fix bug. The "Look" submenu of a gadget would not have any item
...
selected (Plain/Inset) if no style was previously selected for this
gadget. This adds code that also checks the Client Class default style
if no gadget style has been assigned yet.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 78505
2012-10-26 07:20:59 +00:00
Christopher Michael
8894fb5f50
E: Fix formatting for 80 columns
...
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 78504
2012-10-26 07:20:51 +00:00
Mike Blumenkrantz
ebef167dab
improve shelf gadget dragging
...
ticket #1658
SVN revision: 78420
2012-10-25 07:37:53 +00:00
Carsten Haitzler
53ad992c31
pointed out by Igor Murzov - fixed backlight thing, gadcon is cleaner.
...
SVN revision: 77980
2012-10-15 07:05:00 +00:00
Carsten Haitzler
35773a3241
add config for disabling delayed modules. this actually drastically
...
speeds up e startup - but this i mean the shelf comes up instantly
populated rather than taking 2 or 3 seconds to figure its life out.
SVN revision: 77558
2012-10-07 10:01:14 +00:00
Mike Blumenkrantz
43fb89ddb7
gadcon "Move to" menu no longer shows the gadget's current gadcon
...
SVN revision: 77523
2012-10-05 10:07:22 +00:00
Mike Blumenkrantz
71f57bb52d
gadcon location gadget_add callbacks now have a gadcon client param so the config can be retrieved since these callbacks are (currently) only used for changing locations of gadgets
...
also the related gcc param in gadget_del can now have a NULL config to signify that the gadget has been moved to a new gadcon
this means that moving a gadget to a new location will no longer cause it to lose its gadget config
ticket #1594
SVN revision: 77521
2012-10-05 09:57:34 +00:00
Mike Blumenkrantz
817bec21b1
prevent DND for systray gadgets in all cases
...
SVN revision: 77357
2012-10-03 09:19:26 +00:00
Mike Blumenkrantz
54d1715e58
debug printf--
...
SVN revision: 77272
2012-10-01 14:07:37 +00:00
Mike Blumenkrantz
4c09bb330f
yet another gadget overhaul, this time fixing:
...
* gadget dragging over windows (ticket #1563 )
* gadget dragging/resizing on the hover layer
* yet another gadget refcount bug
* lots of annoying inconsistencies when dragging around new desktop gadgets
SVN revision: 77271
2012-10-01 14:02:24 +00:00
Mike Blumenkrantz
8a7477d9a8
reflow some code
...
SVN revision: 77254
2012-10-01 08:54:36 +00:00
Mike Blumenkrantz
37f4478e0a
add last resort fix for an extremely rare corner case in gadman which causes objects to be undeletable at this point, preventing shutdown due to an infinite loop
...
SVN revision: 76930
2012-09-21 06:45:11 +00:00
Mike Blumenkrantz
8233970853
fix nulling of gadcon populate idler
...
SVN revision: 76908
2012-09-20 12:54:11 +00:00
Mike Blumenkrantz
5e0b6fd200
reorder shelf startup slightly, add gadcon populate event, only show created shelf after it's been populated, populate gadcons incrementally instead of all at once
...
this commit reduces my startup time by 0.5-1.0 seconds on average when using two shelves
SVN revision: 76894
2012-09-20 08:44:30 +00:00
Mike Blumenkrantz
03a578abae
initialize variable
...
SVN revision: 76808
2012-09-18 11:44:24 +00:00
Mike Blumenkrantz
ea61755d98
fix a bunch of questionably valid null derefs from clang
...
SVN revision: 76807
2012-09-18 11:42:44 +00:00
Mike Blumenkrantz
03dda786da
with massive hacks and huge other hacks, it's finally possible to seamlessly drag icons from the desktop to a shelf and vice versa
...
ticket #113
SVN revision: 76765
2012-09-17 14:49:48 +00:00
Mike Blumenkrantz
95ac2fdc8a
show/hide gadget drag object when leaving/entering gadcons
...
SVN revision: 76761
2012-09-17 13:10:19 +00:00
Mike Blumenkrantz
59d33a4a8b
remove debug info
...
SVN revision: 76758
2012-09-17 12:24:17 +00:00
Mike Blumenkrantz
040b87a604
clean up gadcon dnd code to not use static variables
...
SVN revision: 76757
2012-09-17 12:23:55 +00:00
Mike Blumenkrantz
fbc50eee75
prevent gadcon callbacks from being added multiple times
...
SVN revision: 76749
2012-09-17 09:50:49 +00:00
Mike Blumenkrantz
8bea4f9411
check for existence BEFORE getting geom
...
SVN revision: 76744
2012-09-17 09:27:05 +00:00
Mike Blumenkrantz
7031ce46b4
fix bug where gadgets could not be dragged left on shelf at the expected level of dragging, also increase drag threshold for moving gadgets to the right
...
SVN revision: 76736
2012-09-17 07:09:21 +00:00
Mike Blumenkrantz
9ccf1d988f
don't delete gadgets when drag is done if new gadget is dropped gadget
...
SVN revision: 76735
2012-09-17 06:10:49 +00:00
Mike Blumenkrantz
4036e9a3c5
need to unlock gadcon BEFORE checking whether gadcon is still editing, otherwise we never unlock and always break shelf autohide
...
SVN revision: 76731
2012-09-17 05:26:22 +00:00
Mike Blumenkrantz
092b37f981
hmm it seems that attempting to be clever and show/hide when leaving and entering the same gadcon during a drag is at least part of the problem with ticket #1462...
...
SVN revision: 76730
2012-09-17 05:25:15 +00:00
Mike Blumenkrantz
d181a362c6
fix gadget dnd bug where repeatedly dragging gadgets around from shelf to desktop to shelf to desktop to shelf to desktop would confuse gadman and prevent it from injecting gadgets properly
...
SVN revision: 76729
2012-09-17 05:02:23 +00:00
Mike Blumenkrantz
6cf37f95bf
delete newly-created gcc here if it isn't our current gcc since we won't be using it
...
SVN revision: 76728
2012-09-17 04:44:41 +00:00
Mike Blumenkrantz
46afc57359
check null here even though it SEEMS impossible to prevent jokers from injecting bad configs
...
SVN revision: 76727
2012-09-17 04:41:09 +00:00
Mike Blumenkrantz
194dbb13a3
fix rare gadget dnd crash
...
SVN revision: 76726
2012-09-17 04:29:49 +00:00
Mike Blumenkrantz
5193de5919
finally fix moving (dragging) gadgets from a shelf to the desktop in a super hackish way that will hopefully be fixable in e18 with a complete rewrite of gadcon/gadman
...
note: this will look really bad (giant black rectangle) if you have "Use ARGB instead of shaped" checked in Engine config
SVN revision: 76543
2012-09-12 16:23:02 +00:00
Mike Blumenkrantz
8f0aa351f8
reflow some code
...
SVN revision: 76536
2012-09-12 15:02:12 +00:00
Mike Blumenkrantz
e81c385e57
break out gadcon drop handler add into separate function to make it reusable
...
SVN revision: 76516
2012-09-12 10:37:29 +00:00
Mike Blumenkrantz
4c89c8ccb1
add mechanism for deleting gadcon configs, shelf deletion now triggers gadcon deletion, fix crash when renaming shelves, prevent shelves from being renamed to the same name as another shelf, fix bug where gadcon client ordering would increase infinitely when adding/removing/redrawing gadgets
...
SVN revision: 76297
2012-09-07 11:00:25 +00:00
Mike Blumenkrantz
e0c57c8244
remove this misleading line: there is NEVER a zone here.
...
SVN revision: 76280
2012-09-07 07:08:48 +00:00
Mike Blumenkrantz
0e414444b2
add flag to gadcons to mark them as being custom gadcons, don't refresh custom gadcons completely when repopulating, fix crash which occurred when gadcon container was deleted before gadcon
...
SVN revision: 76256
2012-09-06 18:26:09 +00:00
Mike Blumenkrantz
c66c6babeb
add events for gadcon provider add/del
...
SVN revision: 76233
2012-09-06 09:28:53 +00:00
Mike Blumenkrantz
0b9f1a9c17
add new events for gadcon clients being added/removed
...
SVN revision: 76225
2012-09-06 07:40:30 +00:00
Mike Blumenkrantz
0fc873f1b9
revert gadcon event thingy, this causes a stupid gadman bug crash which takes more than 5 mins to fix
...
SVN revision: 76203
2012-09-05 16:47:16 +00:00
Mike Blumenkrantz
0a50c49958
add events for gadcon populate/unpopulate
...
SVN revision: 76199
2012-09-05 14:17:43 +00:00
Mike Blumenkrantz
4c0fa2d381
big roundup commit fixing leaky submenus
...
SVN revision: 75973
2012-09-03 08:30:39 +00:00
Mike Blumenkrantz
5c3352c57f
add function for changing a gadcon client's menu
...
SVN revision: 75971
2012-09-03 08:02:33 +00:00
Carsten Haitzler
40a67e9222
streamline gadget menu to move move item to main menu.
...
SVN revision: 75407
2012-08-18 10:54:02 +00:00
Mike Blumenkrantz
3433a78ba2
gadcon util menu thingy now sets created menu to appropriate struct members to prevent unexpected behavior
...
SVN revision: 75282
2012-08-15 06:35:02 +00:00
Mike Blumenkrantz
8da7dd34b1
probably a good idea to actually delete menus when they hide instead of just praying for it
...
indirectly fixes ticket #1287
SVN revision: 75256
2012-08-14 12:39:19 +00:00
Mike Blumenkrantz
e9cb0d2085
gadget provider list is now sorted alphabetically
...
SVN revision: 75201
2012-08-13 09:51:50 +00:00
Mike Blumenkrantz
e3e11778fa
wait till after module init is over before drawing gadgets so we can draw them all at once, also don't need to bind to frametime anymore with this
...
SVN revision: 75067
2012-08-10 07:02:02 +00:00
Mike Blumenkrantz
f8eff99bf8
Dear all.
...
I found the bug which may occurs enlightenment crash.
There is code to insert E_Gadcon pointer to custom_populate_requests list in e_gadcon_custom_new(). However, there is no code to remove deleted E_Gadcon pointer from custom_populate_requests list in e_gadcon_custom_del(). So, if the e_gadcon_custom_del() is called before calling _e_gadcon_custom_populate_idler(), then enlightenment crash may occurs while e calls _e_gadcon_custom_populate_idler() because e accesses deleted E_Gadcon pointer.
I modified this problem. Please review this patch.
Thanks.
--
Doyoun Kang
SVN revision: 75033
2012-08-09 08:25:41 +00:00
Mike Blumenkrantz
7623fa4de0
add new functions for renaming a shelf/gadcon in the process of hunting #1286
...
SVN revision: 74973
2012-08-07 10:28:28 +00:00
Mike Blumenkrantz
031fc80e2f
clean up my earlier gadcon/menu idler work to be functional, thanks to jeffdameth for pointing it out
...
SVN revision: 74786
2012-08-02 07:20:51 +00:00
Mike Blumenkrantz
71ce826982
e_gadcon_client_find now takes an optional gadcon param to speed it up where possible
...
SVN revision: 74512
2012-07-27 16:10:06 +00:00
Mike Blumenkrantz
4ffafd3313
ensure gadcon class is populated before trying to create a client for it
...
SVN revision: 74507
2012-07-27 15:30:36 +00:00
Mike Blumenkrantz
f990c4d738
greatly simplify gadcon populate idler
...
SVN revision: 74491
2012-07-27 13:18:25 +00:00
Mike Blumenkrantz
df03a272e5
remove useless checks on gcc name
...
SVN revision: 74488
2012-07-27 12:29:55 +00:00
Mike Blumenkrantz
5db9d9fb00
change gadcon waiting classes list to a hash in order to remove some strcmps
...
SVN revision: 74487
2012-07-27 12:26:41 +00:00
Mike Blumenkrantz
5a6e5ec964
make client class population gadcon-specific so we don't end up populating every gadcon site with 500 client classes if they're only used on a single shelf
...
SVN revision: 74485
2012-07-27 10:54:00 +00:00
Mike Blumenkrantz
5070653af2
add debug timing info for gadcon idler populates
...
SVN revision: 74478
2012-07-27 09:28:25 +00:00
Mike Blumenkrantz
81cbce9d96
log error and fail when attempting to register a nameless gadcon client class to prevent massive failure later
...
it is once again a good time to update
SVN revision: 74477
2012-07-27 08:46:04 +00:00
Mike Blumenkrantz
8b0c1eaefe
fix gcc populates to actually set all necessary variables and prevent config from being wiped; fixes gadman gadgets randomly disappearing and probably a lot of other unnoticed bugs
...
SVN revision: 74476
2012-07-27 08:42:16 +00:00
Mike Blumenkrantz
f08e7423f2
make gadcon class function pointers require const as they should, add new custom populate request function, consolidate gcc populate code
...
compile warnings are being cleaned up next
SVN revision: 74472
2012-07-27 08:17:32 +00:00
Mike Blumenkrantz
5389c8a964
forgot to deregister client class from populated list
...
SVN revision: 74445
2012-07-26 14:13:49 +00:00
Mike Blumenkrantz
14b109ac78
fix gadcon crashing when enabling/disabling modules
...
SVN revision: 74443
2012-07-26 13:59:41 +00:00
Mike Blumenkrantz
812abd7c1d
actually I don't know wtf I was thinking with 74438, I was clearly a misguided genius in the code that I removed in this commit; fixes adding new gadgets and also speeds up the process greatly
...
SVN revision: 74441
2012-07-26 13:00:15 +00:00
Mike Blumenkrantz
f8b1dbf2e3
add function for finding a gadcon client from its config
...
SVN revision: 74439
2012-07-26 12:41:41 +00:00
Mike Blumenkrantz
512f48014c
not sure what I was thinking here, no need to repopulate a gadcon when client class is populated
...
SVN revision: 74438
2012-07-26 12:41:01 +00:00
Mike Blumenkrantz
ec019bae91
only populate custom gadcons with the gadgets that are actually loaded in the gadcon: huge speedup
...
SVN revision: 74433
2012-07-26 11:05:39 +00:00
Mike Blumenkrantz
c2b2d7e5ad
registering a gadcon client class no longer immediately tries to populate the class; we now populate classes only when a gadget for the class is loaded to further reduce the initial loading clusterfuck
...
SVN revision: 74432
2012-07-26 10:34:40 +00:00
Mike Blumenkrantz
f66e16178c
in general, any time e_icon_object_set is used, it's wrong. e_icon doesn't handle these cases and fails in every case other than the initial _set() call.
...
SVN revision: 74209
2012-07-20 06:53:52 +00:00
Mike Blumenkrantz
42ceb58540
merge a big e17 doc patch
...
ticket #91
SVN revision: 73408
2012-07-06 10:53:22 +00:00
Mike Blumenkrantz
5950d44b2f
add resize callback for gadcon parent to properly adjust box packing objects for gadcon clients
...
also fixes pager resize in shelf
SVN revision: 73222
2012-07-03 10:44:33 +00:00
Mike Blumenkrantz
37461278bc
add e_shelf_zone_dummy_new(), e_shelf_list_all(), and e_gadcon_dummy_new() to allow for creating an object (such as a task bar) which simulates a shelf for the purpose of removing its geometry from _e_zone_useful_geometry_calc(), thus preventing windows from being placed under it
...
ticket #643
SVN revision: 72999
2012-06-28 10:59:19 +00:00
Mike Blumenkrantz
a8bfedc268
have to unlock shelf at this point or else it will never hide anymore
...
fixes ticket #1013
SVN revision: 72806
2012-06-25 13:04:13 +00:00
Mike Blumenkrantz
e1acc237ed
fix some remaining shelf autohide bugs related to shelves drawn on the container
...
SVN revision: 72804
2012-06-25 12:10:31 +00:00
Mike Blumenkrantz
251ae5f857
add e_gadcon_client_autoscroll_toggle_disabled_set() to prevent disabling autoscroll in a gadget
...
SVN revision: 72795
2012-06-25 10:46:51 +00:00
Mike Blumenkrantz
9d5f2a7c63
also ensure min size for shelf gadgets is not greater than max size
...
SVN revision: 72787
2012-06-25 08:25:07 +00:00
Mike Blumenkrantz
1c0ae4ffcb
shelf gadgets no longer tries to set min/max sizes that are larger than the shelf
...
SVN revision: 72786
2012-06-25 08:22:16 +00:00
Mike Blumenkrantz
82ae1fcaac
when a gc_init function fails, delete the config and clean up after: mainly for systray
...
SVN revision: 72564
2012-06-21 06:47:26 +00:00
Vincent Torri
c3b0637802
e17: whitespaces--
...
SVN revision: 72561
2012-06-21 06:19:43 +00:00
Mike Blumenkrantz
1a7c41f86a
formatting
...
SVN revision: 72540
2012-06-20 12:43:15 +00:00
Cedric BAIL
2d0970da9a
e: warning--.
...
SVN revision: 70751
2012-05-04 02:34:56 +00:00
Carsten Haitzler
515819cdb5
make all zone matching agree on the same convention - use zone->num,
...
not zone->id. zone->id is for matching u to zinerama/xrandr
screens/outputs. e re-sorts based on highest res screens first, lower
res later.
SVN revision: 67951
2012-02-15 04:35:18 +00:00
Carsten Haitzler
2812e15939
make aspect size requests work properly with autoscroll in shelf.
...
SVN revision: 66312
2011-12-18 14:03:15 +00:00
Carsten Haitzler
a3bfd5d8bb
have tasks always set inset and autoscroll so it works right.
...
SVN revision: 65118
2011-11-13 05:47:09 +00:00
Carsten Haitzler
0b4f2529f9
overkill doing "Gadget nameofgadget in the menu. just nameofgadget
...
will do. also it wasnt translated anyway.
SVN revision: 64624
2011-11-01 22:33:38 +00:00
Youness Alaoui
88f331c878
wtf, removing wrongly inserted tabs in previous commit
...
SVN revision: 64588
2011-10-31 23:26:24 +00:00
Youness Alaoui
a98518a9de
E: gadcon width adjustment was entering an infinite loop if no gadget had autoscroll enabled
...
the 'need' variable had to be initialized to 0, and a break condition for the loop
also needed to be added otherwise we'd end up in an infinite loop if no gadget
had autoscroll (in which case, the need var was never modified).
SVN revision: 64587
2011-10-31 23:22:07 +00:00
Carsten Haitzler
d5247cd243
and refine new gadcon layout somemore - so much simpler now! yay!
...
SVN revision: 64556
2011-10-31 12:04:34 +00:00
Carsten Haitzler
be4202e8a6
disable resizable gadcon gadgets because we now have autoscroll expand
...
stuff working.
SVN revision: 64551
2011-10-31 10:10:17 +00:00
Carsten Haitzler
4a76470496
taskbar++!
...
one more todo item being knocked off. but there.
also no proper icon for it yet. mostly code from the old taskbar with
lots of little things fixed.
SVN revision: 64518
2011-10-30 07:36:54 +00:00
Hannes Janetzek
4651579f73
e17/gadcon client menu: dont restrict 'move to' when gadcon has no site restrictions
...
SVN revision: 58600
2011-04-12 20:42:19 +00:00
Hannes Janetzek
bbcae9589b
e17/gadcon: dont show 'move to' entries for sites to which gadgets cannot be moved
...
SVN revision: 58568
2011-04-11 20:39:42 +00:00
Christopher Michael
43c493f090
E17 - Fixup some compiler warnings
...
gadcon: Fix 'limit' may be used uninitialized.
Fix formatting in some places.
menus: Fix several variables may be used uninitialized warnings.
comp: Add UNUSED where needed.
Fix formatting in some places.
SVN revision: 58467
2011-04-08 05:31:47 +00:00
Hannes Janetzek
7f457f1911
e17: add option to have gadcon client settings menu in toplevel again.
...
added e_menu_item_new_relative(E_Menu, E_Menu_Item *rel) which appends
new item to rel or prepends it when rel is NULL.
changed e_gadcon_util_client_menu_append to to take only the gadget menu
and returns the new toplevel menu that should be shown by gcc
depending on the setting this is a new menu with gadget menu as submenu
or the gadet_menu with gadget menu items appended
updated e-modules-extra comes in a minute
SVN revision: 57826
2011-03-17 17:08:36 +00:00
Carsten Haitzler
d9184e351d
on free of list.. set list ptr to null tnx. :)
...
SVN revision: 55859
2011-01-05 03:14:34 +00:00