Commit Graph

143 Commits

Author SHA1 Message Date
Chris Michael 87dd451353 Fix Phab Ticket T433 for Glima where you could not disable a laptop panel
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-10-17 18:05:29 +01:00
discomfitor d5675fd705 don't try applying randr settings when there's no outputs, this doesn't do anything 2013-10-17 08:35:27 +01:00
discomfitor 2eeb5fe129 get root window BEFORE using it to restore randr config :/ 2013-10-17 08:35:14 +01:00
Chris Michael a0e993f59b Finally fix odd TV resolution cloning
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-14 13:35:28 +01:00
Chris Michael 07fa7e4a13 Another attempt at odd TV resolution fix.
Mike, try this one "live" please

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-14 12:25:48 +01:00
Chris Michael 4df53f06e3 Revert "Fix bug when hotplugging a TV where resolution does not match the"
This reverts commit a9e09bc26d.

Breaks build, and does not fix real issue. Revert
2013-10-14 11:07:24 +01:00
Chris Michael a9e09bc26d Fix bug when hotplugging a TV where resolution does not match the
parent because a TV uses a non-standard 1360 resolution

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-14 10:53:04 +01:00
Chris Michael 8404e3c180 Fix uninitialized variable warning.
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-09-26 20:07:01 +01:00
Chris Michael 8b28549aea RandR: Fix issues discovered here during testing
- Add some more debugging printouts
- When we initially plug in a monitor, set to Clone by default
- During initial clone, we cannot assume the plugged-in device
supports the same Mode so try to find a mode based on size.
- On output changes, test that an output has a crtc assigned.
- If a detached output Was the primary monitor, reset primary in config
to a valid existing monitor.
- Improve output_crtc_find code for better detection of where we can
place a new output.
- Fix "preferred mode" detection error.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-26 12:15:34 +01:00
discomfitor 944cfd246d since we're now requiring an efl version which has the necessary ecore-x functions, remove old and not-compiling ecore-x randr code which obviously has never been compile tested 2013-08-31 15:07:15 +01:00
Chris Michael b6fe0c8ff6 Don't do randr restore if we have fake screens. (requested by release
master) ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 08:08:33 +01:00
Chris Michael 112a4091c4 When we have to calculate screen size, it May actually Help to get the
crtc id that we need to fetch values for.

NB: Phab Ticket T258

NB: /me slaps self

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-08-02 17:06:55 +01:00
Chris Michael 395434a113 Properly check for primary output during new configurations.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-25 13:29:59 +01:00
Chris Michael a612fcf2c9 Initialize geometry variables (ie: The Shutup you stupid clang commit)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-31 13:29:51 +01:00
Chris Michael 16c63ecf8c Remove call to screen_reset (not needed)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-29 13:30:03 +01:00
Chris Michael 99268f50ab Rework the randr restore code
NB: This matches more closely to how xrandr applies settings

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-29 12:35:57 +01:00
Chris Michael 2a38555368 Add code to handle setting a larger screen size
IF, when applying any saved crtc settings, we find that the current
screen size is too small, then calculate a new screen size and apply it.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-29 07:21:39 +01:00
Chris Michael 7ae5da88da When we try to restore randr config, skip outputs that are not
connected.

Fix buffer which was flipping Primary Output when you restart E (ie:
only set Primary Output once).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-28 14:43:48 +01:00
Chris Michael 98ac01ceb8 Remove unused variable (not needed).
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-25 20:20:13 +01:00
Chris Michael 74a85a19db Actually, we cannot set primary first as we may need to re-enable a
saved monitor, so move "primary setting" until After we have enabled
and sized the monitors.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-25 20:18:33 +01:00
Chris Michael 04936b207a Set primary output before crtc settings.
If the primary output saved in config does not exist, then set primary
to the first output.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-24 18:42:45 +01:00
Chris Michael 9f95515926 Record primary output in randr config.
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-24 13:04:58 +01:00
Chris Michael d6a392d127 Preliminary support for Primary Output of XRandR
NB: If you have more than one output, XRandR has the option/support to
set a specific monitor as the primary output. These changes allow some
distinction in the dialog between which output is primary (a faint
glow around the monitor). This is just the "display" portion of
Primary Output support ... next is a method to Change that.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-24 11:28:34 +01:00
Chris Michael dff4df51f3 Fix potential memleak reported by klockwork.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-20 10:31:01 +01:00
Chris Michael 012a05e571 Modes is a zero-based list, so preferred needs to be -1.
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-19 12:44:26 +01:00
Chris Michael 9e605ebce8 Fix randr plug-n-play for cedric because he asked nicely ;)
- Add config timestamping to our randr config.
- remove property_notify handler as we never use it.
- Unify some code to remove duplication
- Add a lot of debugging output.
    Yes, e_randr is going to be noisy for a little while until I can
    verify that it works for others also.
- Too many other changes to list.
    Suffice to say, this makes e_randr plug-n-play work (here anyway).

NB: Right now, this just clones. It Could be changed to extend new
monitors tho

NB: This works here, on my laptop at home. If you find it does not
work for you, please supply the output of E's startup/restart when you
plug AND unplug monitors.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-18 16:35:16 +01:00
Christopher Michael 1c15009411 Remove commented fixme (no time to optimize this routine right now).
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84255
2013-02-20 07:45:13 +00:00
Christopher Michael bc23ef529c Remove poller code for now (broken, does not work as expected, etc,
etc).

Add exists field for crtc and output.
Fix output clones and connection status get to use the correct output.
Add some notes and printfs.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84227
2013-02-19 11:01:11 +00:00
Christopher Michael bf6d1d43ae Start on poller code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84226
2013-02-19 11:01:08 +00:00
Christopher Michael 3ff49b211e Add poll_interval to e_randr_cfg.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84225
2013-02-19 11:01:05 +00:00
Christopher Michael 059a0198c3 When we get randr events, check for actual config differences.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84223
2013-02-19 11:00:59 +00:00
Christopher Michael 6c8bafb044 When we get an output changed event, check for matching crtc id and
also set changed flag if anything in the crtc has changed.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84220
2013-02-19 11:00:23 +00:00
Christopher Michael dc509dd812 Add support for an outputs clones in e_randr and e_randr config.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84206
2013-02-19 10:59:28 +00:00
Christopher Michael b12e6c9c12 Add note about screen_reset.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84154
2013-02-19 10:56:58 +00:00
Christopher Michael fb26b60f11 Add a blank line to separate comments.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84145
2013-02-19 10:56:32 +00:00
Christopher Michael 84481e16d3 Remove randr versions (in header now).
Set default output policy.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84112
2013-02-19 10:54:52 +00:00
Christopher Michael f5f7d72305 Add start of new e_randr code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84110
2013-02-19 10:54:44 +00:00
Christopher Michael a6a159be63 Remove All Old Randr Code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 84107
2013-02-19 10:54:29 +00:00
Mike Blumenkrantz 9e8e755cdf formatting: all at once
SVN revision: 82625
2013-01-11 10:34:29 +00:00
Christopher Michael 0744667e74 Use proper function when config gets loaded to try and restore
configuration.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81156
2012-12-17 15:46:41 +00:00
Christopher Michael 00d5045d27 Move EAPI functions above EINTERN ones.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81148
2012-12-17 14:28:04 +00:00
Leif Middelschulte 95f33ad549 Make conf_display work again (primary output resolution st/ld).
SVN revision: 69547
2012-03-21 23:39:11 +00:00
Sebastian Dransfeld 05bf07450c e: formatting
SVN revision: 69055
2012-03-08 11:37:54 +00:00
Leif Middelschulte 19dd99da42 Fix return values of non-void functions.
SVN revision: 68241
2012-02-22 00:02:58 +00:00
Leif Middelschulte 466b3c91c6 Improve init so it fails if the drivers dont really support RandRR.
SVN revision: 68238
2012-02-21 23:53:00 +00:00
Carsten Haitzler 32ac589897 fix e_randr eina log bitching when u dont have exisitng config!
SVN revision: 68208
2012-02-21 08:17:32 +00:00
Leif Middelschulte b27aec4ad5 Refactoring e_randr, big time.
SVN revision: 68114
2012-02-18 16:49:07 +00:00
Carsten Haitzler 60fea9433f hey e_randr... lets not segv on setting up screen eh?
SVN revision: 67700
2012-02-04 23:01:36 +00:00
Leif Middelschulte f218a4c893 Typo on function name RandRR 1.1 vs. 1.2
SVN revision: 67400
2012-01-20 18:58:29 +00:00
Christopher Michael 8e4a1c3758 E: Fix warning about uninitialized variable in randr code.
SVN revision: 67273
2012-01-17 12:41:21 +00:00
Leif Middelschulte dba1e9d7e4 Silence warnings.
SVN revision: 66978
2012-01-08 18:13:42 +00:00
Leif Middelschulte 302dfe88f3 Fix possible issue with missing outputs.
SVN revision: 66638
2011-12-29 18:29:52 +00:00
Leif Middelschulte 10ce636d7a Clean up++. Also fix randr 1.0 corner case.
SVN revision: 66465
2011-12-22 15:11:35 +00:00
Leif Middelschulte 203905f1c0 Fix ignorance of policies when refreshing e_randr info.
SVN revision: 66338
2011-12-19 17:42:08 +00:00
Leif Middelschulte 8c70ddd862 Use poller to force randr events to be sent.
SVN revision: 66290
2011-12-16 14:19:37 +00:00
Leif Middelschulte f5bf360e9a Introduce refetching of all RandRR info.
SVN revision: 66287
2011-12-16 14:19:25 +00:00
Leif Middelschulte 89407ecd3a Fix some wording and spelling.
SVN revision: 66221
2011-12-14 17:37:43 +00:00
Leif Middelschulte 9282dd62d7 Make policies work and (re)storable. debug verbosity++
SVN revision: 66219
2011-12-14 17:37:33 +00:00
Leif Middelschulte add873a668 More fixes for e_randr, but also some for conf_randr.
SVN revision: 66216
2011-12-14 17:37:17 +00:00
Leif Middelschulte 7c96041e21 Several minor e_randr related fixes.
Don't free e_config stuff.
Improve debug messages wording.

SVN revision: 66215
2011-12-14 17:37:10 +00:00
Christopher Michael 9a8511aea0 E_Randr: Fix typo in message.
SVN revision: 65221
2011-11-15 06:46:47 +00:00
Mike Blumenkrantz 11ff2ab3eb I don't spend hours and hours and hours and days of my free time hacking on ecrustify for people to not use it.
SVN revision: 64917
2011-11-07 23:53:01 +00:00
Mike Blumenkrantz 512062bee3 okay. I'm not often as serious as I am now.
take a moment, look around, and find something that comforts you. enjoy this thing for a few minutes or until you are sufficiently relaxed.

IF YOU SEND US A PATCH, TEST COMPILE IT.
IF IT HAS WARNINGS, FIX THEM. ALL OF THEM.

IF YOU COMMIT A PATCH THAT CREATES WARNINGS, DON'T.
IF YOU HAVE COMMITTED A PATCH THAT CREATED WARNINGS:
* GO BACK TO SCHOOL
* LEARN PHYSICS AND ENGINEERING
* INVENT A TIME MACHINE
* GO BACK IN TIME AND SPANK YOURSELF


SVN revision: 64916
2011-11-07 23:49:08 +00:00
Mike Blumenkrantz a0c180f41a if (fail) goto exit;
exit:
   return;

who can spot what's wrong with the above snippet? cookies for the first one to answer correctly!


SVN revision: 64886
2011-11-07 22:36:11 +00:00
Mike Blumenkrantz d27e4fad0f as it turns out, this whole thing was pretty dumb so I'm cutting it down
SVN revision: 64885
2011-11-07 22:33:29 +00:00
Mike Blumenkrantz 91118b6790 initializers: I don't really have anything witty to say about them, but you should know that they're important
SVN revision: 64884
2011-11-07 22:31:03 +00:00
Carsten Haitzler 20e8feca2c i'll put in leif's randr code - even though it's buggy, it's the best
way for it to be worked on by people for release.



SVN revision: 64801
2011-11-06 06:41:39 +00:00
Carsten Haitzler 52e23870a3 revert parts of patch that committed randr to e... don't want that
right now until rest of patch is in.



SVN revision: 64629
2011-11-02 01:36:10 +00:00
Carsten Haitzler 0b4f2529f9 overkill doing "Gadget nameofgadget in the menu. just nameofgadget
will do. also it wasnt translated anyway.



SVN revision: 64624
2011-11-01 22:33:38 +00:00
Christopher Michael b436516f94 E: Randr: No need to get output connection status twice in a row (was
already done previously with the call to output_info_set.



SVN revision: 63810
2011-10-04 17:49:33 +00:00
Carsten Haitzler 2ea4a68f10 add some notes.
SVN revision: 63148
2011-09-04 04:14:43 +00:00
Christopher Michael d872100a56 E_Randr: Fix more nasty formatting so that code fits in 80-wide
terminal.



SVN revision: 61613
2011-07-23 17:55:05 +00:00
Carsten Haitzler ebb04e18be fix removal from list for randr init stuff that is begging to crash
and create bugs! (valgrind caught it)



SVN revision: 60475
2011-06-18 13:56:08 +00:00
Christopher Michael 3cf8d1fd05 E: Randr: Cleanup Randr code. Remove lots of compiler warnings about
signed & unsigned int comparison. Comment out Functions which were
defined but never used. Remove duplicated function prototype.



SVN revision: 59596
2011-05-22 16:58:06 +00:00
Hannes Janetzek 3dc3094518 e17 patches from T_UNIX:
0001-Small-fixes-possible-segv-in-e-s-randr-subsystem.patch
0002-Add-common-modes-to-CRTC-information-structure.patch


SVN revision: 57833
2011-03-17 23:02:02 +00:00
Cedric BAIL 154cdf7f48 * e: HUGE SPANK ! That one prevented me to restart E17 correctly.
SVN revision: 57058
2011-02-15 17:26:13 +00:00
Carsten Haitzler bbd14d2d3a try and avoid a segv if info is null on ret.
SVN revision: 55828
2011-01-03 15:49:51 +00:00
Mike Blumenkrantz 633de9d48d avoid null deref
SVN revision: 55714
2010-12-22 23:05:14 +00:00
Mike Blumenkrantz d795ae2e34 hooray idempotence! no wait, not hooray.
SVN revision: 55699
2010-12-22 22:26:53 +00:00
Gustavo Sverzut Barbieri 6f2213cb25 convert init/shutdown to EINTERN, move some to _update().
Do not abuse the concept of e_*_init(), make them call-once and those
that needed multiple call are renamed to e_*_update(). To make sure
convert them to EINTERN so the symbols are not exported.

Actually I guess too much is exported as EAPI while they should be
EINTERN, but that would require manual investigation, while this patch
was basically created with sed + grep.



SVN revision: 54795
2010-11-22 15:21:32 +00:00
Mike Blumenkrantz f80e5cee0b null pointer to fix resolution switching crash
SVN revision: 54526
2010-11-12 23:59:35 +00:00
Carsten Haitzler 2238c66924 document changes to rander event - not used and.. use new mapping
event to unbind + bind mouse and key bindings again.



SVN revision: 53943
2010-10-28 00:34:03 +00:00
Leif Middelschulte cf91a2561a From: Leif Middelschulte <leif.middelschulte@gmail.com>
this is a little patch for e_randr related stuff.

- replace the saving of a monitor's EDID with a hash of it.
- rename a variable name



SVN revision: 51508
2010-08-22 03:49:34 +00:00
Carsten Haitzler e6a803158a j++!!!!
SVN revision: 51474
2010-08-21 01:52:20 +00:00
Carsten Haitzler 9cb6681b35 simply breaking some long lines for readability.
SVN revision: 51473
2010-08-21 01:48:19 +00:00
Carsten Haitzler 7b47cd8425 other bit of lief's patch.
SVN revision: 51453
2010-08-19 22:49:13 +00:00
Christopher Michael 6ec4cc911a Add unused where needed. (Still lots of warnings in here, but don't
know the code well enough to fix them all).



SVN revision: 51314
2010-08-18 18:35:34 +00:00
Cedric BAIL 6e33eb8d0e * e: does more check around xrandr code.
SVN revision: 51253
2010-08-17 14:58:31 +00:00
Christopher Michael db5ec3e8c1 More cleanup of the randr code ... don't include headers that are
already included via e.h. Do not need to do eina/ecore init or
shutdown...handled by E already.



SVN revision: 51205
2010-08-16 12:44:46 +00:00
Christopher Michael ccfe4ba8d8 These headers already included by e.h
SVN revision: 51203
2010-08-16 12:22:50 +00:00
Carsten Haitzler 1bbfd6992e warning--
SVN revision: 51199
2010-08-16 10:40:23 +00:00
Cedric BAIL 8cbf2d3907 * e: SPANK ! SPANK ! SPANK ! Fix multiple case of segv.
SVN revision: 51135
2010-08-15 18:17:59 +00:00
Leif Middelschulte 935774e161 From: Leif Middelschulte <leif.middelschulte@gmail.com>
patch for ecore-x xrandr 1.3 support - breaks previous api. final api
change (i know about) before we go alpha. in to svn we go.



SVN revision: 51109
2010-08-14 10:21:03 +00:00