Carsten Haitzler
3dc555a7cf
fix warnings in build so new ones turn up and get fixed.
2013-07-15 11:45:19 +09:00
48e7d59eac
only call eldbus_shutdown() for udisks efm backends if there's an existing eldbus connection
2013-06-21 09:02:37 +01:00
a41c50632c
udisks2 support
2013-06-20 16:36:33 +01:00
02149c903c
patches to remove eukit and add device icon from D99
2013-05-07 11:17:03 +01:00
f8a2dd4d95
Rename edbus->eldbus
2013-04-23 12:37:43 -03:00
9187778f32
Revert "fix edbus message refcounting in udisks efm backend"
...
This reverts commit 0f9336b105
2013-02-28 15:41:49 -03:00
c7482d9b7d
fix edbus crash in udisks efm backend
2013-02-25 09:22:29 +00:00
0f9336b105
fix edbus message refcounting in udisks efm backend
2013-02-25 09:22:15 +00:00
66c08a536d
e: Remove unused variable warnings
...
Signed-off-by: Mike McCormack <mikem@atratus.org>
SVN revision: 82966
2013-01-18 06:45:55 +00:00
a37c6ca20f
e: follow edbus change about unref'ing messages after send
...
Don't unref the messages after calling edbus_*_send() since edbus
automatically unrefs them. It was also impressive the number of places
that were not unrefing the message when they should.
SVN revision: 82808
2013-01-15 14:34:50 +00:00
9e1b995c56
e: small fixes to port of e_fm udisk to edbus
...
- no need for calling edbus_message_error_get() if we are not getting
the error message
- rename confusing vars:
* A dict is this complete type: "a{sv}", i.e. an array with
key-values pairs (though the value could very well be 's', or
'u' or another basic type)
* An entry (or dict_entry, or de) is *the* key-value pair.
- Use eina_stringshare_replace when possible
SVN revision: 81986
2013-01-02 13:16:24 +00:00
5e4352e9b3
e: e_fm udisk ported to edbus
...
Patch by: José Roberto de Souza <zehortigoza@profusion.mobi>
SVN revision: 81985
2013-01-02 13:16:19 +00:00
5655cbf8af
e: Remove Hal backend from e_fm
...
Since Hal is deprecated since 2008 it's a bad idea wasting time porting
it to edbus.
Patch by: José Roberto de Souza <zehortigoza@profusion.mobi>
SVN revision: 81984
2013-01-02 13:16:14 +00:00
ae7ca9105f
Hi,
...
here is a patch.
1. free() already null-checks the passed argument, so it is not
necessary to do 'if(x) free(x)'.
2. Moved some '{free(x); x = NULL}' to E_FREE.
3. In e_start_main.c, 'buf' is allocated with the size of the
two arguments + '=', so we don't need to check for lenght;
we should use sprintf().
thanks
Maxime Villard
SVN revision: 81364
2012-12-19 14:20:34 +00:00
Carsten Haitzler
5ab8396f24
ok - strdupa make sure its defined after other includes in case,.. and
...
add to e_fm_ipc.c...
SVN revision: 81036
2012-12-16 01:17:45 +00:00
8347b33d9c
more leaks gone in trash code that isn't used
...
SVN revision: 80924
2012-12-14 09:19:50 +00:00
b48d65af00
fix lots of stupidity in efm daemon trash code that isn't even enabled
...
SVN revision: 80821
2012-12-13 11:18:26 +00:00
0743fd1ea2
fix efm daemon leak in every command made
...
SVN revision: 80820
2012-12-13 11:13:17 +00:00
b2b336ed7d
fix leak in efm daemon when reordering files
...
SVN revision: 80819
2012-12-13 11:10:01 +00:00
362531b082
Dear all,
...
I'm attaching a patch for some minor bugs in the e17.
Please take a look at attached patch.
01. missing E_FREE(inst)
File: src/bin/e_exec.c: 347
Function: _e_exec_cb_exec
02. missing null check
File: src/bin/e_fm.c: 10173
Function: _e_fm_error_dialog
I'm not sure, but all other codes always check the return
value of e_fm2_op_registry_entry_get except here.
03. missing free(slave)
File: src/bin/e_fm_ipc.c: 804
Function: _e_fm_ipc_slave_run
04. eina_list_remove after free
File: src/bin/e_fm/e_fm_ipc.c :1325
Function: _e_fm_ipc_cb_fop_trash_idler
05. invalid check for _udisks_del, it might be _udisks_chg.
File: src/bin/e_fm/e_fm_main_udisks.c : 162
Function: _e_fm_main_udisks_test
06. uninitialized gx and gy values
File: src/bin/e_gadcon_popup.c: 172
Function: _e_gadcon_popup_position
These could be changed in e_gadcon_client_geometry_get
if gcc->o_base is null.
07. unnecessary code 'evas = e_win_evas_get(dia->win)'
File: src/bin/e_import_config_dialog.c: 456
Function: e_import_config_dialog_show
08. missing free(sizes)
src/bin/e_randr_11_serialization.c: 136
Function: _11_try_restore_configuration()
09. unnecessary variable output_info
File: src/bin/e_randr_12.c: 560
Function: _output_property_change_event_cb
10. eina_list_remove after free
File: src/bin/e_randr_12_serialization.c : 357
Function: _12_serialized_setup_update
11. no check of the return value of symlink.
File: src/bin/e_widget_fsel.c: 84
Function: _e_wid_fsel_favorites_add
12. no evr->var check before comparing string values
File: src/modules/conf_applications/e_int_config_defapps.c: 432
Function: _basic_apply
13. missing error message or check return value of edje_file_group_exists
File: src/modules/conf_theme/e_int_config_theme.c: 333
Function: _open_test_cb
Anyway, I've added e_util_dialog_show if failed. Is it okay?
14. missing index range check
File: src/modules/gadman/e_mod_config.c: 153
Function: _cb_config
It could read negative array index, because return value of
e_widget_ilist_selected_get might be negative.
BR,
Gwanglim
SVN revision: 80020
2012-12-03 07:54:07 +00:00
676c71a2a1
efm now checks (on startup) for stale device links on desktop and tries to remove them
...
ticket #1689
SVN revision: 78608
2012-10-29 09:52:23 +00:00
80b0b615b8
e: Cleanup
...
Fixes potential invalid memory reads.
Patch by Igor Murzov
SVN revision: 77491
2012-10-04 23:27:01 +00:00
c310836bb3
add gui option for secure deletion in efm
...
SVN revision: 77434
2012-10-04 12:58:18 +00:00
cbb742a7cc
patch from Sergei Kabanov to fix possible crash in efm with udisks/hal backends
...
ticket #1529
SVN revision: 76814
2012-09-18 12:16:16 +00:00
c9f7684c02
add fileman config option for new mv setting, also implement necessary backend features in efm slave for using mv operations
...
SVN revision: 76676
2012-09-14 15:14:41 +00:00
734ecb4dbb
safeties for eeze mounting
...
SVN revision: 74904
2012-08-06 07:43:49 +00:00
8ad9126253
don't need to care if eeze doesn't find a device serial
...
SVN revision: 74899
2012-08-06 07:02:31 +00:00
b196e15bed
e fm prop: follow relative symbolic links before tagging them broken.
...
SVN revision: 74881
2012-08-05 08:55:59 +00:00
f5c44485a8
some more eeze mounting cleanups
...
SVN revision: 74812
2012-08-02 16:55:47 +00:00
65433e79ee
add extra check for volumes to avoid skipping ones we really want, also fix shadow warning
...
SVN revision: 74806
2012-08-02 14:57:05 +00:00
793145f2aa
pointers are fixed now so getting data is safe again
...
SVN revision: 74783
2012-08-02 07:05:36 +00:00
05fd34c8bd
fix efm dnd when filemanager widget is not positioned at 0,0, an icon's statinfo is now based on its source in case of link and desktop files, allow dnd onto link/desktop files as though they were the actual directory
...
SVN revision: 74729
2012-08-01 11:51:49 +00:00
0727364db1
fix unused warns when no mount backends enabled
...
SVN revision: 74575
2012-07-30 10:26:05 +00:00
d84cdfe4f7
move eeze init check higher up so prefix doesn't leak
...
SVN revision: 74573
2012-07-30 10:17:03 +00:00
80f17bbcff
don't try to delete mount points from e_fm anymore
...
SVN revision: 74570
2012-07-30 10:11:41 +00:00
caa9f1b42b
eeze is now back to mounting to /media/$devnode using noexec and nodev, also we now send an error message in another failure case
...
SVN revision: 74567
2012-07-30 10:01:49 +00:00
Carsten Haitzler
d10f72eff5
get rid of duiplicate device icons with eeze+eeze-scanner+mount etc.
...
as i see both dev/sdX and dev/sdX1 as devices. delete the parent ones
if child partitions exist.
SVN revision: 74543
2012-07-29 10:30:00 +00:00
d7f9ff7551
e now requires eio; this commit intentionally split from any code changes
...
SVN revision: 74373
2012-07-25 07:41:21 +00:00
6152d0be40
E_FM: Remove unused variables and fix formatting for 80 columns.
...
SVN revision: 74299
2012-07-22 15:35:23 +00:00
Carsten Haitzler
58be84aa8e
dont look for socket file - just connect to see if eeze scanner is
...
ther. no need for delay as we are polling anyway to try run it every N
polls (i reduced to 8 as once it runs it no longer polls).
SVN revision: 74262
2012-07-21 09:11:39 +00:00
db8156c94b
close eeze_scanner on efm shutdown if we started it
...
SVN revision: 73551
2012-07-11 06:41:19 +00:00
ff1224d07d
e_fm: Correct mount options used for udisks mounting
...
udisks has a restricted set of mount options which can be
used for most filesystems. I have adjusted our mount
options based on the current udisks code.
SVN revision: 73549
2012-07-11 05:52:56 +00:00
51cb146463
efm with eeze mounting should handle "unknown" devices more gracefully, also add some handling for udev CHANGE events
...
SVN revision: 73521
2012-07-10 10:43:28 +00:00
Carsten Haitzler
ecddd2391f
supprot XDG_RUNTME_DIR for ipc socket and handle failure if someone
...
already created it - try new names until tries exhausted (4096)
SVN revision: 73072
2012-06-30 05:33:36 +00:00
b5f4a75990
remove log level setting in eeze scanner and efm
...
SVN revision: 73024
2012-06-29 07:57:58 +00:00
9370e51c04
I came so close to just deleting this file instead of fixing it again
...
SVN revision: 72998
2012-06-28 10:38:38 +00:00
1a9f497be2
further unbork efm logging
...
SVN revision: 72997
2012-06-28 10:35:08 +00:00
3fb0b9c5ff
unbork efm logging
...
SVN revision: 72996
2012-06-28 10:31:40 +00:00
ba7c89a833
efm log level -> ERR
...
SVN revision: 72993
2012-06-28 10:19:45 +00:00
045eeee554
proudly set the EFM_MODE_USING_EEZE_MOUNT flag so that we don't use gross EFM_MODE_USING_RASTER_MOUNT
...
SVN revision: 72854
2012-06-26 07:31:43 +00:00
Vincent Torri
c3b0637802
e17: whitespaces--
...
SVN revision: 72561
2012-06-21 06:19:43 +00:00
6f83e8c10e
final bug fixes for eeze mounting: ensure suid wrapper is set for eject, fix mount point deletion on ejecting, create mount point directories just before mounting to allow for correct permissions
...
SVN revision: 72479
2012-06-19 13:42:51 +00:00
7e43d22dad
remove a probably-impossible case where efm's op slave would execute an undefined command without the user's knowledge
...
SVN revision: 72394
2012-06-18 12:54:07 +00:00
1f2732b978
whoops, forgot to make mounted devices user-readable with eeze mounting. fixed!
...
SVN revision: 72128
2012-06-14 12:46:32 +00:00
f784bff213
replace e17 logging "system" with custom eina log domain
...
SVN revision: 72089
2012-06-13 15:17:23 +00:00
a67288fda3
more stringshare usage fixes, also fix detection for drives which are ejectable (cdroms)
...
fixes ticket #691
SVN revision: 72023
2012-06-12 12:57:45 +00:00
a69db85b60
only print confusing error message on confusing errors
...
SVN revision: 72022
2012-06-12 12:39:10 +00:00
119b00b51f
only print error messages on real errors
...
SVN revision: 72021
2012-06-12 12:32:30 +00:00
4275e53f59
fix udisks stringshare usage, print some error messages on failure so I can tell wtf is going on
...
SVN revision: 72020
2012-06-12 12:21:16 +00:00
3ebff9189e
fix detection for volumes which are their own storage parent; this fixes display for things like cdrom drives
...
also error hugely if disk mounting fails
SVN revision: 72013
2012-06-12 10:26:39 +00:00
6534bd32cf
fix stringshare misuse
...
SVN revision: 72002
2012-06-12 09:29:45 +00:00
40d622e574
fix mount point deletion
...
SVN revision: 71999
2012-06-12 09:18:05 +00:00
36793fbc58
ignore internal drives with eeze mounting
...
SVN revision: 71996
2012-06-12 08:54:32 +00:00
508cfe9bd8
fix icon presentation with eeze mounting
...
SVN revision: 71993
2012-06-12 08:26:07 +00:00
3a017c0a79
eeze mounting now mounts to $E_HOME/fileman/$UUID, also reuse some code
...
SVN revision: 71991
2012-06-12 08:06:11 +00:00
f54bdaab13
allow for cases where E_LIB_DIR may be NULL by using PACKAGE_LIB_DIR instead: this helps with debugging
...
SVN revision: 71990
2012-06-12 08:04:13 +00:00
892861da0a
efm ipc now only tries to handle its own events instead of trying to take over the world
...
SVN revision: 71987
2012-06-12 07:57:40 +00:00
6ffa77d7f1
fix efm ipc read error
...
SVN revision: 71955
2012-06-11 15:00:18 +00:00
5111448060
formatting
...
SVN revision: 71954
2012-06-11 14:50:59 +00:00
de934e4c55
abort if e_ipc connection can't be made, also return a value on exit...
...
SVN revision: 71953
2012-06-11 14:46:10 +00:00
4adf0b17e4
efm volume catch-all
...
SVN revision: 71948
2012-06-11 13:27:07 +00:00
cd4539e642
more efm logging updates, only create signal handlers if they don't exist
...
SVN revision: 71947
2012-06-11 12:35:37 +00:00
33562f92a1
use eina_log for dbg messages, remove call to IdUsage which is never checked
...
SVN revision: 71943
2012-06-11 09:59:05 +00:00
70d21a1f44
e: move everyone to use eina_file_direct_ls and friend.
...
NOTE: I think, but I am not sure yet, that only EFM should
do this kind of operation or it could hard lock E17.
SVN revision: 70546
2012-04-30 07:07:33 +00:00
Vincent Torri
c30aaf8dde
e17: remove some shadow variables
...
SVN revision: 70190
2012-04-15 08:09:56 +00:00
Vincent Torri
c24b9f7aee
whitespaces--
...
SVN revision: 70188
2012-04-15 07:21:00 +00:00
761fb56e5f
From: Sergei Kabanov <s.kabanov@yahoo.com>
...
Subject: [E-devel] Fix udisks support for e17
as per advice of Michael Blumenkrantz
sending this patch for testing.
With this patch external devices have icons on desktop,
and devices can me mounted/unmounted/ejected.
SVN revision: 69827
2012-04-01 14:56:51 +00:00
0784943ae3
account for "" with getenv for hahas
...
SVN revision: 65390
2011-11-18 19:25:19 +00:00
8c9d0f0aa0
use helper macro for eeze scanner edd setup
...
SVN revision: 65389
2011-11-18 19:24:21 +00:00
330a63e43d
try introducing a delay after starting eeze scanner to make socket connection more successful
...
SVN revision: 65382
2011-11-18 09:29:08 +00:00
Vincent Torri
3a2cdebbbf
E17: fix eeze mount detection and build, reported by Jochen Schröder
...
SVN revision: 65368
2011-11-18 06:56:07 +00:00
c2b9cb4b56
slightly better debug info for eeze scanner connection
...
SVN revision: 65361
2011-11-18 04:55:52 +00:00
65a1d27500
big eeze mounting overhaul: things will "probably" work now. status increment to 95% on http://trac.enlightenment.org/e/wiki/Release
...
SVN revision: 62881
2011-08-26 20:35:22 +00:00
1a13f8c26f
E: Make E work with the new XCB stuffs. This breaks out e_alert into
...
it's own utility (as per raster's request/idea). Remove explicit
x_clags in Makefile.am(s) as they are no longer needed.
NB: I added some additional libs to the precache stuffs (even tho it's
not used right now). Also a newer e_main (more optimized).
NB: IF you are brave and want to test this, build evas w/ xcb, build
ecore w/ xcb, then rebuild E. Also, disable building opengl in both
evas & ecore (it's not ready for public consumption when paired w/ xcb).
SVN revision: 61680
2011-07-25 09:40:18 +00:00
8aacd8b006
in a hilarious turn of events, I had forgotten to commit the rest of this dso fix.
...
SVN revision: 60937
2011-07-02 12:01:24 +00:00
863390cde3
add check for mount success to counteract some eeze bug, unlink tmp mount point directory on umount/eject
...
SVN revision: 60867
2011-06-30 08:16:43 +00:00
3b5005cb82
whoops, broke this before commit and forgot to put it back
...
SVN revision: 60865
2011-06-30 07:02:36 +00:00
719917dbeb
eeze mounting - 95% complete: needs some tweaks to get it working but I figured I'd commit now for people to play with since it shouldn't break anything...
...
SVN revision: 60855
2011-06-30 03:54:28 +00:00
bcb9dd3cda
fix ipc segv when other ecore exe callbacks are present
...
SVN revision: 60854
2011-06-30 03:16:56 +00:00
18835fd017
another null deref
...
SVN revision: 56149
2011-01-16 01:26:51 +00:00
baa156f189
okay, so to check for udisks I've done the following:
...
1) set a signal handler to watch for udisks starting
2) check for udisks already running
3) send dbus method call to udisks regardless of run state
4) free error which is 100% guaranteed to occur
5) either pick up udisks from signal handler or from random dbus call
6) finally start efm
7) drink heavily.
SVN revision: 56055
2011-01-12 01:44:08 +00:00
e232eefc31
this should activate udisks if it wasn't previously running
...
SVN revision: 56054
2011-01-11 23:38:42 +00:00
Carsten Haitzler
d8f3611ab1
make udev/eeze mounting and volumes work on ubuntu 10.04... :)
...
SVN revision: 55993
2011-01-08 17:30:38 +00:00
8babc3a6f0
the futile struggle to avoid blank device labels continues
...
SVN revision: 55991
2011-01-08 06:40:41 +00:00
9865da8663
better removable media detection
...
SVN revision: 55990
2011-01-08 06:28:55 +00:00
3e6ccf89ee
NULL out pointers after op completes or fails
...
SVN revision: 55988
2011-01-08 05:55:25 +00:00
8d90d154f8
fix drive type detection
...
SVN revision: 55987
2011-01-08 05:14:19 +00:00
7396fa5d00
add some initial detection for luks encrypted fs types
...
SVN revision: 55962
2011-01-07 00:47:49 +00:00
7f3afa0d00
only track removable drives, add workaround for devices which are their own parent device
...
SVN revision: 55921
2011-01-06 03:53:34 +00:00
ef105564ba
with this commit, udisks mounting is now fully functional (wfm!) and has a number of benefits over the HAL backend, such as being able to automount media that's in your fstab
...
dev notes: changes to efm were required for this to work since udisks doesn't report back a mount point upon executing a mount command, so the actual dir listing/display must
be delayed by another callback until we actually know where the disk is to avoid opening a random directory
SVN revision: 55916
2011-01-06 01:35:41 +00:00
Carsten Haitzler
Mike Blumenkrantz
Ian Lee
Lucas De Marchi
Mike McCormack
José Roberto de Souza
Mike Blumenkrantz
Sebastian Dransfeld
Chidambar Zinnoury
Christopher Michael
Nicholas Hughart
Vincent Torri
Cedric BAIL
Sergei Kabanov