Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
This makes the first level of the menu simpler. If you want the "Lost
windows" on the main menu back, make sure you remove the "if (dat)"
branch inside _e_int_menus_clients_pre_cb() otherwise you get duplicated menus.
SVN revision: 49199
* e_border_center() will center window in a better way, accounting
the shelves/panels instead of just centering on the screen. This is
better and most noticeable if screens are small and a big shelf on
just one edge.
* e_border_move_without_border(), e_border_resize_without_border()
and e_border_move_resize_without_border() will assume the given
values do not acount border/decorations (client_inset) and will do
automatically. As stated in documentation, this is specially useful
when it is a new client and thus have no decorations when it is
positioned, when decorations are added window would be placed at
wrong position. One can try this by adding efwin window overflowing
the bottom-right corner, closing it and when reopen fileman would
try to make it inside the screen, this would not work well with
part of the window still being outside.
* e_win_move(), e_win_resize() and e_win_move_resize() will now use
new e_border functions.
SVN revision: 40307
maybe this is too much for a feature freeze phase, but this is
annoying for users, sometimes your menu looks one way, sometimes
another. Now it will always look the same, alphabetically ordered.
If it breaks anything before Monday revert!
SVN revision: 40205
This cleanup replaces snprintf() usage with specific calls, they have
the benefit of being cleaner (so easier to grep), typing less and also
marginal speed up compared to the other (specially concat_static),
although those are rarely used in critical paths.
I'm testing it for some time and seems to not break anything, but let
me know of any problem. If you can review the patch and try to spot
incorrect names, please do.
SVN revision: 40014
You will probably loose desktop icons until you get a fresh profile. Or you can edit the
.desktop files in .e/e/fileman/favorites (new icons name are: user-desktop, user-home, computer and user-temp)
Sorry for bothering... the next commit should be the last ;)
SVN revision: 39419
e_util_menu_item_fdo_icon_set to e_util_menu_item_theme_icon_set
As it looks for icons in e theme AND in fdo icon themes.
* Use the new function everywere instead of e_util_menu_item_edje_icon_set,
that is now marked as DEPRECATED
You should not see any difference with this commit. With the next few commit I'm
going to rename all the icons in the theme following fdo standard. I will not change
any icons, just rename them to match fdo ones.
SVN revision: 39370
* etk,
* PROTO/exalt,
* E-MODULES-EXTRA/diskio,
* E-MODULES-EXTRA/drawer,
* E-MODULES-EXTRA/penguins,
* E-MODULES-EXTRA/slideshow,
* E-MODULES-EXTRA/mail,
* E-MODULES-EXTRA/forecasts,
* E-MODULES-EXTRA/iiirk,
* E-MODULES-EXTRA/places,
* e,
* ewl,
* ecore,
* elitaire,
* entrance,
* e_dbus,
* efreet: Here we go, move from Ecore_List to Eina_List.
NOTE: This patch is huge, I did test it a lot, and I hope nothing is
broken. But if you think something change after this commit, please
contact me ASAP.
SVN revision: 39200
e_menu had this behaviour that submenus were not deleted
automatically, relying on the parent menu to hook to post_deactivate
and then delete them.
This was good because maybe you don't want to delete these children,
you might want to reuse them sometime.
But it ended that nobody was using this feature, and worse: most use
cases were failing to delete these children, causing memory leak.
This commit changes the default behaviour and thus remove all the
existing code that was replicating such work. If one want the old
behavior, just call e_menu_item_submenu_set(mi, NULL) and it will be
unbounded from the parent.
If you experience any problems with that, try adding some printf()
before _e_menu_free() and _e_menu_item_free() and print some relevant
information like m->category and m->header.title or mi->label in order
to figure out the problematic menu.
SVN revision: 38528
But is so big i fear i could have broken some piece of code. So report any wrong
behaviour to me (cedric on #edevelop).
So moving e17 and efreet to eina_hash. With a little efreet API break so they
must come together.
SVN revision: 38185
now). syscon has a poup with buttons (configurale) that offer all the
logout/reboot etc. stuff. also able to extend with more items or inline them
into the theme too.
not complete. need config for being able to extend the syscon popup (and use
it) and no gui config for configuring what should appear and how it should
look. possibly theme should have custon elements for the ones curently using
button + icon look. also no keyboard control.
SVN revision: 37797
1. configure/build changes to allow cross-compiling painlessly
2. pager module namespace changes - this was still dirty afdter the namespace
cleanup, so clean it up
3. add a powersave subsystem - doesnt have an "automatic" way to turn on and
off right now, this i think is best provided by modules (that do things like
monitor acpi status's (eg close lid of laptop), AC power status etc. etc.
this allows e to nicely defer "power" expensive actions to avoid disk
spinups etc.
4. move to use the new ecore poller system - discussed long ago as part of
power management/saving issues. now it exists
5. add a canvas idle flush call that helsp cope with the new shm greedy
software x11 engine stuff
6. use the new powersave subsystem where appropriate
7. fix non-zeroed/initted memory access in e_fm_main
8. fix mem leak for e menus
9. remove ipc handlers for changed/removed config values
10. use animaotr not timer for menu scrolls - then menu scrolls obey the fps
config
11. fix up timer/poll happienss of cursor idle stuff
12. remove avoid damage from popups for now - causing problems
13. change battery and temp readouts to b e shorter so they fit
14. pager can emit signals on focus change for mini-windows now
15. temperature module now uses a slave process and uses stdin/out to talk to
it and get output - this makes e smoother as in my expereicne i found getting
the temp on my laptop actually took like 200ms so e "hang" for 200ms while
reading the acpi files - so now the subprocess does it and just writesa back
to e when it gets it.
ecore:
1. add ecore_pollers. see the documentation on them in doxygen comments :)
2. fix timers to only go off when they have to - bug there that made e's
select time out a LOT more than it needed to. defensive coding hid the
problem. now fixed. e should be much more power friendly now.
3. formatting/niceness in ecore_exe stuff
4. some comments on comments with SIGIO ideas vs. select
5. add call to be able to add an idle enterer at the start of the list of
them, not just the end (as has been the default)
6. fix ecore_evas to support auto evas idler calls after 0.5 secs of idle in
all canvases - and to do it right
7. if argb destination - set the shape EVENT shape (to mask out events in
transparent regions much like shape does withotu translucency)
8. in ecore_x add support for the event shape
evas:
1. fix cache to work properly and not just always fill up (as it seemed to
like to think cahce useage dropped below 0 when it didnt and thus just
over-fill)
2. software x11 engine now ONLY uses shm segments - no ximages over the
socket. this ximage hack was there to avoid the 2 round trips involved in
setting up an shm image - now i mitigated that wih an shm image cache pool.
it keeps shm images around and repurposes them for new update regions if
appropriate. this means many fewer shm creates (about 1/100th the number) and
since we recycle the memory less 0 memory page filling by the kernel - in the
end, i recorded about a 10-20% speedup over the old software x11 engine.
simple tests i have seen up to 120% speedups. idle flush now does something -
it frees all the cached shm segments. it has a hard-coded limit of 4mb worth
of shm segments (or 32 segments - whichever comes first) to keep around. once
can never complain much about speedups methinks :). also evas will defer sync
until the NEXT frame is written - this means evas can calculate the next
frame of data while x dma's/copies the images to the screen at the same time
(if you hve a dual core or multi-cpu machnike or your xserver is able to use
DMA to copy image data to the screen/video ram then this should see a decent
speedup).
SVN revision: 33448
Add edit dialog for ibar/startup/restart.
Remove 'Application Menus' from e_int_menus until a full Menu editor is made.
Can now edit ibar/startup/restart & Favorites.
SVN revision: 29403
so that the plethora of meaningless directories is no longer presented to
the user. The bits of text all change to suit the task. Sort was changed
to all to help reduce the confusion.
SVN revision: 27140
filemanager window. this is more for me to test dnd code and get that all
going right etc. etc. so BEWARE. yes it doesnt do a lot of things right - i
know. am working on it. :)
SVN revision: 26210
sysactions more comprehensive and able to handle multiple groups a user
is a member of - config modified to handle common ones i find on debian
and ubuntu that "console" users tend to be added to. add divider in config
menu. work a tad more on fm2 dnd.
SVN revision: 26186
finish the FDO directory code I have half completed. For some strange
reason, this triggers a crash in rsvg, trying to get it to load a .eap
file. That is strange in itself. More investigation is required by
someone that knows evas better than me.
SVN revision: 25960
sys actions check error/status etc. logout implemented, and used. need to
have status for reboot/halt and for suspend and hibernate.
SVN revision: 25656
1. cleaned up actions for restart and exit
2. made main menu cleaner in just using the actions
3. added ilits unselect calls for ilist smart and widget
4. patch for cpufreq to set all cpu clocks
5. fix battery module to handle broken acpi impl's that don't report drain rate
6. add e_sys subsystem - for executing system sensitive stuff like halt, reboot
suspend, hibernate etc. this also covers exit, restart and logout. logout
is currently dormant and just an action - not bound or in a menu. not
complete anyway (no code for it). halt and reboot should probably use
logout logic to shut down apps - i will recycle it. i added a suid root
binary to do the actions - uses a system config (default one supplied that
is secure - root will need to modify it to allow things).
7. fixed suid install hook for cpufreq
8. added sysconf dir to build for sys config file.
9. pants on
SVN revision: 25395
left side to the right side, or to ibar and other places. Just the
skeleton for comment while I make it work.
Some filtering and categorising widgets are needed for the left side.
The right side needs to show the contents of the .order files, and
prevent the user from deleteing standard directories, while enabling
them to create and delete sub menus. Probably fm is not a good choice for
the right side.
SVN revision: 25172
now, the menu icon can be set properly upon realization with the e_menu_item_realize_callback_set function. rewrote the clients menu to use the border icon, and be sorted like the winselector.
SVN revision: 25026
~/.e/e/applications/menu/all
~/.e/e/applications/menu/favorites
The first one is all the converted FDO menus, which will track changes
to those menus. The second one is the original favorites menu, which
the user can edit to their hearts content.
WARNING - will break your Favorite menus, coz it has moved.
SVN revision: 24979
Theme icons and .eaps are searched first.
Still needs some work and a lot of testing. Also needs optimising,
which will come when I go over the caching code later.
Ibar and ibox modules read the .eap directly, so I need to convert them
seperately.
Next I'll spend some time with valgrind, things are leaking.
SVN revision: 24795
* entry dialog becomes object - supports initial text contents of the entry
* fm2 gets menu patch (heavily worked so its safe) so u can delete and rename
files (and dirs) that you have permission to do so with.
* picutre importing disables or enables the scale and encoding stuff
depending on what is selected
* more widgets support enable/disable
* importer detects duaplicate destination target filenames and tries
alternate names.
* fsel widget displays extensions by default.
* test filemanager menu gone
* pants on!
SVN revision: 24589
first a few patches - authors mailed.
then - bg selector work. and a few sample bg's. system bg's dir and user bg
dir - new bg dialog should also handle multihead simply too. picture select
button does work - but its only as smart as the old one (the code was built
off the old one). that needs a little work, but now the bg selector is fast
and slick - comes up instantly. resiable too.
SVN revision: 24443
module.eap files being installed - and using the e_apps api to load them and
ask for a name. Also icon is expected to be in this file too and i have
removed the info func call from modules as well as config_menu, module menus,
and other cruft in moduel structs. this also means revving the module api
version and saving users from a "if i recompile it will work" thing. :)
moduels need serious updates, not just a recompile for this. your modules
WILL break.
SVN revision: 23045
Miculcy Brian
Christopher Michael
Lucas De Marchi
Carsten Haitzler
Cedric BAIL
Gustavo Sverzut Barbieri
Hannes Janetzek
Sebastian Dransfeld
Daniel Kolesa
Iván Briano
Viktor Kojouharov
Davide Andreoli
Chidambar Zinnoury
toma
Eric Schuele
lok
Peter Wehrfritz
David Walter Seikel
rephorm
manowarrior
sebastid
sndev
xcomputerman