Mike Blumenkrantz
e4f3179731
block keyboard sending for wl clients if a compositor grab is active
...
fix T3599
2016-05-10 13:00:01 -04:00
Mike Blumenkrantz
f37590209d
disable focus effects for windows with csd
...
fix T3408
2016-05-10 12:35:06 -04:00
Mike Blumenkrantz
16797009c0
ensure child windows are placed on screen
...
when centering a child over its parent, checks were not made to ensure that
by centering the child it had not gone offscreen
2016-05-10 12:13:12 -04:00
Mike Blumenkrantz
7ebaa1ffb3
make init fail if a dbus session connection cannot be created
...
typically this indicates a broken session manager or someone trying to run
a wayland session without using dbus-launch
2016-05-09 13:30:40 -04:00
Mike Blumenkrantz
c286fe48c0
prune uuid remembers on clean startup
...
ensure that stale sessions are destroyed regularly
2016-05-06 14:35:16 -04:00
Mike Blumenkrantz
411f378998
flag wl surfaces as internal during create() based on pid matching
...
fix T3596
2016-05-06 13:52:10 -04:00
Mike Blumenkrantz
ef1772b8cb
implement wl client session recovery
...
another small feature patch brought to you by insomnia
#SamsungFeatures
2016-05-05 15:47:55 -04:00
Mike Blumenkrantz
e0d1a572a1
bad copy/paste in _e_place_desk_region_smart_obstacle_add()
...
CID 1354988
2016-05-05 09:36:42 -04:00
Mike Blumenkrantz
4639062133
uninitialized vars in e_client_maximize_geometry_get()
...
CID 1354989, 1354990
2016-05-05 09:35:51 -04:00
Mike Blumenkrantz
32cf7162ed
ensure lifetime for wl client focus timer
...
fixes some focus-out crashing
2016-05-03 20:27:02 -04:00
Mike Blumenkrantz
69370250d1
don't refocus deleted clients during wl compositor grab
2016-05-03 20:27:02 -04:00
Mike Blumenkrantz
53e0bf08bc
further optimize window smart placement by reducing obstacle calcs
...
previously the obstacle list would build from the bottom up, skipping
fullscreen and maximized windows. this would lead to cases where windows
would be moved to avoid windows which were fully obscured, and also cases
where unnecessarily large amounts of looping would occur related to the
existence of maximized windows
2016-05-02 18:37:17 -04:00
Mike Blumenkrantz
049deb2c12
directly load extra wl modules during compositor init
...
speed++++++++
2016-04-28 17:58:45 -04:00
Mike Blumenkrantz
01ac84035f
ensure that the startup apps cache handler has run before trying to start apps
...
fixes timing issues when running startup apps
2016-04-28 17:58:45 -04:00
Mike Blumenkrantz
20f1aa8727
feed mouse up events to internal wins before mouse out during action exec
...
ref 609276e12d
fix T3347
2016-04-28 12:00:17 -04:00
Mike Blumenkrantz
502662456f
Revert "handle recursion more effectively in e_menu_hide_all()"
...
This reverts commit 5764bf680e
.
this was a workaround for a behavior change in efl
2016-04-27 11:27:56 -04:00
Mike Blumenkrantz
5764bf680e
handle recursion more effectively in e_menu_hide_all()
...
there were recent changes to evas object deletion mechanics which caused
this to begin crashing due to recent changes to evas object deletion mechanics
2016-04-26 10:43:07 -04:00
Mike Blumenkrantz
2c1e864fbc
move wayland surface E_Client del check to a place where it's more useful
...
completely breaks wayland on first commit? off to an auspicious start!
ref d9679f765f
2016-04-26 08:58:50 -04:00
Eduardo Lima (Etrunko)
8acbf5d013
Fix warnings about uninitialized use of variables
...
src/bin/e_zone.c: In function ‘_e_zone_useful_geometry_calc’:
src/bin/e_zone.c:1272:14: warning: ‘geom.h’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (h) *h = geom.h;
^
src/bin/e_zone.c:1271:14: warning: ‘geom.w’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (w) *w = geom.w;
^
src/bin/e_zone.c:1270:23: warning: ‘geom.y’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (y) *y = geom.y + zy;
^
src/bin/e_zone.c:1269:23: warning: ‘geom.x’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (x) *x = geom.x + zx;
^
src/bin/e_client.c: In function ‘e_client_maximize_geometry_get’:
src/bin/e_client.c:3754:16: warning: ‘y’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (my) *my = y;
^
src/bin/e_client.c:3753:16: warning: ‘x’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (mx) *mx = x;
^
src/bin/e_client.c: In function ‘e_client_fullscreen’:
src/bin/e_client.c:4032:21: warning: ‘h’ may be used uninitialized in this function [-Wmaybe-uninitialized]
ec->saved.h = h;
^
src/bin/e_client.c:4031:21: warning: ‘w’ may be used uninitialized in this function [-Wmaybe-uninitialized]
ec->saved.w = w;
^
src/bin/e_client.c:4030:21: warning: ‘y’ may be used uninitialized in this function [-Wmaybe-uninitialized]
ec->saved.y = y;
^
src/bin/e_client.c:4029:21: warning: ‘x’ may be used uninitialized in this function [-Wmaybe-uninitialized]
ec->saved.x = x;
^
Signed-off-by: Eduardo Lima (Etrunko) <eblima@gmail.com>
2016-04-25 19:40:42 -03:00
Derek Foreman
d9679f765f
wayland: Fix crash when attempting to create surfaces for deleted clients
...
Internal clients can be deleted by keybind before the surface create
callback fires resulting in a NULL pointer dereference.
2016-04-25 16:40:32 -05:00
Mike Blumenkrantz
c3700297d7
remove explicit edje_init/shutdown calls
...
elm already handles this
2016-04-25 12:55:21 -04:00
Mike Blumenkrantz
fcc996545c
always end drag operations on failure
...
fix T3507
2016-04-25 12:24:44 -04:00
Mike Blumenkrantz
05451aeb36
treat POPUP_MENU window type as an override window for comp theme matching
...
ensures that the menu theme gets picked for wayland popups; probably needs
a more comprehensive solution for xdgs v6
2016-04-22 15:28:54 -04:00
Mike Blumenkrantz
2014de2fe6
Revert "do not revert client focus except for normal and dialog windows"
...
This reverts commit 5b119d437a
.
I give this solution a B- for working but also totally ruining everything
2016-04-22 14:47:35 -04:00
Mike Blumenkrantz
5b119d437a
do not revert client focus except for normal and dialog windows
...
fix T3432
2016-04-22 13:15:33 -04:00
Mike Blumenkrantz
5c0729221e
only set "dialog" border for transient clients if window type is unset
...
fix T3157
from https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html :
_NET_WM_WINDOW_TYPE_DIALOG indicates that this is a dialog window.
If _NET_WM_WINDOW_TYPE is not set, then managed windows with
WM_TRANSIENT_FOR set MUST be taken as this type
2016-04-22 12:51:12 -04:00
Mike Blumenkrantz
b94023c412
set NULL image data in _e_comp_object_pixels_get() on failure
...
ensure that nothing is rendered here
2016-04-22 12:45:26 -04:00
Mike Blumenkrantz
6f83ec7329
do not show unsized comp objects during theme apply
2016-04-22 12:45:04 -04:00
Mike Blumenkrantz
d584c9a095
ensure resize is still deferred for changes.shape clients during failed resize
...
ref c212bb4e21
2016-04-22 12:13:11 -04:00
Mike Blumenkrantz
84cf7743b6
set NULL image pixel data during x11 render when no damages exist
...
fixes a weird corner case where shapeless clients try to sneak a fast one
by and you gotta be like http://i.imgur.com/irwmnCT.webm
ref T3157
2016-04-21 18:21:26 -04:00
Mike Blumenkrantz
881ccfc768
slightly simplify image data setting in e_comp_object_render()
2016-04-21 18:09:18 -04:00
Mike Blumenkrantz
77e8ab0926
remove unnecessary conditional in e_comp_object_render()
2016-04-21 18:06:58 -04:00
Mike Blumenkrantz
2a67b3a899
ensure damages do not get added for shapeless x11 clients
...
ref 32d4c2f2b9
ref T3157
2016-04-21 18:04:16 -04:00
Mike Blumenkrantz
c212bb4e21
don't defer resizes+queue render updates for shapeless or pending shaped clients
...
this basically guarantees a misrender
2016-04-21 18:01:42 -04:00
Mike Blumenkrantz
a97a50b306
don't force full damage on x11 override clients
...
reverts f6be761226
this didn't fix anything and can cause irregularities in rendering
2016-04-21 16:32:01 -04:00
Mike Blumenkrantz
019318b88f
do not attempt to show x11 override windows
...
fix T3444, T1759, T2735
2016-04-21 15:28:55 -04:00
Mike Blumenkrantz
f36f2d16bc
unify client filtering checks from e_place_desk_region_smart()
2016-04-21 14:48:49 -04:00
Mike Blumenkrantz
08cb34f7ad
ensure that wl clients do not run extra render on hide twice
...
fixes crash when applications crash
2016-04-21 13:55:23 -04:00
Mike Blumenkrantz
54e6da6576
only update wl dnd actions when applying focus
2016-04-21 13:55:23 -04:00
Mike Blumenkrantz
aefa7d3795
always update wl dnd offer actions
2016-04-21 13:55:23 -04:00
Mike Blumenkrantz
42d67d51c3
do not perform input ungrab twice during dnd end in wayland
...
this was happening in both drag free and drag end: once is sufficient
2016-04-21 13:55:23 -04:00
Carsten Haitzler
76ed021006
e - e_start - update mtrack to use new debug mode for hunting bugs
...
this won't affect anyone who doesnt have a ~/.e-mtrack file ... this
is for debugging purposes and no others
2016-04-21 09:42:13 +09:00
Mike Blumenkrantz
fc759b1f0c
more accurately reject wl selection setting based on whether serial is invalid
...
copycopycopycopy
2016-04-20 12:38:08 -04:00
Mike Blumenkrantz
9dd36ff01c
apply formatting rules to e_comp_wl_data.c
2016-04-19 17:38:22 -04:00
Mike Blumenkrantz
bfd204be71
update wl dnd/clipboard support to v3 of protocol
...
this code is mostly copied from weston:
78d4bf9a3ec990dceee23fd53962a69891352a0e
9c93179023fe894e417ccd20533d72d672d976fc
b288988e831cee3deb7f8bb1a3f440c86230dd9f
4061e2b67e62d5d2a635f0b87098f331082e8145
credit to Carlos Garnacho <carlosg@gnome.org> as original author
ref T3455
2016-04-19 17:34:58 -04:00
Mike Blumenkrantz
33e23c7364
add copyright headers (MIT) from weston to e_comp_wl_data
...
these files were created containing code which was very obviously copied from
weston. when copying code, copyright headers must also be copied in order to
comply with licenses.
2016-04-19 17:27:17 -04:00
Mike Blumenkrantz
6aee63d1dc
redo wl (xdg)shell surface ping
...
- remove (wrong) global variables which tracked client-specific resources
- start ping upon creating a shell surface
- track client-specific shell resources on a per-client basis
2016-04-18 15:37:22 -04:00
Mike Blumenkrantz
536a3a7ff6
make startup/restart app exec timing protocol-specific
...
this allows different display protocols to start their applications at
different times to ensure that any initialization has completed prior to
starting anything requiring a window
fix T3475
2016-04-18 15:27:47 -04:00
Mike Blumenkrantz
40af8d5193
reject xwayland clients in wl client resize handlers
...
fix T3461
2016-04-18 13:15:09 -04:00
Mike Blumenkrantz
a1d0f97968
do not perform x11 mouse/wheel grabs for ANY binding contexts
...
these are traditionally compositor-only actions which may filter through
many different objects but are not meant to activate on window contents
resolves issues where some related mouse bindings were blocking input on windows
under x11
#thingsthatneeddocs
2016-04-18 12:55:30 -04:00
Mike Blumenkrantz
fefdca1f00
redo e_place_desk_region_smart() to handle multiple screens
...
this code is unbelievably bad.
fix T3404
2016-04-12 13:33:54 -04:00
Carsten Haitzler
1db14b547a
e intel - fix number 2
...
so the crazieness in e+intl was because of eina_str_tolower()
silliness... so work with it and another patch to follow on from
01e53356f8
...
@fix
2016-04-12 16:31:32 +09:00
Carsten Haitzler
01e53356f8
e intl - fix string buffer length size
...
this intl code was broken using sizeof a pointer (sizef char *) vs
size of the actual buffer used.
@fix
2016-04-12 14:22:20 +09:00
Mike Blumenkrantz
48fbfa2908
reduce efl version req to 1.17.0, make new gadget stuff 1.7.99+ at runtime
2016-04-11 15:15:51 -04:00
Mike Blumenkrantz
7db999dec1
xkb compiler warns--
...
ref 53636dd87c
2016-04-11 15:05:32 -04:00
Mike Blumenkrantz
c9e168460e
ensure that wl keymap is initialized, even if no configuration exists
...
fixes no-config crash
ref 62440eb5fe
2016-04-11 14:53:52 -04:00
Mike Blumenkrantz
3df1e04ded
bump modapi
2016-04-11 14:28:52 -04:00
Mike Blumenkrantz
4cbf81b1e8
add E_Client->saved.frame to handle mismatched csd states
...
if csd exists in only one of (before || after) a maximize/fullscreen,
this provides info so that the right size can be used when restoring
geometry
...again
2016-04-11 14:28:31 -04:00
Mike Blumenkrantz
005ad4e986
fake client-side geometry during wl (un)maximize interception
...
fixes internal window maximize
2016-04-11 13:41:19 -04:00
Mike Blumenkrantz
1facf33ddf
ignore maximized+fullscreen windows when placing new clients
...
this should improve perf and placement
ref T3404
2016-04-11 12:02:00 -04:00
Marcel Hollerbach
53636dd87c
e_xkb: use new_keyboard event to restore known layout
...
Summary:
the new_keyboard event is now used to restore the known layouts out of
the config, if the state is changedthe new group is safed in the config
which will be safed later.
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3877
2016-04-08 23:30:22 +02:00
Mike Blumenkrantz
6df8f5a806
Revert "do not update client saved states during maximize if client is animating"
...
This reverts commit 227776985e
.
impossible case, too much wayland
2016-04-08 17:23:06 -04:00
Mike Blumenkrantz
2cecb9369e
bump modapi
2016-04-08 16:53:08 -04:00
Mike Blumenkrantz
4c6a4ea4ce
track client maximize animation agents, delete upon beginning new animation
...
fixes an issue where unmaximize+maximize chaining would break client sizing
2016-04-08 16:45:56 -04:00
Mike Blumenkrantz
cfca88bc95
simplify maximize animation re:maximize_override unsetting on no-animate
2016-04-08 16:43:46 -04:00
Mike Blumenkrantz
63af4ea865
buffer server-side (un)maximize commands to ensure synchronization in wayland
...
maximize is client-initiated and compositor-enforced in wayland, meaning that a
maximize should only be acted upon in the compositor after the client has
acknowledged that it has transitioned into the maximized state (likely removing
part of its csd region) and has resized itself to match the expected maximize
size
fix T3297
2016-04-08 16:08:32 -04:00
Mike Blumenkrantz
98934fb0e9
make (un)maximize_pre callbacks capable of rejecting the maximize operation
...
this is useful when subsystems need to know that a client wants to maximize
but need to delay that maximize for a later point
2016-04-08 16:07:40 -04:00
Mike Blumenkrantz
a3da199685
disable maximize anims for www-compatible wl surfaces
...
due to www modifying the csd region, animating resizes will trigger
unsolvable race conditions which break windows
2016-04-08 16:06:19 -04:00
Mike Blumenkrantz
b0f2443042
improve behavior of wl client buffered state changes during commits
...
apply e_config maximize policy for buffered (un)maximize, unset buffered states
after applying them
2016-04-08 16:05:00 -04:00
Mike Blumenkrantz
9578ae615f
do not force wl client state update (configure) on (un)maximize done cb
...
this is spurious
2016-04-08 16:04:19 -04:00
Mike Blumenkrantz
b17999de8d
do not sent wl *shell configures from resize callback during maximize
...
this is spurious
2016-04-08 16:03:28 -04:00
Mike Blumenkrantz
a7adf21c88
add E_Client->maximize_anims_disabled to selectively disable maximize anims
...
for some clients it's impossible to animate resizing due to various race conditions
being created which will break the client
2016-04-08 16:01:55 -04:00
Mike Blumenkrantz
b4b682cd6a
make a number of client functions take const E_Client*
2016-04-08 15:57:21 -04:00
Mike Blumenkrantz
8d56ff3eec
break out client maximize/unmaximize calc functions into preview functions
...
these enable "previewing" a client's size after toggling the maximize state,
not accounting for any csd or ssd sizing changes
2016-04-08 15:55:27 -04:00
Mike Blumenkrantz
227776985e
do not update client saved states during maximize if client is animating
2016-04-08 12:23:19 -04:00
Mike Blumenkrantz
71c1669036
change client un/maximize_pre callback location to occur after safety checks
2016-04-08 12:22:47 -04:00
Mike Blumenkrantz
4cc66119c5
make e_client_has_xwindow() more wayland-only friendly
2016-04-08 11:51:18 -04:00
Mike Blumenkrantz
dea3ae21ad
directly include e.h in efm device backends
...
fixes some compile errors related to include ordering
ref 68587276cf
2016-04-08 11:50:27 -04:00
Mike Blumenkrantz
9516031e93
only apply buffered wl client maximize during configure if client is not maximized
...
fixes directional maximize
2016-04-07 14:00:25 -04:00
Mike Blumenkrantz
657bc713c7
don't send duplicate configure to wayland clients during unfullscreen
...
this causes unnecessary client-side resizing
2016-04-07 13:56:03 -04:00
Derek Foreman
b8ab7b0738
Remove unwanted debug detritus from last commit
...
#Oops
Reviewed-by: Mike Blumenkrantz <zmike@osg.samsung.com>
2016-04-07 13:29:58 -04:00
Derek Foreman
68587276cf
Clean up some header inclusion
...
Including certain headers in the wrong order can cause problems if
we're configured to use beta api (right now wayland forces this).
In most cases we should just be including e.h and not the individual
EFL headers anyway. This fixes some of that.
fix T3426, T3428
2016-04-07 13:14:43 -04:00
Mike Blumenkrantz
7e3c2b08ec
move buffered maximize/fullscreen for wl clients to occur before csd update
...
this ensures that all such operations calculate based on the correct csd state
2016-04-06 16:42:10 -04:00
Mike Blumenkrantz
14721bc116
do not unconditionally update position+size when changing wl client csd geometry
...
this breaks...everything
2016-04-06 16:40:42 -04:00
Mike Blumenkrantz
e9bca1abaa
Revert "add E_Client->saved.frame to handle mismatched csd states"
...
This reverts commit ae7af6b8ef
.
this was a workaround for an entirely different issue, and it didn't even
solve that issue
2016-04-06 16:39:55 -04:00
Mike Blumenkrantz
992e04feb2
wayland client maximize/fullscreen cleanups
...
ref da74e690f0
2016-04-05 16:54:04 -04:00
Mike Blumenkrantz
ae7af6b8ef
add E_Client->saved.frame to handle mismatched csd states
...
if csd exists in only one of (before || after) a maximize/fullscreen,
this provides info so that the right size can be used when restoring
geometry
2016-04-05 16:52:50 -04:00
Mike Blumenkrantz
da74e690f0
redo xdg shell to enforce double buffering of client-side configure serials
...
xdg shell configure states (maximize, fullscreen) return a client ack when the
client has applied the state. the ack, followed by the next surface commit,
indicates that the surface is ready to be transitioned into the configured state
2016-04-05 15:05:10 -04:00
Mike Blumenkrantz
d50a20f812
do not send shell configures for deleted wl clients
2016-04-05 15:04:35 -04:00
Mike Blumenkrantz
a99d505771
set WAYLAND_DEBUG=0 during wl compositor init
...
ensures that debug logs won't get both compositor and client output,
making the log impossible to read
2016-04-05 15:03:26 -04:00
Mike Blumenkrantz
f8bca98f35
reject client maximize attempts using identical maximize params
2016-04-05 15:00:54 -04:00
Mike Blumenkrantz
e4960ad652
set ELM_ACCEL=gl upon successfully creating a gl wayland compositor
...
...successfully
ref 4aecb7ad14
2016-04-04 16:06:52 -04:00
Mike Blumenkrantz
ed6448eb21
send fake www data during maximize
2016-04-04 14:03:17 -04:00
Mike Blumenkrantz
687b5fb6b6
set maximizing flag during maximize resizing for wl clients
...
a helpful indicator for when to avoid potentially leaking positioning info
2016-04-04 14:02:39 -04:00
Mike Blumenkrantz
6617a8440c
always set ec->maximize_override on unmaximize if maximize anims are enabled
...
this ensures that all cases of animation have the flag set
2016-04-04 14:01:30 -04:00
Mike Blumenkrantz
3f7e6dc359
wl popup surfaces should not receive focus on show if parent is not focused
...
fix T3339 harder
2016-04-04 12:51:29 -04:00
Mike Blumenkrantz
b9b9ed68b0
remove video child references from wl compositor
...
this is an x11-only thing
2016-04-04 12:51:20 -04:00
Mike Blumenkrantz
7541a51599
use zone geometry for shelf zone obstacles
...
shelves use relative coords, so zone obstacles must have adjusted coords
passed in order to calc correctly
fix T3404
2016-04-04 11:29:01 -04:00
Mike Blumenkrantz
dead7646d4
delete internal wayland elm windows in wl client delete request callback
...
fix T2874
2016-04-01 16:48:50 -04:00
Mike Blumenkrantz
8b8abb436d
restrict shelf border_fix to only affect clients affected by the shelf
...
fixes random other clients changing sizes based on irrelevant shelf hiding
2016-04-01 16:26:41 -04:00