Commit Graph

15250 Commits

Author SHA1 Message Date
Stefan Schmidt ff874b128a music-control: Do not leak the allocated metadata strings
Fix for ca07e7d505

Thanks are going to Davide Andreoli for spotting it.
2014-03-28 10:51:29 +01:00
Stefan Schmidt 4edf57320e modules/ibar: Fix condition check for edje emits
This fixes a copy and paste error which sneaked into
daa98e867d

CID 1194780
2014-03-28 10:14:37 +01:00
Mike Blumenkrantz 114b411da1 never use new clients for stacking
fix Tcedric
2014-03-27 21:27:51 -04:00
Mike Blumenkrantz da5bd16e12 greatly improve child dialog placement, FIXME--
fix T980
2014-03-27 19:47:31 -04:00
Mike Blumenkrantz ea3439b664 Revert "move comp object tiler creation to helper function to catch retries"
This reverts commit f4e4b2fc4f.

testing commit that wasn't supposed to go upstream
2014-03-27 17:01:22 -04:00
Mike Blumenkrantz d59fa0409c fix access module build
if nobody noticed this was even broken for 3 months, why is it still in the tree?
2014-03-27 16:54:58 -04:00
Mike Blumenkrantz e49b3beff1 ensure minimum X parent window size of 1x1
fix T1098
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz f4e4b2fc4f move comp object tiler creation to helper function to catch retries 2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 6308846480 don't refocus hidden clients on desk flip
probably fix T1083
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 7ccba3bdc3 null check _evry_items_sort_func() for users with broken systems
fix T1125
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 6e72796544 check key events for both key and keyname bindings
fix T1119
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 50a37adb6e ignore mouse movements on client during keyboard actions
fix T1097
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 3f10e7557f ignore X layer window mouse events
fix T1130
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 110f62ca61 always unclip/uneffect clients when changing desks
probably fix T1126
2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 53824eb309 redo input rects after comp effect layer changes
fix T1070
2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 18120e1b5a remove invalid shelf autohide window check which would always be wrong 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 42f43c9311 disable comp object animation hooks if animations are disabled 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz daa98e867d fix lots of edje emits on non-edje objects 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz f2f45428ff +e_icon_edje_get() 2014-03-27 16:47:18 -04:00
Stefan Schmidt 22278399d3 tiling: Free allocated memory on error path.
We don't use new_node in this code path. Free before returning.

CID 1186205
2014-03-27 16:06:06 +01:00
Stefan Schmidt ca07e7d505 bugfix: music_control: Use correct markup for metadata text.
We piped the plain metadata text to edje TEXTBLOCK which might interpret
some of the characters as markup. Better convert it to the correct markup
first. The actual bug case was a & in the metadata cut off the rest of
the text. Now we get the correct &amp before sending it of to edje.

Fixes T1061
2014-03-27 12:51:38 +01:00
Carsten Haitzler 1e50cb1dc6 don't delete client objects when _e_client_hook_call returns false.
_e_client_hook_call() returns false when object refcount hit 0... ie..
it's been deleted. it's simply invalid memory access to then del the
object thats already gone to 0 refcount and been deleted/freed.
2014-03-26 15:32:53 +09:00
Carsten Haitzler b6421e7660 tasks - fix tasks on other screens to properly show all window content
this fixes T1120
2014-03-25 22:44:04 +09:00
Mike Blumenkrantz 24296fa005 use eo to shut up harmless eo menu errors 2014-03-24 12:34:07 -04:00
Mike Blumenkrantz 3d8f5d3b05 add eo headers, aka Captain #define 2014-03-24 12:34:07 -04:00
Sebastian Dransfeld a08c40df7b ilist: Remove unused assignment
CID 1039758
2014-03-24 13:26:20 +01:00
Sebastian Dransfeld 68719520e6 fm: Check return of strrchr
strrchr can return NULL, so we need to check the return value.

CID 1039861
2014-03-24 13:23:39 +01:00
Sebastian Dransfeld 2d9f5764a3 fm: Fix weird test
ic is always true for this function, else dereference would fail. So the
only valid thing to check is whether we already have a drop_icon.

CID 1039829
2014-03-24 13:20:25 +01:00
Sebastian Dransfeld 81c384de9f dialog: allow setting of NULL icon
If NULL is passed as icon, icon should be disabled.

CID 1039951
2014-03-24 13:13:53 +01:00
Sebastian Dransfeld 168dc8ef38 comp: no need to assign pointer before return
As we return after the list free, no need to set the pointer.

CID 1087717
2014-03-24 13:02:56 +01:00
Sebastian Dransfeld ef208ad96b systray: deref pointer after check
CID 1193253
2014-03-24 12:59:14 +01:00
Mike Blumenkrantz 83475dad7e set wayland display socket based on e_ipc_socket name 2014-03-20 14:06:41 -04:00
Mike Blumenkrantz 2bbab7e525 export e_ipc_socket filename as extern variable 2014-03-20 14:06:41 -04:00
Tom Hacohen 07841a6b5e Tiling: start migrating the code to use smart callbacks.
Those are meant to be better than the e hooks.
2014-03-20 17:40:23 +00:00
Mike Blumenkrantz c47bf94cdf hook sticky smart callbacks properly inside comp object 2014-03-20 11:38:58 -04:00
Mike Blumenkrantz b5a04496b7 add stick/unstick client smart callbacks 2014-03-20 11:31:32 -04:00
Stefan Schmidt 04a5a11a8f e_pointer: Fix missing if for else if condition
Fixing devilhorns commit and run commit. If we have a condition we want
to check we need an else if not a simple else. Always compile before push.
Especially the small and simple changes. :)
2014-03-20 15:50:51 +01:00
Chris Michael d0b61e4b88 bugfix: Properly hide/show pointer_image & pointer_object based on if
the pointer is located on an existing canvas

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
Chris Michael 5ce5d2d90b bugfix: Set pass_events and layer of the pointer image if we are
creating a new one.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
Cedric BAIL ffe4bf794e e: let's just completely blacklist NVidia driver for Wayland. 2014-03-20 20:46:54 +09:00
Chris Michael db40e4b67e bugfix: Fix crash on eglTerminate with buggy Nvidia blob driver
NB: Thanks for the report cedric ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Chris Michael 52532f9a32 Don't leak the allocated client object if we are returning null from
e_client_new

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Chris Michael 5b77c566e6 Use ecore_wl functions to return the pointer location if we are
running as wayland-only

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Sebastian Dransfeld 30846ee4ea randr: Update lid status when outputs change
If we only have lid, it will be active even though lid is closed. If we
connect a monitor we want the lid to deactivate.
2014-03-19 13:37:34 +01:00
Chris Michael 75d25f8c47 Fix the "Fix more wayland crashes" commit so that we can build for
wayland-only again

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-19 07:47:20 +00:00
Mike Blumenkrantz c81e649992 fix more wayland crashes 2014-03-18 18:15:24 -04:00
Mike Blumenkrantz c04d754ac5 enabling drm output module should NOT require X-less build.
these defines all need to be changed from HAVE_WAYLAND_ONLY to something like WITH_X or we're going to have lots of problems with xwayland later on
2014-03-18 16:14:04 -04:00
Mike Blumenkrantz af3f435d98 systray stop crashing in wayland!!!! 2014-03-18 13:22:11 -04:00
Chris Michael 5c322c40c4 @bugfix: Set ecore_wayland into 'server mode' before we call init so
that it does not stall and we end up sitting forever.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 645cb48dd5 @bugfix: Check return of e_comp_wl_init and initialize ecore_wl library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 3d28a91c6b @bugfix: Create window pointer for wayland clients
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 9e68b402a4 @bugfix: Initialize the module idler even If we are wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 4bb1d8f390 @bugfix: Only load external compositing modules if we are wayland-only
@bugfix: Initialize e_comp_wl if we are wayland-only OR supporting
wayland clients.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael f3da557586 @bugfix: Fix e_win elm window trapping for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 160412dcf2 Simplify e_canvas_new code slightly for wayland-only and
wayland-client support.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael 3d10a3d34e @bugfix: Fix pointer to work in drm and also fix some formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael 915f8f0613 @bugfix: Fix building for WAYLAND_ONLY by using the proper define
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael a32d74d1c7 @feature: Add new drm compositing module
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Mike Blumenkrantz a2025ddaad ignore size change configurerequests during maximize if not also changing position
correcty fixes gtk window (un)maximize
2014-03-17 12:56:21 -04:00
Mike Blumenkrantz d8375aaf9d Revert "apply client resize limit for all possible size values during maximize calcs"
This reverts commit 08acb0c6aa.

fix T1102
2014-03-17 12:49:44 -04:00
Mike Blumenkrantz 9859daee07 bugfix: get entry width based on viewport size, not entry size
things like icon properties dialog now fit on a 4k monitor
2014-03-17 12:24:03 -04:00
Mike Blumenkrantz 791ed12f7b fix elm win usage 2014-03-14 12:38:01 -04:00
Mike Blumenkrantz 9f310291a7 don't change backlight on zone shutdown 2014-03-14 12:00:23 -04:00
Mike Blumenkrantz ee1cc930c1 ibar mouseover menu no longer breaks when client menu is activated 2014-03-14 11:42:09 -04:00
Carsten Haitzler ad6aa3db71 part of previous commit - also set delete_requested to 0 2014-03-15 00:00:27 +09:00
Mike Blumenkrantz a6148e5e56 fix client resistance visibility check typo
fix T1087
2014-03-14 09:51:57 -04:00
Carsten Haitzler b1373fe63f fix hiding of windows when delete is requested
this is applicable to e19 only (you can't backport this patch as-is -
e19 is too different). this fixes T1063.
2014-03-14 16:25:14 +09:00
Mike Blumenkrantz 19f8126847 prevent fallthrough in determining gcc visibility
CID 1040127
2014-03-13 13:10:55 -04:00
Mike Blumenkrantz b9cdeb17f5 add note about switch statement fallthrough
CID 1040128
2014-03-13 13:09:43 -04:00
Mike Blumenkrantz ce429495bb bugfix: don't deref teamwork pointer after null check
CID 1040134
2014-03-13 13:07:33 -04:00
Mike Blumenkrantz a54fda4530 bugfix: don't deref possibly-null value in mouse bindings
CID 1040138
2014-03-13 13:06:08 -04:00
Mike Blumenkrantz 4b58fa9a4e replace ev->keyname with ev->key
see efl 5ae4cfd1923e502731f4d8fc2bf67b1f536a9216
2014-03-13 13:03:34 -04:00
Mike Blumenkrantz 8422eea8d0 remove unnecessary battery_config null check
CID 1040140
2014-03-13 12:55:24 -04:00
Mike Blumenkrantz d391e5c130 validate params for e_dnd_util_text_uri_list_convert()
CID 1040144
2014-03-13 12:52:36 -04:00
Mike Blumenkrantz 457a385fa7 clamp screen sizes to 1 to avoid impossible division-by-zero for window shots
CID 1040148
2014-03-13 12:50:56 -04:00
Mike Blumenkrantz e0a5cd6e7d bugfix: correctly calculate minimum flowlayout rows
CID 1132740
2014-03-13 12:44:47 -04:00
Mike Blumenkrantz 01abad3f64 bugfix: efm_op no longer tries to close invalid fds during delete ops
CID 1132741
2014-03-13 12:41:53 -04:00
Mike Blumenkrantz 4b3e2797a0 bugfix: don't use external log domain in systray
CID 1132742
2014-03-13 12:40:27 -04:00
Mike Blumenkrantz 6142845ef8 bugfix: don't use external log domain in music player
CID 1132743
2014-03-13 12:38:22 -04:00
Mike Blumenkrantz cea010dce0 bugfix: don't crash when saving screenshots with no file extension
CID 1132744
2014-03-13 12:35:43 -04:00
Mike Blumenkrantz b9eaf4d239 bugfix: don't crash on possibly-null gadman bg string extensions
CID 1132749
2014-03-13 12:35:39 -04:00
Mike Blumenkrantz b373b561e4 check X comp_data existence in pixmap PRESENT usage during refresh
CID 1155279
2014-03-13 12:22:04 -04:00
Mike Blumenkrantz 450d6cf321 add comments to suppress false positives in intentional switch fallthroughs
CIDs 1155283, 1155282, 1155281
2014-03-13 12:20:38 -04:00
Mike Blumenkrantz 9db01b9cbf don't check for non-pointer existence in lokker pin validation
CID 1155284
2014-03-13 12:15:52 -04:00
Mike Blumenkrantz c545deb81c fix gadman resistance checking for fake/desk shelves 2014-03-13 12:15:11 -04:00
Mike Blumenkrantz 26cbbe6723 improve client positioning resistance accuracy for hidden clients and fake shelves 2014-03-13 12:12:28 -04:00
Mike Blumenkrantz fe5f8df001 use E_CLIENT_FOREACH macro for resist calcs
CID 1155285
2014-03-13 12:07:49 -04:00
Mike Blumenkrantz 3f3322cb9c null check auth current user get
CID 1155286
2014-03-13 12:06:04 -04:00
Mike Blumenkrantz 865dc17221 null check client on X stack request
CID 1155287
2014-03-13 12:05:13 -04:00
Mike Blumenkrantz ddcc678d78 ensure va_end is called when creating new pixmaps
CID 1155292
2014-03-13 12:02:11 -04:00
Mike Blumenkrantz de03331469 fix indent for iconic hint setting
seriously?

CID 1156985
2014-03-13 12:00:17 -04:00
Mike Blumenkrantz 537b4054d3 simplify/optimize e_win show trap
CID 1163853
2014-03-13 11:58:16 -04:00
Mike Blumenkrantz 6dd98df0d6 remove all remaining efl version check defines 2014-03-13 11:55:29 -04:00
Mike Blumenkrantz d0589662c5 bugfix: check for unicode string end in client menu
CID 1186203
2014-03-13 11:51:21 -04:00
Mike Blumenkrantz 2b3906d8da bugfix: don't crash when passing NULL desk to e_client_under_pointer_get
CID 1186204
2014-03-13 11:47:44 -04:00
Mike Blumenkrantz dacb821f05 trivial dead code--
CID 1187922
2014-03-13 11:43:53 -04:00
Mike Blumenkrantz 3583d76839 trivial dead code--
CID 1187923
2014-03-13 11:42:49 -04:00
Mike Blumenkrantz b8a3e1ed4f fix probably-impossible divide-by-zero in menu item layout
CID 1187924
2014-03-13 11:41:17 -04:00
Mike Blumenkrantz 400c1f5177 make win->client check more explicit in efm_opinfo
CID 1187925
2014-03-13 11:38:52 -04:00
Mike Blumenkrantz 0a316209aa bugfix: set connman pending.disconnect when disconnecting a service 2014-03-13 11:25:01 -04:00